Skip to content

Commit e52449e

Browse files
authored
fixes the core-theory plugin semantics tags (#1421)
This fix will ensure that if anything is changed in the core theory configuration, then it will be reflected in the output of disassembly. Semantic tags describe the set of features that are provided by a plugin. The caching subsystem relies on them to properly identify the program context and capture it in the context digest that is used to store and retrieve caches. Before this fix, there were no intersection between the tags that describe the disassembler requires (uses) and the set of tags that the core-theory plugin provides.
1 parent bf1a107 commit e52449e

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

plugins/core_theory/core_theory_main.ml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@ let herbrand_provides = [
1010
"lisp";
1111
"debug";
1212
"core:eff";
13-
"core:val"
13+
"core:val";
14+
"lifter";
15+
"semantics";
16+
"symbolizer";
1417
]
1518

1619
let decide_name_from_possible_name () : unit =

plugins/disassemble/disassemble_main.ml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ include Self()
9595
open Bap_main
9696

9797
let features_used = [
98+
"semantics";
9899
"function-starts";
99100
"disassembler";
100101
"lifter";

0 commit comments

Comments
 (0)