th-357: Quality criteria fixes (#362)

* th-357: * files added constants

* th-357: * form constants renamed

* th-357: - star rating

Author: AlexVlaso

backend/src/libs/packages/mailer/mailer.package.ts

@@ -23,7 +23,7 @@ class Mailer {
     this.logger = logger;
   }
 
-  public transporter(): Transporter {
+  public getTransporter(): Transporter {
     if (!this.connection) {
       throw new MailerConnectionError({
         message: 'Mailer: SMTP connection not established.',

backend/src/libs/packages/s3-client-service/s3-client-service.package.ts

@@ -48,9 +48,9 @@ class S3ClientService {
       return null;
     }
 
-    const intArrayContent = await result.Body.transformToByteArray();
+    const contents = await result.Body.transformToByteArray();
 
-    return Buffer.from(intArrayContent);
+    return Buffer.from(contents);
   }
 
   public async getObjectPresignedUrl(

backend/src/libs/packages/server-application/server-app.ts

@@ -99,18 +99,18 @@ class ServerApp implements IServerApp {
       validateFilesStrategy,
     } = parameters;
 
-    const preHandler: preHandlerHookHandler[] = [];
+    const preHandlers: preHandlerHookHandler[] = [];
 
     if (authStrategy) {
       const authStrategyHandler = this.resolveAuthStrategy(authStrategy);
 
       if (authStrategyHandler) {
-        preHandler.push(authStrategyHandler);
+        preHandlers.push(authStrategyHandler);
       }
     }
 
     if (validateFilesStrategy) {
-      preHandler.push(
+      preHandlers.push(
         this.resolveFileValidationStrategy(validateFilesStrategy),
       );
     }
@@ -119,7 +119,7 @@ class ServerApp implements IServerApp {
       url: path,
       method,
       handler,
-      preHandler,
+      preHandler: preHandlers,
       schema: {
         body: validation?.body,
         params: validation?.params,

backend/src/packages/auth/libs/helpers/create-unauthorized-error.helper.ts

@@ -1,11 +1,15 @@
 import { HttpCode } from '~/libs/enums/enums.js';
 import { HttpError } from '~/libs/exceptions/exceptions.js';
 
-const createUnauthorizedError = (message: string, cause?: unknown): HttpError =>
-  new HttpError({
+const createUnauthorizedError = (
+  message: string,
+  cause?: unknown,
+): HttpError => {
+  return new HttpError({
     message,
     status: HttpCode.UNAUTHORIZED,
     cause: cause,
   });
+};
 
 export { createUnauthorizedError };

backend/src/packages/business/business.repository.ts

@@ -50,25 +50,25 @@ class BusinessRepository implements IRepository {
     companyName,
     ownerId,
   }: Partial<BusinessEntityT>): Promise<OperationResult<boolean>> {
-    const filterClause: SQL[] = [];
+    const filterClauses: SQL[] = [];
 
     if (id) {
-      filterClause.push(eq(this.businessSchema.id, id));
+      filterClauses.push(eq(this.businessSchema.id, id));
     }
 
     if (taxNumber) {
-      filterClause.push(eq(this.businessSchema.taxNumber, taxNumber));
+      filterClauses.push(eq(this.businessSchema.taxNumber, taxNumber));
     }
 
     if (companyName) {
-      filterClause.push(eq(this.businessSchema.companyName, companyName));
+      filterClauses.push(eq(this.businessSchema.companyName, companyName));
     }
 
     if (ownerId) {
-      filterClause.push(eq(this.businessSchema.ownerId, ownerId));
+      filterClauses.push(eq(this.businessSchema.ownerId, ownerId));
     }
 
-    if (filterClause.length === 0) {
+    if (filterClauses.length === 0) {
       throw new ApplicationError({
         message: AppErrorMessage.INVALID_QUERY,
       });
@@ -78,7 +78,7 @@ class BusinessRepository implements IRepository {
       .driver()
       .select()
       .from(this.businessSchema)
-      .where(or(...filterClause));
+      .where(or(...filterClauses));
 
     return {
       result: Boolean(business),

backend/src/packages/drivers/driver.repository.ts

@@ -79,19 +79,19 @@ class DriverRepository implements IRepository {
     driverLicenseNumber,
     userId,
   }: Partial<DriverEntityT>): Promise<OperationResult<boolean>> {
-    const filterClause: SQL[] = [];
+    const filterClauses: SQL[] = [];
 
     if (driverLicenseNumber) {
-      filterClause.push(
+      filterClauses.push(
         eq(this.driverSchema.driverLicenseNumber, driverLicenseNumber),
       );
     }
 
     if (userId) {
-      filterClause.push(eq(this.driverSchema.userId, userId));
+      filterClauses.push(eq(this.driverSchema.userId, userId));
     }
 
-    if (filterClause.length === 0) {
+    if (filterClauses.length === 0) {
       throw new ApplicationError({
         message: AppErrorMessage.INVALID_QUERY,
       });
@@ -101,7 +101,7 @@ class DriverRepository implements IRepository {
       .driver()
       .select()
       .from(this.driverSchema)
-      .where(or(...filterClause));
+      .where(or(...filterClauses));
 
     return {
       result: Boolean(driver),

backend/src/packages/mail/mail.service.ts

@@ -16,7 +16,7 @@ class MailService {
   }
 
   public async sendText(header: SendTextMailHeader): Promise<void> {
-    await this.mailer.transporter().sendMail({ ...header });
+    await this.mailer.getTransporter().sendMail({ ...header });
   }
 
   public async sendPage<T extends TemplateNameValues = TemplateNameValues>(
@@ -26,7 +26,7 @@ class MailService {
   ): Promise<void> {
     const chosenView = templateNameToView[viewName];
     await this.mailer
-      .transporter()
+      .getTransporter()
       .sendMail({ ...header, html: chosenView.render(viewParameters) });
   }
 }

backend/src/packages/map/libs/constants/constants.ts

@@ -1,3 +1,4 @@
 const METERS_IN_ONE_KM = 1000;
+const PRECISION = 2;
 
-export { METERS_IN_ONE_KM };
+export { METERS_IN_ONE_KM, PRECISION };

backend/src/packages/map/map.service.ts

@@ -1,3 +1,4 @@
+import { PRECISION } from './libs/constants/constants.js';
 import { TravelMode } from './libs/enums/enums.js';
 import { convertMetersToKm } from './libs/helpers/helpers.js';
 import {
@@ -29,10 +30,10 @@ class MapService {
         mode: TravelMode.driving,
       },
     });
-    const [resultArray] = response.data.rows;
-    const [resultElement] = resultArray.elements;
+    const [firstRow] = response.data.rows;
+    const [firstElement] = firstRow.elements;
 
-    return resultElement.distance;
+    return firstElement.distance;
   }
 
   public async getPriceByDistance({
@@ -42,7 +43,7 @@ class MapService {
   }: OrderCalculatePriceRequestDto): Promise<OrderCalculatePriceResponseDto> {
     const distance = await this.getDistance(startAddress, endAddress);
     const km = convertMetersToKm(distance.value);
-    const orderPrice = (pricePerKm * km).toFixed(2);
+    const orderPrice = (pricePerKm * km).toFixed(PRECISION);
 
     return { price: Number(orderPrice) };
   }

backend/src/packages/trucks/truck.service.ts

@@ -57,11 +57,11 @@ class TruckService implements IService {
   public async create(
     payload: Omit<TruckEntityT, 'id' | 'createdAt' | 'status'>,
   ): Promise<TruckEntityT> {
-    const existingTruck = await this.repository.find(
+    const existingTrucks = await this.repository.find(
       payload.licensePlateNumber,
     );
 
-    if (existingTruck.length > 0) {
+    if (existingTrucks.length > 0) {
       throw new HttpError({
         status: HttpCode.BAD_REQUEST,
         message: HttpMessage.TRUCK_EXISTS,