fix: error toasts for invalid meeting ids ml-275 (#319)

* fix: change project versions  ml-131

* fix: package-lock was changed ml-211

* fix: pull main ml-211

* fix: update main ml-206

* fix: change package-lock.json ml-206

* fix: pull main branch ml-206

* fix: error toasts for invalid meeting ids ml-275

* fix: pull main  ml-206

* fix: change variable naming ml-206

* fix: move validation to backend ml-275

* fix: pull main ml-275

Author: ulianchenko

apps/backend/src/modules/meetings/libs/validation-schemas/validation-schemas.ts

@@ -1,5 +1,5 @@
 export {
 	meetingCreateValidationSchema,
-	meetingIdValidationSchema,
+	meetingIdRouteParameterValidationSchema,
 	meetingUpdateValidationSchema,
 } from "@meetlytic/shared";

apps/backend/src/modules/meetings/meetings.controller.ts

@@ -20,7 +20,7 @@ import {
 } from "./libs/types/types.js";
 import {
 	meetingCreateValidationSchema,
-	meetingIdValidationSchema,
+	meetingIdRouteParameterValidationSchema,
 	meetingUpdateValidationSchema,
 } from "./libs/validation-schemas/validation-schemas.js";
 import { type MeetingService } from "./meetings.service.js";
@@ -107,7 +107,10 @@ class MeetingsController extends BaseController {
 			method: HTTPMethod.PATCH,
 			path: MeetingsApiPath.$ID,
 			preHandlers: [checkIfMeetingOwner(this.meetingService)],
-			validation: { body: meetingUpdateValidationSchema },
+			validation: {
+				body: meetingUpdateValidationSchema,
+				params: meetingIdRouteParameterValidationSchema,
+			},
 		});
 
 		this.addRoute({
@@ -116,7 +119,7 @@ class MeetingsController extends BaseController {
 			path: MeetingsApiPath.$ID,
 			preHandlers: [checkIfMeetingOwner(this.meetingService)],
 			validation: {
-				params: meetingIdValidationSchema,
+				params: meetingIdRouteParameterValidationSchema,
 			},
 		});
 
@@ -126,7 +129,7 @@ class MeetingsController extends BaseController {
 			path: MeetingsApiPath.$ID,
 			preHandlers: [checkIfMeetingOwner(this.meetingService)],
 			validation: {
-				params: meetingIdValidationSchema,
+				params: meetingIdRouteParameterValidationSchema,
 			},
 		});
 
@@ -140,18 +143,27 @@ class MeetingsController extends BaseController {
 			method: HTTPMethod.GET,
 			path: MeetingsApiPath.$ID_URL,
 			preHandlers: [checkIfMeetingOwner(this.meetingService)],
+			validation: {
+				params: meetingIdRouteParameterValidationSchema,
+			},
 		});
 		this.addRoute({
 			handler: (options) =>
 				this.findBySignedUrl(options as FindBySignedUrlOptions),
 			method: HTTPMethod.GET,
 			path: MeetingsApiPath.$ID_PUBLIC,
+			validation: {
+				params: meetingIdRouteParameterValidationSchema,
+			},
 		});
 		this.addRoute({
 			handler: (options) => this.stopRecording(options as StopRecordingOptions),
 			method: HTTPMethod.DELETE,
 			path: MeetingsApiPath.$ID_STOP_RECORDING,
 			preHandlers: [checkIfMeetingOwner(this.meetingService)],
+			validation: {
+				params: meetingIdRouteParameterValidationSchema,
+			},
 		});
 		this.addRoute({
 			handler: (options) =>
@@ -161,12 +173,18 @@ class MeetingsController extends BaseController {
 			method: HTTPMethod.GET,
 			path: MeetingsApiPath.$ID_MEETING_TRANSCRIPTIONS,
 			preHandlers: [checkIfMeetingOwner(this.meetingService)],
+			validation: {
+				params: meetingIdRouteParameterValidationSchema,
+			},
 		});
 		this.addRoute({
 			handler: (options) =>
 				this.getTranscriptionsBySignedUrl(options as FindBySignedUrlOptions),
 			method: HTTPMethod.GET,
 			path: MeetingsApiPath.$ID_MEETING_TRANSCRIPTIONS_PUBLIC,
+			validation: {
+				params: meetingIdRouteParameterValidationSchema,
+			},
 		});
 	}
 

package-lock.json

@@ -84,7 +84,7 @@ export {
 	meetingCreateValidationSchema,
 	MeetingErrorMessage,
 	MeetingHost,
-	meetingIdValidationSchema,
+	meetingIdRouteParameterValidationSchema,
 	MeetingsApiPath,
 	MeetingStatus,
 	MeetingTranscriptionErrorMessage,

packages/shared/src/index.ts

@@ -3,6 +3,12 @@ import { MeetingValidationRule } from "./meeting-validation-rule.enum.js";
 const MeetingValidationMessage = {
 	HOST_REQUIRE: "Host is required.",
 	HOST_WRONG: "This host isn't allowed.",
+	MEETING_ID_MUST_BE_INTEGER: "Meeting ID must be an integer.",
+	MEETING_ID_MUST_BE_NUMBER:
+		"Invalid meeting ID format. Please enter a valid number.",
+	MEETING_ID_MUST_BE_POSITIVE: "Meeting ID must be a positive number.",
+	MEETING_ID_TOO_LARGE:
+		"The meeting ID entered is invalid. Please check the ID and try again.",
 	MEETING_TITLE_MAXIMUM_LENGTH: `Meeting title must not exceed ${String(MeetingValidationRule.MEETING_TITLE_MAXIMUM_LENGTH)} characters`,
 	OWNER_REQUIRE: "Owner ID must be a positive number.",
 	STATUS_WRONG: "This status doesn't exist",

packages/shared/src/modules/meetings/libs/enums/meeting-validation-message.enum.ts

@@ -1,4 +1,5 @@
 const MeetingValidationRule = {
+	MEETING_ID_MAXIMUM_NUMBER: 2_147_483_647,
 	MEETING_TITLE_MAXIMUM_LENGTH: 25,
 	MINIMAL_HOST_LENGTH: 1,
 	MINIMAL_MEETING_ID_LENGTH: 1,

packages/shared/src/modules/meetings/libs/enums/meeting-validation-rule.enum.ts

@@ -0,0 +1,20 @@
+import { z } from "zod";
+
+import {
+	MeetingValidationMessage,
+	MeetingValidationRule,
+} from "../enums/enums.js";
+
+const meetingIdRouteParameter = z.object({
+	id: z.coerce
+		.number({
+			invalid_type_error: MeetingValidationMessage.MEETING_ID_MUST_BE_NUMBER,
+		})
+		.int(MeetingValidationMessage.MEETING_ID_MUST_BE_INTEGER)
+		.positive(MeetingValidationMessage.MEETING_ID_MUST_BE_POSITIVE)
+		.max(MeetingValidationRule.MEETING_ID_MAXIMUM_NUMBER, {
+			message: MeetingValidationMessage.MEETING_ID_TOO_LARGE,
+		}),
+});
+
+export { meetingIdRouteParameter };

packages/shared/src/modules/meetings/libs/validation-schemas/meeting-id-route-parameter.validation-schema.ts

@@ -1,3 +1,3 @@
 export { meetingCreate } from "./meeting-create.validation-schema.js";
-export { meetingId } from "./meeting-id.validation-schema.js";
+export { meetingIdRouteParameter } from "./meeting-id-route-parameter.validation-schema.js";
 export { meetingUpdate } from "./meeting-update.validation-schema.js";

packages/shared/src/modules/meetings/libs/validation-schemas/meeting-id.validation-schema.ts

@@ -24,6 +24,6 @@ export {
 } from "./libs/types/types.js";
 export {
 	meetingCreate as meetingCreateValidationSchema,
-	meetingId as meetingIdValidationSchema,
+	meetingIdRouteParameter as meetingIdRouteParameterValidationSchema,
 	meetingUpdate as meetingUpdateValidationSchema,
 } from "./libs/validation-schemas/validation-schemas.js";