Skip to content
This repository was archived by the owner on Nov 11, 2025. It is now read-only.

Commit 653ea47

Browse files
authored
Apply suggestions from code review
1 parent f541753 commit 653ea47

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

src/Microsoft.OpenApi/Models/OpenApiOAuthFlow.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ private void SerializeInternal(IOpenApiWriter writer, OpenApiSpecVersion version
108108
// For OpenAPI 3.1 and 3.0, serialize as an extension with x-oai- prefix
109109
if (DeviceAuthorizationUrl != null)
110110
{
111-
if (version == OpenApiSpecVersion.OpenApi3_2)
111+
if (version >= OpenApiSpecVersion.OpenApi3_2)
112112
{
113113
writer.WriteProperty(OpenApiConstants.DeviceAuthorizationUrl, DeviceAuthorizationUrl.ToString());
114114
}

test/Microsoft.OpenApi.Tests/Models/OpenApiOAuthFlowTests.cs

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,7 @@ public async Task SerializeOAuthFlowWithDeviceAuthorizationUrlAsV32JsonWorks()
156156
var actual = await OAuthFlowWithDeviceAuthorizationUrl.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_2);
157157

158158
// Assert
159-
actual = actual.MakeLineBreaksEnvironmentNeutral();
160-
expected = expected.MakeLineBreaksEnvironmentNeutral();
161-
Assert.Equal(expected, actual);
159+
JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
162160
}
163161

164162
[Fact]
@@ -183,9 +181,7 @@ public async Task SerializeOAuthFlowWithDeviceAuthorizationUrlAsV31JsonWorks()
183181
var actual = await OAuthFlowWithDeviceAuthorizationUrl.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_1);
184182

185183
// Assert
186-
actual = actual.MakeLineBreaksEnvironmentNeutral();
187-
expected = expected.MakeLineBreaksEnvironmentNeutral();
188-
Assert.Equal(expected, actual);
184+
JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
189185
}
190186

191187
[Fact]
@@ -210,9 +206,7 @@ public async Task SerializeOAuthFlowWithDeviceAuthorizationUrlAsV3JsonWorks()
210206
var actual = await OAuthFlowWithDeviceAuthorizationUrl.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_0);
211207

212208
// Assert
213-
actual = actual.MakeLineBreaksEnvironmentNeutral();
214-
expected = expected.MakeLineBreaksEnvironmentNeutral();
215-
Assert.Equal(expected, actual);
209+
JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
216210
}
217211
}
218212
}

0 commit comments

Comments
 (0)