Skip to content

Commit 865295a

Browse files
authored
Apply suggestions from code review
1 parent 4c8a380 commit 865295a

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

test/Microsoft.OpenApi.Tests/Models/OpenApiEncodingTests.cs

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// Licensed under the MIT license.
33

44
using System.Collections.Generic;
5+
using System.Text.Json.Nodes;
56
using System.Threading.Tasks;
67
using Xunit;
78

@@ -171,9 +172,7 @@ public async Task SerializeEncodingWithNestedEncodingAsV32JsonWorks()
171172
var actual = await encoding.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_2);
172173

173174
// Assert
174-
actual = actual.MakeLineBreaksEnvironmentNeutral();
175-
expected = expected.MakeLineBreaksEnvironmentNeutral();
176-
Assert.Equal(expected, actual);
175+
Assert.True(JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
177176
}
178177

179178
[Fact]
@@ -214,9 +213,7 @@ public async Task SerializeEncodingWithNestedEncodingAsV32YamlWorks()
214213
var actual = await encoding.SerializeAsYamlAsync(OpenApiSpecVersion.OpenApi3_2);
215214

216215
// Assert
217-
actual = actual.MakeLineBreaksEnvironmentNeutral();
218-
expected = expected.MakeLineBreaksEnvironmentNeutral();
219-
Assert.Equal(expected, actual);
216+
Assert.True(JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
220217
}
221218

222219
[Fact]
@@ -271,9 +268,7 @@ public async Task SerializeEncodingWithItemAndPrefixEncodingAsV32JsonWorks()
271268
var actual = await encoding.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_2);
272269

273270
// Assert
274-
actual = actual.MakeLineBreaksEnvironmentNeutral();
275-
expected = expected.MakeLineBreaksEnvironmentNeutral();
276-
Assert.Equal(expected, actual);
271+
Assert.True(JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
277272
}
278273

279274
[Fact]
@@ -321,9 +316,7 @@ public async Task SerializeEncodingAsV31ShouldUseExtensionsForNewFields()
321316
var actual = await encoding.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_1);
322317

323318
// Assert
324-
actual = actual.MakeLineBreaksEnvironmentNeutral();
325-
expected = expected.MakeLineBreaksEnvironmentNeutral();
326-
Assert.Equal(expected, actual);
319+
Assert.True(JsonNode.DeepEquals(JsonNode.Parse(actual), JsonNode.Parse(expected)));
327320
}
328321
}
329322
}

0 commit comments

Comments
 (0)