Skip to content

Commit c27dd93

Browse files
authored
Merge pull request #48 from BinkyLabs/docs/contributing-updates
docs: adds guidance regarding branches
2 parents e29b387 + e964e9a commit c27dd93

File tree

2 files changed

+79
-1
lines changed

2 files changed

+79
-1
lines changed

.github/pull_request_template.md

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# Pull Request
2+
3+
<!--
4+
Thank you for contributing to OpenAPI.NET!
5+
Please fill out the template below to help us review your pull request.
6+
-->
7+
8+
## Description
9+
<!-- Provide a brief description of your changes -->
10+
11+
## Type of Change
12+
<!-- Mark the relevant option with an "x" -->
13+
- [ ] Bug fix (non-breaking change which fixes an issue)
14+
- [ ] New feature (non-breaking change which adds functionality)
15+
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
16+
- [ ] Documentation update
17+
- [ ] Other (please describe):
18+
19+
## Related Issue(s)
20+
<!-- Link to any related issues using "Fixes #123" or "Closes #123" -->
21+
22+
## Changes Made
23+
<!-- List the main changes made in this PR -->
24+
-
25+
-
26+
-
27+
28+
## Testing
29+
<!-- Describe how you tested your changes -->
30+
- [ ] Unit tests added/updated
31+
- [ ] Integration tests added/updated
32+
- [ ] Manual testing performed
33+
- [ ] All existing tests pass
34+
35+
## Checklist
36+
<!-- Mark completed items with an "x" -->
37+
- [ ] My code follows the code style of this project
38+
- [ ] I have performed a self-review of my own code
39+
- [ ] I have made corresponding changes to the documentation
40+
- [ ] My changes generate no new warnings
41+
- [ ] I have added tests that prove my fix is effective or that my feature works
42+
- [ ] New and existing unit tests pass locally with my changes
43+
44+
## Versions applicability
45+
46+
- [ ] My change applies to the version 1.X of the library, if so PR link:
47+
- [ ] My change applies to the version 2.X of the library, if so PR link:
48+
- [ ] My change applies to the version 3.X of the library, if so PR link:
49+
- [ ] I have evaluated the applicability of my change against the other versions above.
50+
51+
See [the contributing guidelines](https://github.com/microsoft/OpenAPI.NET/blob/main/CONTRIBUTING.md) for more information about how patches are applied across multiple versions.
52+
53+
## Additional Notes
54+
<!-- Add any additional information that reviewers should know -->

CONTRIBUTING.md

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,31 @@ The best way to get started with a contribution is to start a dialog with the ow
2020

2121
## Submit pull requests for bug fixes and features
2222

23-
Feel free to submit a pull request with a linked issue against the __main__ branch. The main branch will be updated frequently.
23+
Feel free to submit a pull request with a linked issue.
24+
25+
### Branches and support policy
26+
27+
Because one major consumer of these libraries is ASP.net, the support policy of this repository is aligned with [dotnet support policy](https://dotnet.microsoft.com/platform/support/policy/dotnet-core#lifecycle).
28+
29+
The following table outlines the mapping between package major versions, dotnet versions, and which contributions are accepted. As a consumer, make sure the version of this library your application is using is aligned with the version of ASP.net described in the table below.
30+
31+
| Major version | Branch | Supported ASP.NET versions | Supported OpenAPI versions | Changes provided by Microsoft | Accepted contributions | End of support date |
32+
| ------------- | ---------- | -------------------------- | -------------------------- | ------------------------------------------- | ------------------------------------------- | --------------- |
33+
| 1.X | support/v1 | < 10 | 2.0, 3.0 | security fixes | security and bugfixes | net 9 (Nov 2026) |
34+
| 2.X | support/v2 | = 10 * | 2.0, 3.0, 3.1 | security and bugfixes | security and bugfixes | net 10 (Nov 2028) * |
35+
| 3.X | main | not available | 2.0, 3.0, 3.1, 3.2 | security, bugfixes and feature improvements | security, bugfixes and feature improvements | TBD ** |
36+
37+
> Notes:
38+
>
39+
> * This assumes that NET 11 and above will adopt version 3 or above of this library, otherwise, it'd expand the support date for version 2 of this library.
40+
> ** This will be conditioned by new releases of OpenAPI, this library, asp.net and asp.net's adoptions of new versions of this library.
41+
42+
### Multi-versions requirement for contributions
43+
44+
When contributing to the library, start by making a contribution to the main branch first, or the uppermost version it applies to. During the review process you'll be asked to demonstrate your contribution cannot apply to prior versions or to port your contribution to the branches for prior versions before the initial pull request can get merged.
45+
46+
This approach helps maintain a similar behavior across all versions under active support.
47+
2448
## Commit message format
2549

2650
To support our automated release process, pull requests are required to follow the [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/)

0 commit comments

Comments
 (0)