Apply suggestions from code review

Author: baywet

src/Microsoft.OpenApi/Reader/V31/OpenApiSecuritySchemeDeserializer.cs

@@ -73,16 +73,6 @@ internal static partial class OpenApiV31Deserializer
                     {
                         o.Flows = LoadOAuthFlows(n, t);
                     }
-                },
-                {
-                    "deprecated", (o, n, _) =>
-                    {
-                        var deprecated = n.GetScalarValue();
-                        if (deprecated != null)
-                        {
-                            o.Deprecated = bool.Parse(deprecated);
-                        }
-                    }
                 }
             };
 

test/Microsoft.OpenApi.Readers.Tests/V31Tests/OpenApiSecuritySchemeReferenceDeserializerTests.cs

@@ -67,33 +67,4 @@ public void ShouldDeserializeSecuritySchemeWithXOaiDeprecatedExtension()
         Assert.Equal(ParameterLocation.Header, resultScheme.In);
         Assert.True(resultScheme.Deprecated);
     }
-
-    [Fact]
-    public void ShouldDeserializeSecuritySchemeWithDeprecatedField()
-    {
-        var json =
-        """
-        {
-            "type": "apiKey",
-            "description": "This is a deprecated security scheme",
-            "name": "api_key",
-            "in": "header",
-            "deprecated": true
-        }
-        """;
-
-        var hostDocument = new OpenApiDocument();
-        var jsonNode = JsonNode.Parse(json);
-        var parseNode = ParseNode.Create(new ParsingContext(new()), jsonNode);
-
-        var result = OpenApiV31Deserializer.LoadSecurityScheme(parseNode, hostDocument);
-
-        Assert.NotNull(result);
-        var resultScheme = Assert.IsType<OpenApiSecurityScheme>(result);
-
-        Assert.Equal(SecuritySchemeType.ApiKey, resultScheme.Type);
-        Assert.Equal("api_key", resultScheme.Name);
-        Assert.Equal(ParameterLocation.Header, resultScheme.In);
-        Assert.True(resultScheme.Deprecated);
-    }
 }

test/Microsoft.OpenApi.Tests/Models/OpenApiSecuritySchemeTests.cs

@@ -358,9 +358,7 @@ public async Task SerializeDeprecatedSecuritySchemeAsV32JsonWorks()
             var actual = await DeprecatedApiKeySecurityScheme.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_2);
 
             // Assert
-            actual = actual.MakeLineBreaksEnvironmentNeutral();
-            expected = expected.MakeLineBreaksEnvironmentNeutral();
-            Assert.Equal(expected, actual);
+            Assert.True(JsonNode.DeepEquals(JsonNode.Parse(expected), JsonNode.Parse(actual)));
         }
 
         [Fact]
@@ -382,9 +380,7 @@ public async Task SerializeDeprecatedSecuritySchemeAsV31JsonWorks()
             var actual = await DeprecatedApiKeySecurityScheme.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_1);
 
             // Assert
-            actual = actual.MakeLineBreaksEnvironmentNeutral();
-            expected = expected.MakeLineBreaksEnvironmentNeutral();
-            Assert.Equal(expected, actual);
+            Assert.True(JsonNode.DeepEquals(JsonNode.Parse(expected), JsonNode.Parse(actual)));
         }
 
         [Fact]
@@ -406,9 +402,7 @@ public async Task SerializeDeprecatedSecuritySchemeAsV3JsonWorks()
             var actual = await DeprecatedApiKeySecurityScheme.SerializeAsJsonAsync(OpenApiSpecVersion.OpenApi3_0);
 
             // Assert
-            actual = actual.MakeLineBreaksEnvironmentNeutral();
-            expected = expected.MakeLineBreaksEnvironmentNeutral();
-            Assert.Equal(expected, actual);
+            Assert.True(JsonNode.DeepEquals(JsonNode.Parse(expected), JsonNode.Parse(actual)));
         }
     }
 }