chore: fixes reference comparison

baywet · baywet · commit f550dc8587c2 · 2025-10-03T08:16:47.000-04:00
Signed-off-by: Vincent Biret &lt;vibiret@microsoft.com&gt;
diff --git a/src/Microsoft.OpenApi/Models/References/OpenApiTagReference.cs b/src/Microsoft.OpenApi/Models/References/OpenApiTagReference.cs
@@ -68,13 +68,12 @@ public OpenApiTagReference? Parent
         { 
             get 
             {
-                var target = Target;
-                if (target is OpenApiTagReference targetRef && ReferenceEquals(targetRef.Reference, this.Reference))
+                if (Target is OpenApiTagReference targetRef && (Reference.Id?.Equals(targetRef.Reference.Id, StringComparison.Ordinal) ?? false))
                 {
                     return null;
                 }
 
-                return target?.Parent;
+                return Target?.Parent;
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -68,13 +68,12 @@ public OpenApiTagReference? Parent`
`68`	`68`	`{`
`69`	`69`	`get`
`70`	`70`	`{`
`71`		`- var target = Target;`
`72`		`- if (target is OpenApiTagReference targetRef && ReferenceEquals(targetRef.Reference, this.Reference))`
	`71`	`+ if (Target is OpenApiTagReference targetRef && (Reference.Id?.Equals(targetRef.Reference.Id, StringComparison.Ordinal) ?? false))`
`73`	`72`	`{`
`74`	`73`	`return null;`
`75`	`74`	`}`
`76`	`75`
`77`		`- return target?.Parent;`
	`76`	`+ return Target?.Parent;`
`78`	`77`	`}`
`79`	`78`	`}`
`80`	`79`