test: adds tests for 30 deserialization of path items with extra ops

Signed-off-by: Vincent Biret <[email protected]>

Author: baywet

test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiPathItemDeserializerTests.cs

@@ -0,0 +1,47 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license.
+
+using System.Collections.Generic;
+using System.Net.Http;
+using System.Text.Json.Nodes;
+using System.Threading.Tasks;
+using Xunit;
+
+namespace Microsoft.OpenApi.Readers.Tests.V3Tests;
+
+public class OpenApiPathItemDeserializerTests
+{
+    private const string SampleFolderPath = "V3Tests/Samples/OpenApiPathItem/";
+
+    [Fact]
+    public async Task ExtraneousOperationsAreParsedAsExtensionsIn30()
+    {
+        // Arrange & Act
+        var result = await OpenApiDocument.LoadAsync($"{SampleFolderPath}pathItemWithQueryAndAdditionalOperations.yaml", SettingsFixture.ReaderSettings);
+        var pathItem = result.Document.Paths["/pets"];
+
+        // Assert
+        Assert.Equal("Pet operations", pathItem.Summary);
+        Assert.Equal("Operations available for pets", pathItem.Description);
+
+        // Regular operations
+        var getOp = Assert.Contains(HttpMethod.Get, pathItem.Operations);
+        Assert.Equal("getPets", getOp.OperationId);
+
+        var postOp = Assert.Contains(HttpMethod.Post, pathItem.Operations);
+        Assert.Equal("createPet", postOp.OperationId);
+
+        // Query operation should now be on one of the operations
+        // Since the YAML structure changed, we need to check which operation has the query
+        Assert.DoesNotContain(new HttpMethod("Query"), pathItem.Operations);
+        Assert.DoesNotContain(new HttpMethod("notify"), pathItem.Operations);
+        Assert.DoesNotContain(new HttpMethod("subscribe"), pathItem.Operations);
+
+        var additionalPathsExt = Assert.IsType<JsonNodeExtension>(Assert.Contains("x-oai-additionalOperations", pathItem.Extensions));
+
+        var additionalOpsNode = Assert.IsType<JsonObject>(additionalPathsExt.Node);
+        Assert.Contains("query", additionalOpsNode);
+        Assert.Contains("notify", additionalOpsNode);
+        Assert.Contains("subscribe", additionalOpsNode);
+    }
+}

test/Microsoft.OpenApi.Readers.Tests/V3Tests/Samples/OpenApiPathItem/pathItemWithQueryAndAdditionalOperations.yaml

@@ -12,8 +12,8 @@ paths:
       responses:
         '200':
           description: List of pets
-      x-oai-additionalOperations:
-        query:
+    x-oai-additionalOperations:
+      query:
         summary: Query pets with complex filters
         operationId: queryPets
         parameters:
@@ -31,44 +31,44 @@ paths:
                   type: array
                   items:
                     type: object
-        notify:
-          summary: Notify about pet updates
-          operationId: notifyPetUpdates
-          requestBody:
-            required: true
+      notify:
+        summary: Notify about pet updates
+        operationId: notifyPetUpdates
+        requestBody:
+          required: true
+          content:
+            application/json:
+              schema:
+                type: object
+                properties:
+                  petId:
+                    type: string
+                  event:
+                    type: string
+          responses:
+            '200':
+              description: Notification sent
+      subscribe:
+        summary: Subscribe to pet events
+        operationId: subscribePetEvents
+        parameters:
+          - name: events
+            in: query
+            description: Event types to subscribe to
+            schema:
+              type: array
+              items:
+                type: string
+        responses:
+          '200':
+            description: Subscription created
             content:
               application/json:
                 schema:
                   type: object
                   properties:
-                    petId:
+                    subscriptionId:
                       type: string
-                    event:
-                      type: string
-          responses:
-            '200':
-              description: Notification sent
-        subscribe:
-          summary: Subscribe to pet events
-          operationId: subscribePetEvents
-          parameters:
-            - name: events
-              in: query
-              description: Event types to subscribe to
-              schema:
-                type: array
-                items:
-                  type: string
-          responses:
-            '200':
-              description: Subscription created
-              content:
-                application/json:
-                  schema:
-                    type: object
-                    properties:
-                      subscriptionId:
-                        type: string
     post:
       summary: Create pet
       operationId: createPet