From b29f5dab6e7b242fb0f1137f49181c57f1b263b0 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Fri, 3 Oct 2025 12:26:17 -0400 Subject: [PATCH 1/2] chore: adds missing unit tests for 32 after main refresh Signed-off-by: Vincent Biret --- .../V32Tests/OpenApiEncodingTests.cs | 33 +++++++++++++++++++ .../encodingWithAllowReserved.yaml | 5 +++ 2 files changed, 38 insertions(+) create mode 100644 test/Microsoft.OpenApi.Readers.Tests/V32Tests/OpenApiEncodingTests.cs create mode 100644 test/Microsoft.OpenApi.Readers.Tests/V32Tests/Samples/OpenApiEncoding/encodingWithAllowReserved.yaml diff --git a/test/Microsoft.OpenApi.Readers.Tests/V32Tests/OpenApiEncodingTests.cs b/test/Microsoft.OpenApi.Readers.Tests/V32Tests/OpenApiEncodingTests.cs new file mode 100644 index 000000000..ac761c991 --- /dev/null +++ b/test/Microsoft.OpenApi.Readers.Tests/V32Tests/OpenApiEncodingTests.cs @@ -0,0 +1,33 @@ +// Copyright (c) Microsoft Corporation. All rights reserved. +// Licensed under the MIT license. + +using System.IO; +using System.Threading.Tasks; +using Microsoft.OpenApi.Reader; +using Xunit; + +namespace Microsoft.OpenApi.Readers.Tests.V32Tests +{ + [Collection("DefaultSettings")] + public class OpenApiEncodingTests + { + private const string SampleFolderPath = "V32Tests/Samples/OpenApiEncoding/"; + + [Fact] + public async Task ParseEncodingWithAllowReservedShouldSucceed() + { + // Act + var encoding = await OpenApiModelFactory.LoadAsync(Path.Combine(SampleFolderPath, "encodingWithAllowReserved.yaml"), OpenApiSpecVersion.OpenApi3_2, new(), SettingsFixture.ReaderSettings); + + // Assert + Assert.Equivalent( + new OpenApiEncoding + { + ContentType = "application/x-www-form-urlencoded", + Style = ParameterStyle.Form, + Explode = true, + AllowReserved = true + }, encoding); + } + } +} diff --git a/test/Microsoft.OpenApi.Readers.Tests/V32Tests/Samples/OpenApiEncoding/encodingWithAllowReserved.yaml b/test/Microsoft.OpenApi.Readers.Tests/V32Tests/Samples/OpenApiEncoding/encodingWithAllowReserved.yaml new file mode 100644 index 000000000..fcb6c1063 --- /dev/null +++ b/test/Microsoft.OpenApi.Readers.Tests/V32Tests/Samples/OpenApiEncoding/encodingWithAllowReserved.yaml @@ -0,0 +1,5 @@ +# https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#encodingObject +contentType: application/x-www-form-urlencoded +style: form +explode: true +allowReserved: true From ef540cd971d222ff3c8f527ad224817cee431d31 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Fri, 3 Oct 2025 12:27:39 -0400 Subject: [PATCH 2/2] chore: updates outdated comment --- .../Samples/OpenApiEncoding/encodingWithAllowReserved.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Microsoft.OpenApi.Readers.Tests/V32Tests/Samples/OpenApiEncoding/encodingWithAllowReserved.yaml b/test/Microsoft.OpenApi.Readers.Tests/V32Tests/Samples/OpenApiEncoding/encodingWithAllowReserved.yaml index fcb6c1063..1e6c47865 100644 --- a/test/Microsoft.OpenApi.Readers.Tests/V32Tests/Samples/OpenApiEncoding/encodingWithAllowReserved.yaml +++ b/test/Microsoft.OpenApi.Readers.Tests/V32Tests/Samples/OpenApiEncoding/encodingWithAllowReserved.yaml @@ -1,4 +1,4 @@ -# https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#encodingObject +# https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.2.0.md#encodingObject contentType: application/x-www-form-urlencoded style: form explode: true