Commit cc74757
committed
Add resize and scale support to create KhronosGroup#999
Missing functionality from the legacy tool added so we can comfortably remove the legacy tools in 4.5.
The following issues were discovered and fixed while adding the features:
* The target imageSpec was being updated for every input file. This
was only working because, until now, nothing had looked at the spec
values that were being changed once the texture had been created.
The fix is to make separate determineSourceColorSpace and
determineTargetColorSpace functions.
* An associated fix to the above is to move the checks for non-null
transferFunctions to the use site with fatal errors thrown then if
they are null. This avoids the need for second guessing to avoid
the fatal errors when the transferFunctions will not be used. With
this and the above fix, the code is now much more robust and clear.
* Full help was missing --levels.
* Full help had an incorrect statement regarding implicit color
conversions dating from the transfer function work.1 parent 171ace4 commit cc74757
3 files changed
+390
-184
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
214 | 240 | | |
215 | 241 | | |
216 | 242 | | |
| |||
0 commit comments