Fixup

Author: jakobnissen

src/bit-manipulation/bit-manipulation.jl

@@ -1,6 +1,7 @@
 const BitUnsigned = Union{UInt8, UInt16, UInt32, UInt64}
 
 @inline reversebits(x::Unsigned, ::BitsPerSymbol{8}) = bswap(x)
+@inline reversebits(x::Unsigned, ::BitsPerSymbol{1}) = bitreverse(x)
 
 @inline function reversebits(x::T, ::BitsPerSymbol{2}) where T <: BitUnsigned
     mask = 0x3333333333333333 % T
@@ -23,15 +24,18 @@ end
 
 @inline reversebits(x::UInt32, ::BitsPerSymbol{32}) = x
 @inline function reversebits(x::UInt64, ::BitsPerSymbol{32})
-    mask = 0x00000000FFFFFFF
+    mask = 0x00000000FFFFFFFF
     x = ((x >> 32) & mask) | ((x & mask) << 32)
     reversebits(x, BitsPerSymbol{64}())
 end
 
 @inline reversebits(x::UInt64, ::BitsPerSymbol{64}) = x
 
 # Generic method for large integers, or odd-sized integers
-@inline function reversebits(x::Unsigned, b::BitsPerSymbol)
+@inline function reversebits(x::Unsigned, b::BitsPerSymbol{B}) where B
+    if B > 8 * sizeof(x)
+        throw(MethodError(reversebits, (x, b)))
+    end
     if sizeof(x) < 8
         # If smaller than UInt64, we convert to UInt64, reverse, and then
         # shift down and truncate.

test/bit-manipulation.jl

@@ -0,0 +1,35 @@
+@testset "Bit manipulation" begin
+    function test_bit_reverse(u, bps)
+        rv = BioSequences.reversebits(u, BioSequences.BitsPerSymbol{bps}())
+        ustr = string(u; base=2, pad=8 * sizeof(u))
+        rvs = join(reverse!(collect(Iterators.partition(ustr, bps))))
+        @test rv == parse(typeof(u), rvs; base=2)
+    end
+
+    # Test UInt128 with various BitsPerSymbol values (powers of two: 1, 2, 4, 8, 16, 32, 64)
+    for bps in [1, 2, 4, 8, 16, 32, 64]
+        # Edge cases
+        test_bit_reverse(UInt128(0), bps)
+        test_bit_reverse(typemax(UInt128), bps)
+
+        # Small values
+        test_bit_reverse(UInt128(1), bps)
+        test_bit_reverse(UInt128(0xff), bps)
+        test_bit_reverse(UInt128(0xffff), bps)
+
+        # # Medium values
+        test_bit_reverse(UInt128(0x123456789abcdef0), bps)
+        test_bit_reverse(UInt128(0xfedcba9876543210), bps)
+
+        # # Large values
+        test_bit_reverse(UInt128(0xb1d318f6d8b882f1ee180f1bcd8f8727), bps)
+        test_bit_reverse(UInt128(0xffffffffffffffff0000000000000000), bps)
+        test_bit_reverse(UInt128(0x0000000000000000ffffffffffffffff), bps)
+        test_bit_reverse(UInt128(0xaaaaaaaaaaaaaaaa5555555555555555), bps)
+        test_bit_reverse(UInt128(0x5555555555555555aaaaaaaaaaaaaaaa), bps)
+
+        # # Random-looking patterns
+        test_bit_reverse(UInt128(0xdeadbeefcafebabe0123456789abcdef), bps)
+        test_bit_reverse(UInt128(0x13579bdf02468ace8642fdb975310eca), bps)
+    end
+end

test/runtests.jl

@@ -15,6 +15,7 @@ using YAML
 
 # Test utils not dependent on BioSymbols
 include("utils.jl")
+include("bit-manipulation.jl")
 
 @testset "Alphabet" begin
     include("alphabet.jl")