Add spliceinto! function.

[jakobnissen]

Fixes #336

@pdimens - I'm interested in feedback. Does this cover your use case, and what do you think of the API?
The reason for the deviation from splice! is:

• It bugs me that 4:3 == 5:4, and yet passing these equal arrays into splice! causes different behaviour
• It's unnecessary and inefficient that splice! returns the removed sequence

By the way, if you need this function now and can't wait for the 3.5.0 release (which will happen once this PR is merged), or need compat with older versions of BioSequences, you can use the implmentation from this PR. It's efficient, and uses no internals.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (95d9218) to head (cde0fa8).
Report is 22 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #338      +/-   ##
==========================================
+ Coverage   90.87%   91.75%   +0.88%     
==========================================
  Files          31       29       -2     
  Lines        2400     2827     +427     
==========================================
+ Hits         2181     2594     +413     
- Misses        219      233      +14     

Flag	Coverage Δ
unittests	91.75% <100.00%> (+0.88%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jakobnissen]

Another option: Just have it be Base.insert! as you suggested, anyway. The API would then be insert!(seq, 3:5, x), where x must have the same length as 3:5, else it will throw an error.
Or, we could use insert!, but allow their lengths to differ.

[pdimens]

Thanks, I'll check this in <3hrs. I think having the insertion be a range is redundant, no? Can you see a use case of inserting a collection not at startposition:start+len?

[pdimens]

Nvm, I read the commit (currently on my phone) and see the optional deletion of destination

[pdimens]

Would it be fair to alias it as indel!, since that's what you've effectively done?

[jakobnissen]

Yeah, that's also a cool name! Maybe even better.

[pdimens]

The spliceinto!(BioSequences, range, other) works perfectly

[pdimens]

Thank you!