migrating to Automav1, TranscodingStreams, BioGenerics etc#36
Open
abhinavsns wants to merge 16 commits intoBioJulia:masterfrom
Open
migrating to Automav1, TranscodingStreams, BioGenerics etc#36abhinavsns wants to merge 16 commits intoBioJulia:masterfrom
abhinavsns wants to merge 16 commits intoBioJulia:masterfrom
Conversation
Member
|
@abhinavsns I don't maintain this repo - and have never really used it. |
Author
|
@jakobnissen Now the VCF, BCF tests are passing but the Biosequences upgrade part is left. Please try CI now |
Author
|
@jakobnissen bump! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jakobnissen, @CiaranOMara,
Based on my limited understanding of Automa, I have attempted this upgrade. Some tests are still not passing and I am looking for feedback if this is the right direction to go. Some of the ReaderHelper stuff is missing in BioGenerics and I am not sure how to proceed.
Please let me know what you think.