Fix pointer function (#27)

Author: jakobnissen

src/basic.jl

@@ -68,7 +68,7 @@ function Base.empty(::MemoryView{T1, M}, ::Type{T2}) where {T1, T2, M}
 end
 
 Base.empty(T::Type{<:MemoryView{E}}) where {E} = T(unsafe, memoryref(Memory{E}()), 0)
-Base.pointer(x::MemoryView{T}) where {T} = pointer(x.ref)
+Base.pointer(x::MemoryView{T}) where {T} = Ptr{T}(pointer(x.ref))
 Base.unsafe_convert(::Type{Ptr{T}}, v::MemoryView{T}) where {T} = pointer(v)
 Base.elsize(::Type{<:MemoryView{T}}) where {T} = Base.elsize(Memory{T})
 Base.sizeof(x::MemoryView) = Base.elsize(typeof(x)) * length(x)

test/runtests.jl

@@ -108,6 +108,18 @@ end
     @test Base.mightalias(view(v1, 2:3), MemoryView(v1))
 end
 
+@testset "Pointer" begin
+    v = [0x0102, 0x0102]
+    mem = MemoryView(v)
+    GC.@preserve v mem begin
+        @test pointer(v) === pointer(mem)
+    end
+    v = ["", ""]
+    GC.@preserve v mem begin
+        @test pointer(v) === pointer(ImmutableMemoryView(v))
+    end
+end
+
 # Span of views
 @testset "Span of views" begin
     mem = MemoryView("abc")
@@ -764,7 +776,7 @@ end
 @testset "LibDeflate" begin
     function test_view(view::MemoryView{UInt8}, mem::T, ::Type{T}) where {T}
         @test length(view) == sizeof(mem)
-        @test pointer(view) === pointer(mem)
+        @test UInt(pointer(view)) === UInt(pointer(mem))
         if T === LibDeflate.WriteableMemory
             @test view isa MutableMemoryView
         end