Make parentindices return a Tuple (#11)

Author: jakobnissen

src/basic.jl

@@ -23,17 +23,17 @@ end
 function Base.parentindices(x::MemoryView)
     elz = Base.elsize(x)
     if iszero(elz)
-        1:(x.len)
+        (1:(x.len),)
     else
         byte_offset = pointer(x.ref) - pointer(x.ref.mem)
         elem_offset = div(byte_offset % UInt, elz % UInt) % Int
-        (elem_offset + 1):(elem_offset + x.len)
+        ((elem_offset + 1):(elem_offset + x.len),)
     end
 end
 
 function Base.copy(x::MemoryView)
     isempty(x) && return x
-    newmem = @inbounds x.ref.mem[parentindices(x)]
+    newmem = @inbounds x.ref.mem[only(parentindices(x))]
     typeof(x)(unsafe, memoryref(newmem), x.len)
 end
 

test/runtests.jl

@@ -306,13 +306,13 @@ end
 
     @testset "Parentindices" begin
         mem = MemoryView(view(codeunits("lkdjfldfe"), 3:8))[2:6]
-        @test parentindices(mem) == 4:8
+        @test parentindices(mem) == (4:8,)
 
         mem = MemoryView(UInt32[2, 5, 2, 1, 6, 8])[4:end]
-        @test parentindices(mem) == 4:6
+        @test parentindices(mem) == (4:6,)
 
         mem = MemoryView(view(Vector{String}(undef, 10), 5:7))
-        @test parentindices(mem) == 5:7
+        @test parentindices(mem) == (5:7,)
     end
 
     @testset "Similar and empty" begin