Skip to content

Commit 0cc6fe3

Browse files
authored
Revert "Add gatekeeper auth (#8)" (#9)
This reverts commit ca9f11b.
1 parent 72379e7 commit 0cc6fe3

File tree

4 files changed

+6
-25
lines changed

4 files changed

+6
-25
lines changed

rstudio/templates/deployment.yaml

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,6 @@ metadata:
44
name: {{ include "rstudio.fullname" . }}
55
labels:
66
{{- include "rstudio.labels" . | nindent 4 }}
7-
annotations:
8-
authproxy.stakater.com/enabled: "true"
9-
authproxy.stakater.com/source-service-name: {{ .Release.Name }}-service
10-
authproxy.stakater.com/upstream-url: "http://localhost:8787/"
11-
authproxy.stakater.com/client-id: {{ .Values.oidc.client_id }}
12-
authproxy.stakater.com/client-secret: {{ .Values.oidc.client_secret }}
13-
authproxy.stakater.com/listen: ":80"
14-
authproxy.stakater.com/discovery-url: {{ tpl .Values.oidc.discovery_url . }}
15-
authproxy.stakater.com/oauth-uri: "{{ .Values.ingress.access_path }}oauth"
16-
authproxy.stakater.com/gatekeeper-image: keycloak/keycloak-gatekeeper:7.0.0
177
spec:
188
replicas: {{ .Values.replicaCount }}
199
selector:
@@ -60,16 +50,16 @@ spec:
6050
value: "true"
6151
ports:
6252
- name: http
63-
containerPort: 80
53+
containerPort: 8787
6454
protocol: TCP
6555
livenessProbe:
6656
httpGet:
6757
path: /
68-
port: 8787
58+
port: http
6959
readinessProbe:
7060
httpGet:
7161
path: /
72-
port: 8787
62+
port: http
7363
resources:
7464
{{- toYaml .Values.resources | nindent 12 }}
7565
volumeMounts:

rstudio/templates/ingress.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ metadata:
1313
{{- include "rstudio.labels" . | nindent 4 }}
1414
{{- with .Values.ingress.annotations }}
1515
annotations:
16-
{{- tpl (toYaml .) $ | nindent 4 }}
16+
{{- toYaml . | nindent 4 }}
1717
{{- end }}
1818
spec:
1919
{{- if .Values.ingress.tls }}
@@ -34,7 +34,7 @@ spec:
3434
{{- range .paths }}
3535
- path: {{ . }}
3636
backend:
37-
serviceName: {{ $fullName }}-service
37+
serviceName: {{ $fullName }}
3838
servicePort: {{ $svcPort }}
3939
{{- end }}
4040
{{- end }}

rstudio/templates/service.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: v1
22
kind: Service
33
metadata:
4-
name: {{ include "rstudio.fullname" . }}-service
4+
name: {{ include "rstudio.fullname" . }}
55
labels:
66
{{- include "rstudio.labels" . | nindent 4 }}
77
spec:

rstudio/values.yaml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,9 @@ service:
3838
port: 80
3939

4040
ingress:
41-
access_path: /rstudio/
4241
enabled: true
4342
annotations:
4443
nginx.ingress.kubernetes.io/rewrite-target: /$2
45-
nginx.ingress.kubernetes.io/configuration-snippet: |
46-
# This extra rewrite restores the original url because keycloak gatekeeper expects the non-rewritten path
47-
rewrite "{{ .Values.ingress.access_path }}oauth(/|$)(.*)" {{ .Values.ingress.access_path }}oauth/$2 break;
4844
# kubernetes.io/ingress.class: nginx
4945
# kubernetes.io/tls-acme: "true"
5046
hosts:
@@ -74,11 +70,6 @@ tolerations: []
7470

7571
affinity: {}
7672

77-
oidc:
78-
client_id: "rstudio"
79-
client_secret: "some_secret"
80-
discovery_url: "http://cloudman-keycloak-http.cloudman.svc.cluster.local/auth/realms/master"
81-
8273
persistence:
8374
enabled: true
8475
name: rstudio-pvc

0 commit comments

Comments
 (0)