Skip to content

Commit 10de37b

Browse files
authored
add bug fixes due to API changes section, closes #130 (#132)
1 parent 83550d0 commit 10de37b

File tree

1 file changed

+34
-8
lines changed

1 file changed

+34
-8
lines changed

git-version-control.Rmd

Lines changed: 34 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -510,16 +510,16 @@ repository for the package.
510510
1. The package with the changes should be available in your local _R_
511511
installation.
512512
513-
## Scenarios for code update:
514-
515-
- [Pull upstream changes][], e.g., introduced by the core team.
516-
- [Push to GitHub and _Bioconductor_][] repositories.
517-
- [Resolve merge conflicts][mergeconflict].
518-
- [Abandon changes][].
519-
- [Fix bugs in devel and release][].
513+
## Scenarios for code update
514+
515+
- [Pull upstream changes][] (e.g., introduced by the core team)
516+
- [Push to GitHub and _Bioconductor_][] repositories
517+
- [Resolve merge conflicts][mergeconflict]
518+
- [Abandon changes][]
519+
- [Fix bugs in devel and release][]
520+
- [Bug fixes due to API changes][]
520521
- [Resolve duplicate commits][]
521522
522-
523523
### Pull upstream changes
524524
525525
__Goal:__ Your _Bioconductor_ repository has been updated by the core
@@ -894,6 +894,32 @@ git branch and in the current release branch (e.g., `RELEASE_3_14`).
894894
895895
<iframe width="568" height="315" src="https://www.loom.com/embed/37525f9ddf434c91b11e8112db46818b" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>
896896
897+
### Bug fixes due to API changes {#bug-fixes-due-to-api-changes}
898+
899+
Packages that make use of web APIs will need to be updated when there are
900+
significant API changes. This is a common occurrence with Bioconductor packages
901+
that use REST APIs, e.g., `UniProt.ws`, `AnVIL`, etc. To provide a smooth
902+
experience for users, it is important to update the package as soon as possible.
903+
904+
#### Minor API changes
905+
906+
The steps to apply bug fixes due to API changes are similar to the steps for
907+
fixing bugs in the `devel` and `release` branches. The main difference is that
908+
the bug may be due to minor API issues, certificate issues, API version issues,
909+
etc. The maintainer can readily update the R package to adapt to the new API.
910+
Note that the functionality of the package largely remains the same.
911+
912+
#### Major API changes
913+
914+
It may be possible that an organization's API changes are not backwards
915+
compatible and that they do not provide the same functionality for the existing
916+
Bioconductor package to remain functional. In such case, it is recommended to
917+
contact the organization that maintains the API to get more information about
918+
the changes and to request a backward compatible API, if possible. When API
919+
changes do not provide a similar functionality to that of the R package, the
920+
package maintainer may need to submit a new package that works with the new API
921+
and to deprecate the old package.
922+
897923
### Resolve Duplicate Commits
898924
899925
__Goal:__ You want to get rid of the duplicate (or triplicate) commits

0 commit comments

Comments
 (0)