Skip to content

Commit 41a633d

Browse files
authored
Merge branch 'devel' into quarto_documentation
2 parents e1dd71b + 5307a58 commit 41a633d

16 files changed

+85
-90
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Bioconductor Packages: Guidelines for Developers and Reviewers
1313

1414
This book contains our guidelines for packages contributed to the [_Bioconductor_](https://bioconductor.org/) suite of packages.
1515
These guidelines are always a work in progress - corrections, suggestions and general improvements are welcome as [issue submissions in this repository](https://github.com/Bioconductor/pkgrevdocs/issues/new).
16-
Open discussions are welcome in our [Slack](https://bioc-community.herokuapp.com/).
16+
Open discussions are welcome in our [Zulip](https://community-bioc.zulipchat.com/).
1717
You can also suggest changes by editing the `.Rmd` files that are at the root of this repository and submitting a [pull request](https://github.com/Bioconductor/pkgrevdocs/pulls).
1818
An "Edit this page" link in the side bar on the right of each book chapter will take you directly to the relevant page on the GitHub repository to make such changes.
1919
Please target your pull requests to the `devel` branch.

_bookdown.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,6 @@ rmd_files: ["index.Rmd",
4444
"c-and-fortran.Rmd",
4545
"mavericks.Rmd",
4646
"debug-rd-links.Rmd",
47-
"news-for-bookdown.Rmd"]
47+
"news-for-bookdown.Rmd",
48+
"references.Rmd"]
4849
clean: [packages.bib]

debug-rd-links.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ W checking Rd cross-references (<...>ms)
2727
## What worked
2828

2929
First, the `SummarizedExperiment` package was added to the `Depends:` section
30-
of the DESCRIPTION file.
30+
of the `DESCRIPTION` file.
3131

3232
```
3333
Depends:

description-file.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ package type (i.e., `Software`, `AnnotationData`, `ExperimentData`, or
192192
`Workflow`). `biocViews` terms are case-sensitive.
193193

194194
The field name "biocViews" is case-sensitive and must begin with a lower-case
195-
'b'. Please use a single line with biocViews seperated by commas
195+
'b'. Please use a single line with `biocViews` separated by commas
196196

197197
(i.e,`biocViews: GeneTarget, SingleCell`).
198198

general-package-development.Rmd

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,12 @@ Do not use filenames that differ only in case, as not all file systems are case-
4242

4343
### Package size {#package-size}
4444

45-
The source package resulting from running `R CMD build` should occupy less than 5 MB on disk.
46-
If your package includes (e.g. in the vignettes) some screenshots, this limit can be reached quite quickly. Their size can be reduced (often as much as 70%) in a lossy but quality-preserving manner by using tools such as [pngquant](https://pngquant.org/) (available as a command line utility and as a GUI on most systems).
45+
The source package resulting from running `R CMD build` should occupy less than
46+
5 MB on disk. If your package includes some screenshots (e.g., in the
47+
vignettes), this limit can be reached quite quickly. Their size can be reduced
48+
(often as much as 70%) with lossy compression using tools such as
49+
[pngquant](https://pngquant.org/) (available as a command line utility and as a
50+
GUI on most systems).
4751

4852
### Check duration {#check-duration}
4953

git-version-control.Rmd

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -79,19 +79,20 @@ Builds occur once per day, and take approximately 24 hours. See the
7979

8080
Traditional Annotation packages are not stored in GIT due to the size of
8181
annotation files. To update an existing Annotation package please send an email
82-
to [email protected]. A member of the Bioconductor team will be in
82+
to <[email protected]>. A member of the Bioconductor team will be in
8383
contact to receive the updated package.
8484

8585
Newer annotation packages can be stored in GIT as it is a requirement to use the
8686
`r BiocStyle::Biocpkg("AnnotationHub")` server hosted data. The larger sized
8787
files are not included directly in the package. To contribute a new Annotation
88-
package please contact [email protected] for guidance and read the
88+
package please contact <[email protected]> for guidance and read the
8989
documentation on [Create A Hub Package][].
9090

9191
Currently direct updates to annotation packages, even those stored on git, are
9292
not supported. If you wish to updated an annotation package, make required
9393
changes and push to git.bioconductor.org. Then send an email to
94-
[email protected] or [email protected] requesting the package be propagated.
94+
<[email protected]> or <[email protected]> requesting the package
95+
be propagated.
9596

9697
## Subversion to Git Transition
9798

@@ -704,7 +705,7 @@ _Bioconductor_ repositories.
704705
705706
__Goal:__ You want to start fresh after failing to resolve conflicts
706707
or some other issue. If you intend to go nuclear, please contact the
707-
[email protected] mailing list.
708+
<[email protected]> mailing list.
708709
709710
#### Force _Bioconductor_ `devel` to GitHub `devel`
710711
@@ -1058,9 +1059,9 @@ maintain the package and avoid deprecation and removal.
10581059
package be updated. Include the package name and the contact information for
10591060
the new maintainer.
10601061
1061-
3. Update Package DESCRIPTION file
1062+
3. Update Package `DESCRIPTION` file
10621063
1063-
The DESCRIPTION file of the package should be updated to the new maintainer
1064+
The `DESCRIPTION` file of the package should be updated to the new maintainer
10641065
information and pushed to the Bioconductor git.bioconductor.org repository.
10651066
10661067
### Remove Large Data Files and Clean Git Tree
@@ -1435,7 +1436,7 @@ repository.
14351436
#### More questions?
14361437
14371438
If you have additional questions which are not answered here already,
1438-
please send an email to [email protected].
1439+
please send an email to <[email protected]>.
14391440
14401441
### Helpful resources:
14411442

important-bioc-features.Rmd

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
## biocViews {#biocviews}
44

55
Packages added to the _Bioconductor_ Project require a `biocViews:`
6-
field in their DESCRIPTION file. The field name "biocViews" is
6+
field in their `DESCRIPTION` file. The field name "biocViews" is
77
case-sensitive and must begin with a lower-case 'b'.
88

9-
biocViews terms are "keywords" used to describe a given package. They
9+
`biocViews` terms are "keywords" used to describe a given package. They
1010
are broadly divided into four categories, representing the type of
1111
packages present in the _Bioconductor_ Project
1212

@@ -15,29 +15,29 @@ packages present in the _Bioconductor_ Project
1515
3. Experiment Data
1616
4. Workflow
1717

18-
biocViews are available for the [release][release-biocviews] and [devel][biocViews] branches of
19-
_Bioconductor_. The devel branch has a check box under the tree
20-
structure which, when checked, displays biocViews that are defined but
21-
not used by any package, in addition to biocViews that are in use. See also
22-
[description section](#description-biocviews)
18+
`biocViews` are available for the [release][release-biocviews] and
19+
[devel][biocViews] branches of _Bioconductor_. The devel branch has a check box
20+
under the tree structure which, when checked, displays `biocViews` that are
21+
defined but not used by any package, in addition to `biocViews` that are in use.
22+
See also [description section](#description-biocviews)
2323

2424
### Motivation {#biocviews-motivation}
2525

26-
One can use biocViews for two broad purposes.
26+
One can use `biocViews` for two broad purposes.
2727

2828
1. A researcher might want to identify all packages in the
2929
_Bioconductor_ Project which are related to a specific purpose.
3030
For example, one may want to look for all packages related to "Copy
3131
Number Variants".
3232

3333
2. During development, a package contributor can "tag" their package
34-
with biocViews so that when someone looking for packages (like in
34+
with `biocViews` so that when someone looking for packages (like in
3535
scenario 1) can easily find their package.
3636

3737
### biocViews during new package development {#biocviews-pkg-devel}
3838

3939
Visit the ['devel' biocViews][biocViews] when you are in the process of
40-
adding biocViews to your new package. Identify as many terms as
40+
adding `biocViews` to your new package. Identify as many terms as
4141
appropriate from the hierarchy. Prefer 'leaf' terms at the end of the
4242
hierarchy, over more inclusive terms. Remember to check the box
4343
displaying all available terms.
@@ -46,30 +46,30 @@ Please Note:
4646

4747
1. Your package will belong to only one part of _Bioconductor_ Project
4848
(Software, Annotation Data, Experiment Data, Workflow), so choose only
49-
biocViews from that category.
49+
`biocViews` from that category.
5050

51-
2. biocViews listed in your package must match exactly (e.g.,
52-
spelling, capitalization) the terms in the biocViews hierarchy.
51+
2. `biocViews` listed in your package must match exactly (e.g.,
52+
spelling, capitalization) the terms in the `biocViews` hierarchy.
5353

5454
When you submit your new package for review , your package is checked
5555
and built by the _Bioconductor_ Project. We check the following for
5656
biocViews:
5757

58-
1. Package contributor has added biocViews.
58+
1. Package contributor has added `biocViews`.
5959

60-
2. biocViews are valid.
60+
2. `biocViews` are valid.
6161

62-
3. Package contributor has added biocViews from only one of the categories.
62+
3. Package contributor has added `biocViews` from only one of the categories.
6363

64-
If you receive a "RECOMMENDED" direction for any of these biocViews
64+
If you receive a "RECOMMENDED" direction for any of these `biocViews`
6565
after you have submitted your package, you can try correcting them on
6666
your own following the directions given here or ask your package
6767
reviewer for more information.
6868

69-
If a developer thinks a biocViews term should be added to the current acceptable
70-
list, please email [email protected] requesting the new biocView, under
71-
which hierarchy the term should be placed, and the justification for the new
72-
term.
69+
If a developer thinks a `biocViews` term should be added to the current
70+
acceptable list, please email <[email protected]> requesting the new
71+
`biocViews` term, under which hierarchy the term should be placed, and the
72+
justification for the new term.
7373

7474

7575
## Common Bioconductor Methods and Classes {#reusebioc}

index.Rmd

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ author:
55
- Daniela Cassol
66
- Johannes Rainer
77
- Lori Shepherd
8+
- Marcel Ramos Pérez
9+
- Martin Morgan
810
date: "`r Sys.Date()`"
911
site: bookdown::bookdown_site
1012
documentclass: book
@@ -17,7 +19,7 @@ description: "This is a minimal example of using the bookdown package to write a
1719
# Welcome {-}
1820

1921
```{r, fig.align='center', echo=FALSE, out.height="200px"}
20-
knitr::include_graphics("https://raw.githubusercontent.com/Bioconductor/BiocStickers/master/Bioconductor/Bioconductor.png")
22+
knitr::include_graphics("https://raw.githubusercontent.com/Bioconductor/BiocStickers/devel/Bioconductor/Bioconductor.png")
2123
```
2224

2325
## Introduction {.unnumbered #intro}
@@ -132,7 +134,7 @@ knitr::write_bib(c(
132134
[Removing collaborator]: https://help.github.com/articles/removing-a-collaborator-from-a-personal-repository/
133135
[Resolving a merge conflict using command line]: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/
134136
[reviewer-list]: https://bioconductor.org/about/package-reviewers/
135-
[reviewers slack channel]: https://community-bioc.slack.com/archives/C02A1B8HUHZ
137+
[reviewers zulip channel]: https://community-bioc.zulipchat.com/#narrow/channel/507978-reviewers
136138
[rmarkdown]: http://rmarkdown.rstudio.com/
137139
[rmarkdown documentation]: http://rmarkdown.rstudio.com/authoring_pandoc_markdown.html#citations
138140
[shiny-posit]: https://shiny.posit.co/

install-file.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ already there.
1111

1212
Specifying this requirement does not guarantee that _Bioconductor_ will agree to
1313
install the external system requirement. It is encouraged to discuss any
14-
additional system requirements on the [email protected] before
14+
additional system requirements on the <[email protected]> before
1515
development.
1616

1717
System requirements should never be exclusive to a particular

non-software-packages.Rmd

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,11 @@ expected the majority of vignette code chunks are evaluated.
6464
ideally workflows make use of existing data in a Bioconductor repository or on
6565
the web; the workflow package itself should not contain large data files.
6666

67-
* In the DESCRIPTION file, include the line "BiocType: Workflow". Please also
68-
include a detailed Description field in the DESCRIPTION file. The DESCRIPTION
69-
file should contain biocViews which should be from the [Workflow
70-
branch][workflow-views]. If you think a new term is relevant please reach out to
71-
67+
* In the `DESCRIPTION` file, include the line "BiocType: Workflow". Please also
68+
include a detailed Description field in the `DESCRIPTION` file. The
69+
`DESCRIPTION` file should contain `biocViews` which should be from the [Workflow
70+
branch][workflow-views]. If you think a new term is relevant please reach out
71+
7272

7373
* Submit the package to the [GitHub submission tracker][tracker] for a formal
7474
review. Please also indicate in the tracker issue that this package is a

0 commit comments

Comments
 (0)