Skip to content

Commit 5ad4454

Browse files
committed
Remove redundant property from IDialogViewModel (non breaking)
1 parent 5f3ae7c commit 5ad4454

File tree

6 files changed

+4
-38
lines changed

6 files changed

+4
-38
lines changed

BionicCode.Net/BionicCode.Utilities.Net.Core.Wpf/BionicCode.Utilities.Net.Core.Wpf.csproj

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,21 @@
55
<UseWPF>true</UseWPF>
66
<ApplicationIcon>logo.ico</ApplicationIcon>
77
<Authors>Brian Sampoh</Authors>
8-
<Description>Reusable utility and class library for WPF .NET Core &gt;= 3.0 - Featuring: AsyncRelayCommand&amp;lt;T&amp;gt;, ObservablePropertyChangedCollection, ViewModel, Visual Tree Helpers, Profiling, Extension Methods, ValueChangedEventArgs, MruManager (Most Recently Used files), AppSettingsConnector, InverExtension MarkupExtension, EnumExtension MarkupExtension, EventAggregator, MVVM DialogService and more.</Description>
8+
<Description>Reusable utility and class library for WPF .NET Core &gt;= 3.0 - Featuring: AsyncRelayCommand&amp;lt;T&amp;gt;, ObservablePropertyChangedCollection, ViewModel, Visual Tree Helpers, Profiling, Extension Methods, ValueChangedEventArgs, MruManager (Most Recently Used files), AppSettingsConnector, InverExtension MarkupExtension, EnumExtension MarkupExtension, EventAggregator, MVVM DialogService, Attached Behaviors and more.</Description>
99
<PackageLicenseExpression>MIT</PackageLicenseExpression>
1010
<PackageProjectUrl>https://github.com/BionicCode/BionicCode.Net</PackageProjectUrl>
1111
<PackageIcon>BionicCode_Logo.png</PackageIcon>
12-
<PackageTags>Base View Model ViewModel BaseViewModel AsyncRelayCommand Async RelayCommand WPF VisualTreeHelper Profiler Profiling Measure Measuring View Model ViewModel ExtensionMethods ObservablePropertyChangedCollection Collection ApplicationSettings Settings AppSettings MRU MostRecentlyUsedFile LastUsedFile RecentlyUsedFile EventAggregator Aggregator Event MVVMDialog MVVM Dialog DialogService ExtensioMethod EnumExtension InvertExtension MarkupExtension EventAggregator Aggregator Event MVVM NullObject NullObjectFactory Factory IFatory ValueChangedEventArgs AutoResetStream Stream PropertyValueChangedArgs FileExtension FileExtensions PropertyValueChanged</PackageTags>
12+
<PackageTags>Base View Model ViewModel BaseViewModel AsyncRelayCommand Async RelayCommand WPF VisualTreeHelper Profiler Profiling Measure Measuring View Model ViewModel ExtensionMethods ObservablePropertyChangedCollection Collection ApplicationSettings Settings AppSettings MRU MostRecentlyUsedFile LastUsedFile RecentlyUsedFile EventAggregator Aggregator Event MVVMDialog MVVM Dialog DialogService ExtensioMethod EnumExtension InvertExtension MarkupExtension EventAggregator Aggregator Event MVVM NullObject NullObjectFactory Factory IFatory ValueChangedEventArgs AutoResetStream Stream PropertyValueChangedArgs FileExtension FileExtensions PropertyValueChanged RichTextBox AttachedBehavior Attached Behavior</PackageTags>
1313
<GeneratePackageOnBuild>false</GeneratePackageOnBuild>
1414
<Company>BionicCode</Company>
1515
<Copyright>2020</Copyright>
1616
<RepositoryUrl>https://github.com/BionicCode/BionicCode.Net.git</RepositoryUrl>
1717
<RepositoryType>git</RepositoryType>
18-
<PackageReleaseNotes>
18+
<PackageReleaseNotes>d TextControl to highlight custom text ranges. Added missing documentation. Added feature to control modality of MVVM dialog behavior and control property whether user can close the dialog window or not.
1919

2020
---------------------------------------------------------
2121
For bug reports or feature requests please visit the project home on GutHub (follow the "Project Site" link on the right) and then open an issue (open the "issue" tab, click "New Issue" and select the appropriate template) or send a mail to [email protected]. Thank you very much.</PackageReleaseNotes>
22-
<Version>1.0.2</Version>
22+
<Version>1.0.3</Version>
2323
</PropertyGroup>
2424

2525
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">

BionicCode.Net/BionicCode.Utilities.Net.Core.Wpf/BionicCode.Utilities.Net.Core.Wpf.xml

Lines changed: 0 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

BionicCode.Net/BionicCode.Utilities.Net.Core.Wpf/Dialog/DialogViewModel.cs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,6 @@ protected virtual async Task ExecuteSendResponseCommandAsync(DialogResult result
7070
/// <inheritdoc />
7171
public string Title { get => this.title; set => TrySetValue(value, ref this.title); }
7272

73-
private bool isClosable;
74-
75-
/// <inheritdoc />
76-
public bool IsClosable
77-
{
78-
get => this.isClosable;
79-
set => TrySetValue(value, ref this.isClosable);
80-
}
81-
8273
private string message;
8374
/// <inheritdoc />
8475
public string Message { get => this.message; set => TrySetValue(value, ref this.message); }

BionicCode.Net/BionicCode.Utilities.Net.Core.Wpf/Dialog/IDialogViewModel.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ public interface IDialogViewModel : IViewModel
2727
/// </summary>
2828
string Message { get; set; }
2929
/// <summary>
30-
/// Controls whether the user is allowed to close the dialog Window.
31-
/// </summary>
32-
bool IsClosable { get; set; }
33-
/// <summary>
3430
/// The <see cref="Wpf.Dialog.DialogResult"/> of the user interaction.
3531
/// </summary>
3632
DialogResult DialogResult { get; set; }

BionicCode.Net/BionicCode.Utilities.Net.Framework.Wpf/Dialog/DialogViewModel.cs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,15 +70,6 @@ protected virtual async Task ExecuteSendResponseCommandAsync(DialogResult result
7070
/// <inheritdoc />
7171
public string Title { get => this.title; set => TrySetValue(value, ref this.title); }
7272

73-
private bool isClosable;
74-
75-
/// <inheritdoc />
76-
public bool IsClosable
77-
{
78-
get => this.isClosable;
79-
set => TrySetValue(value, ref this.isClosable);
80-
}
81-
8273
private string message;
8374
/// <inheritdoc />
8475
public string Message { get => this.message; set => TrySetValue(value, ref this.message); }

BionicCode.Net/BionicCode.Utilities.Net.Framework.Wpf/Dialog/IDialogViewModel.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,6 @@ public interface IDialogViewModel : IViewModel
2727
/// </summary>
2828
string Message { get; set; }
2929
/// <summary>
30-
/// Controls whether the user is allowed to close the dialog Window.
31-
/// </summary>
32-
bool IsClosable { get; set; }
33-
/// <summary>
3430
/// The <see cref="DialogResult"/> of the user interaction.
3531
/// </summary>
3632
DialogResult DialogResult { get; set; }

0 commit comments

Comments
 (0)