refactor: code improvement

csemazharul · csemazharul · commit 4c55ae338dca · 2025-01-05T12:01:59.000+06:00
diff --git a/src/QueryBuilder.php b/src/QueryBuilder.php
@@ -464,7 +464,7 @@ public function orWhereBetween($column, $start, $end)
      */
     public function paginate($pageNo = 0, $perPage = 10)
     {
-        $selectedColumns = !empty($this->select) ? $this->select : ['*'];
+        $selectedColumns = empty($this->select) ? ['*'] : $this->select;
 
         $totalItems = (int) $this->count(); 
 

Original file line number	Diff line number	Diff line change
`@@ -464,7 +464,7 @@ public function orWhereBetween($column, $start, $end)`
`464`	`464`	`*/`
`465`	`465`	`public function paginate($pageNo = 0, $perPage = 10)`
`466`	`466`	`{`
`467`		`- $selectedColumns = !empty($this->select) ? $this->select : ['*'];`
	`467`	`+ $selectedColumns = empty($this->select) ? ['*'] : $this->select;`
`468`	`468`
`469`	`469`	`$totalItems = (int) $this->count();`
`470`	`470`