Skip to content

Commit ff25ac3

Browse files
authored
Run ODBC tests in workflow
Run test executables once without re-runs and without using test script. This way the segmentation fault is not caught.
1 parent 9d4e6ee commit ff25ac3

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

.github/workflows/cpp_extra.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -501,10 +501,17 @@ jobs:
501501
shell: cmd
502502
run: |
503503
call "cpp\src\arrow\flight\sql\odbc\tests\install_odbc.cmd" ${{ github.workspace }}\build\cpp\%ARROW_BUILD_TYPE%\arrow_flight_sql_odbc.dll
504-
# GH-48270 TODO: Resolve segementation fault during Arrow library unload
505-
# GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI
504+
# GH-48270 TODO: Resolve segementation fault during Arrow library unload, segementation fault is caught with `ci/scripts/cpp_test.sh`
505+
# GH-48269 TODO: Enable Flight & Flight SQL testing in MSVC CI and run tests with `ci/scripts/cpp_test.sh` instead
506506
# GH-48547 TODO: enable ODBC tests after GH-48270 and GH-48269 are resolved.
507-
507+
- name: Run ODBC Unit Tests
508+
shell: cmd
509+
run: |
510+
build\cpp\%ARROW_BUILD_TYPE%\arrow-odbc-spi-impl-test.exe
511+
- name: Run ODBC Driver Tests
512+
shell: cmd
513+
run: |
514+
build\cpp\%ARROW_BUILD_TYPE%\arrow-flight-sql-odbc-test.exe
508515
- name: Install WiX Toolset
509516
shell: pwsh
510517
run: |

0 commit comments

Comments
 (0)