Skip to content

BlockFixtureFactory should not use ChannelContext #418

@Prometee

Description

@Prometee

Fixture are usually used during a command and is considered stateless.
ChannelContext is supposed to be stateful : Sylius/Sylius#9987 (comment)

A Block has a product_codes and a channels nodes, if a product need to be found within a channel, then iterate through channels values to retrieve Products is a solution to avoid using the ChannelContext. If no channels is given then retrieve the Products without the Channel filter.

What do you think about that ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions