chore: remove pointer receiver from AccountsConfig.

In order to have a single type of receiver for the struct, we need to
either have every method with a pointer receiver, or a value one. A
value one is not possible since GetOrAddKeystore needs to modify the
config.
A pointer one is also troublesome because AccountsConfig() returns a
value, so calls like b.AccountsConfig().Derive() or similar wouldn't be
possible.
At the same time AccountsConfig() can't be changed to return a pointer
because it needs to lock the accountsConfigLock and returning a pointer
would cause data races.

Author: bznein

backend/backend.go

@@ -799,7 +799,7 @@ func (backend *Backend) registerKeystore(keystore keystore.Keystore) {
 		if err != nil {
 			return errp.WithMessage(err, "could not retrieve keystore name")
 		}
-		keystoreCfg := accountsConfig.GetOrAddKeystore(fingerprint)
+		keystoreCfg := config.GetOrAddKeystore(accountsConfig, fingerprint)
 		keystoreCfg.Name = keystoreName
 		keystoreCfg.LastConnected = time.Now()
 		return nil

backend/config/accounts.go

@@ -168,7 +168,7 @@ func (cfg AccountsConfig) IsAccountWatchonly(account *Account) (bool, error) {
 
 // GetOrAddKeystore looks up the keystore by root fingerprint. If it does not exist, one is added to
 // the list of keystores and the newly created one is returned.
-func (cfg *AccountsConfig) GetOrAddKeystore(rootFingerprint []byte) *Keystore {
+func GetOrAddKeystore(cfg *AccountsConfig, rootFingerprint []byte) *Keystore {
 	ks, err := cfg.LookupKeystore(rootFingerprint)
 	if err == nil {
 		return ks

backend/config/accounts_test.go

@@ -98,19 +98,19 @@ func TestGetOrAddKeystore(t *testing.T) {
 	fp1 := []byte("aaaa")
 	fp2 := []byte("bbbb")
 
-	ks := cfg.GetOrAddKeystore(fp1)
+	ks := GetOrAddKeystore(cfg, fp1)
 	ks.Name = "ks1"
 
 	require.Len(t, cfg.Keystores, 1)
 	require.Equal(t, ks, cfg.Keystores[0])
 	require.Equal(t, fp1, []byte(cfg.Keystores[0].RootFingerprint))
 	require.Equal(t, "ks1", cfg.Keystores[0].Name)
 
-	ks = cfg.GetOrAddKeystore(fp1)
+	ks = GetOrAddKeystore(cfg, fp1)
 	require.Len(t, cfg.Keystores, 1)
 	require.Equal(t, "ks1", ks.Name)
 
-	ks = cfg.GetOrAddKeystore(fp2)
+	ks = GetOrAddKeystore(cfg, fp2)
 	ks.Name = "ks2"
 
 	require.Len(t, cfg.Keystores, 2)