bitcoin: get payment request by paymentreq index, not output index

benma · benma · commit 02f397ce287c · 2024-05-31T12:34:31.000+02:00
More direct query to the host - otherwise the host has to lookup the
payment request index from the output manually, adding a needless indirection.
diff --git a/src/rust/bitbox02-rust/src/hww/api/bitcoin/signtx.rs b/src/rust/bitbox02-rust/src/hww/api/bitcoin/signtx.rs
@@ -792,7 +792,7 @@ async fn _process(request: &pb::BtcSignInitRequest) -> Result<Response, Error> {
                     return Err(Error::InvalidInput);
                 }
                 let payment_request: pb::BtcPaymentRequestRequest =
-                    get_payment_request(output_index, &mut next_response).await?;
+                    get_payment_request(output_payment_request_index, &mut next_response).await?;
                 payment_request::user_verify(coin_params, &payment_request, format_unit).await?;
                 if payment_request::validate(
                     coin_params,

Original file line number	Diff line number	Diff line change
`@@ -792,7 +792,7 @@ async fn _process(request: &pb::BtcSignInitRequest) -> Result<Response, Error> {`
`792`	`792`	`return Err(Error::InvalidInput);`
`793`	`793`	`}`
`794`	`794`	`let payment_request: pb::BtcPaymentRequestRequest =`
`795`		`- get_payment_request(output_index, &mut next_response).await?;`
	`795`	`+ get_payment_request(output_payment_request_index, &mut next_response).await?;`
`796`	`796`	`payment_request::user_verify(coin_params, &payment_request, format_unit).await?;`
`797`	`797`	`if payment_request::validate(`
`798`	`798`	`coin_params,`