ui: Remove noop

NickeZ · NickeZ · commit 0a9be883873b · 2025-10-06T09:34:59.000+02:00
`.on_event` is allowed to be NULL
diff --git a/src/ui/components/empty.c b/src/ui/components/empty.c
@@ -21,7 +21,7 @@
 static const component_functions_t _component_functions = {
     .cleanup = ui_util_component_cleanup,
     .render = ui_util_component_render_subcomponents,
-    .on_event = ui_util_on_event_noop,
+    .on_event = NULL,
 };
 
 /********************************** Create Instance **********************************/
diff --git a/src/ui/components/image.c b/src/ui/components/image.c
@@ -48,7 +48,7 @@ static void _render(component_t* component)
 static const component_functions_t _component_functions = {
     .cleanup = ui_util_component_cleanup,
     .render = _render,
-    .on_event = ui_util_on_event_noop,
+    .on_event = NULL,
 };
 
 /********************************** Create Instance **********************************/
diff --git a/src/ui/components/info_centered.c b/src/ui/components/info_centered.c
@@ -30,7 +30,7 @@
 static const component_functions_t _component_functions = {
     .cleanup = ui_util_component_cleanup,
     .render = ui_util_component_render_subcomponents,
-    .on_event = ui_util_on_event_noop,
+    .on_event = NULL,
 };
 
 /********************************** Create Instance **********************************/
diff --git a/src/ui/components/knight_rider.c b/src/ui/components/knight_rider.c
@@ -50,7 +50,7 @@ static void _render(component_t* component)
 static component_functions_t _component_functions = {
     .cleanup = ui_util_component_cleanup,
     .render = _render,
-    .on_event = ui_util_on_event_noop,
+    .on_event = NULL,
 };
 
 /********************************** Create Instance **********************************/
diff --git a/src/ui/components/lockscreen.c b/src/ui/components/lockscreen.c
@@ -31,7 +31,7 @@
 static const component_functions_t _component_functions = {
     .cleanup = ui_util_component_cleanup,
     .render = ui_util_component_render_subcomponents,
-    .on_event = ui_util_on_event_noop,
+    .on_event = NULL,
 };
 
 /********************************** Create Instance **********************************/
diff --git a/src/ui/components/orientation_arrows.c b/src/ui/components/orientation_arrows.c
@@ -142,7 +142,7 @@ static void _render(component_t* component)
 static component_functions_t _component_functions = {
     .cleanup = ui_util_component_cleanup,
     .render = _render,
-    .on_event = ui_util_on_event_noop,
+    .on_event = NULL,
 };
 
 /********************************** Create Instance **********************************/
diff --git a/src/ui/components/progress.c b/src/ui/components/progress.c
@@ -38,7 +38,7 @@ static void _render(component_t* component)
 static const component_functions_t _component_functions = {
     .cleanup = ui_util_component_cleanup,
     .render = _render,
-    .on_event = ui_util_on_event_noop,
+    .on_event = NULL,
 };
 
 component_t* progress_create(const char* title)
diff --git a/src/ui/components/screensaver.c b/src/ui/components/screensaver.c
@@ -71,7 +71,7 @@ static void _render(component_t* component)
 static component_functions_t _component_functions = {
     .cleanup = ui_util_component_cleanup,
     .render = _render,
-    .on_event = ui_util_on_event_noop,
+    .on_event = NULL,
 };
 
 component_t* screensaver_create(void)
diff --git a/src/ui/components/sdcard.c b/src/ui/components/sdcard.c
@@ -59,7 +59,7 @@ static void _render(component_t* component)
 static const component_functions_t _component_functions = {
     .cleanup = ui_util_component_cleanup,
     .render = _render,
-    .on_event = ui_util_on_event_noop,
+    .on_event = NULL,
 };
 
 /********************************** Create Instance **********************************/
diff --git a/src/ui/components/status.c b/src/ui/components/status.c
@@ -55,7 +55,7 @@ static void _render(component_t* component)
 static const component_functions_t _component_functions = {
     .cleanup = ui_util_component_cleanup,
     .render = _render,
-    .on_event = ui_util_on_event_noop,
+    .on_event = NULL,
 };
 
 /********************************** Create Instance **********************************/
diff --git a/src/ui/components/trinary_choice.c b/src/ui/components/trinary_choice.c
@@ -33,7 +33,7 @@ typedef struct {
 static const component_functions_t _component_functions = {
     .cleanup = ui_util_component_cleanup,
     .render = ui_util_component_render_subcomponents,
-    .on_event = ui_util_on_event_noop,
+    .on_event = NULL,
 };
 
 static void _left_selected(component_t* button)
diff --git a/src/ui/components/waiting.c b/src/ui/components/waiting.c
@@ -37,7 +37,7 @@ static void _render(component_t* component)
 static component_functions_t _component_functions = {
     .cleanup = ui_util_component_cleanup,
     .render = _render,
-    .on_event = ui_util_on_event_noop,
+    .on_event = NULL,
 };
 
 /********************************** Create Instance **********************************/
diff --git a/src/ui/ui_util.c b/src/ui/ui_util.c
@@ -63,18 +63,6 @@ void ui_util_component_cleanup(component_t* component)
     free(component);
 }
 
-/**
- * A no-op function for components that do not handle events.
- * @param[in] event The emitted event.
- * @param[in] component The component that receives the event.
- */
-void ui_util_on_event_noop(const event_t* event, component_t* component)
-{
-    // noop
-    (void)event;
-    (void)component;
-}
-
 /**
  * Positions the child component in the center (vertical and horizontal) of the
  * parent component.
diff --git a/src/ui/ui_util.h b/src/ui/ui_util.h
@@ -53,13 +53,6 @@ void ui_util_component_render_subcomponents(component_t* component);
  */
 void ui_util_component_cleanup(component_t* component);
 
-/**
- * A no-op function for components that do not handle events.
- * @param[in] event The emitted event.
- * @param[in] component The component that receives the event.
- */
-void ui_util_on_event_noop(const event_t* event, component_t* component);
-
 /**
  * Positions the child component in the center (vertical and horizontal) of the
  * parent component.
diff --git a/test/hardware-fakes/src/fake_component.c b/test/hardware-fakes/src/fake_component.c
@@ -28,7 +28,7 @@
 static const component_functions_t FAKE_COMPONENT_FUNCTIONS = {
     .cleanup = ui_util_component_cleanup,
     .render = ui_util_component_render_subcomponents,
-    .on_event = ui_util_on_event_noop};
+    .on_event = NULL};
 
 /********************************** Create Instance **********************************/
 
