Skip to content

Commit 35c6d81

Browse files
committed
pr-ci: Check out submodules, needed if any of them changed
When CI is run per commit, we first checkout the base branch and then we merge in the "commit under review". Checking out the submodules from the base is not going to be the correct ones. We need to check out the submodules from the "commit under review".
1 parent d176d46 commit 35c6d81

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/pr-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ jobs:
5757
- name: Clone the repo
5858
uses: actions/checkout@v4
5959
with:
60-
submodules: recursive
6160
fetch-depth: 0
6261
ref: ${{ github.event.pull_request.base.sha }}
6362

@@ -70,6 +69,7 @@ jobs:
7069
run: |
7170
git fetch origin ${{ matrix.commit }} ${{ github.event.pull_request.merge_commit_sha }}
7271
git merge --no-ff --no-edit ${{ matrix.commit }}
72+
git submodule update --init --recursive
7373
git log -1 --format="Head %H, Parents %P"
7474
# Since the workflow definition is taken from the pull request merge commit, we need to
7575
# get the .ci scripts from there as well.

0 commit comments

Comments
 (0)