u2f: clang-tidy lint bugprone-not-null-terminated-result

NickeZ · NickeZ · commit 5bf1f1ba1465 · 2024-09-02T15:40:52.000+02:00
diff --git a/src/u2f.c b/src/u2f.c
@@ -696,7 +696,8 @@ static void _authenticate_continue(const USB_APDU* apdu, Packet* out_packet)
     size_t auth_packet_len = sizeof(U2F_AUTHENTICATE_RESP) - U2F_MAX_EC_SIG_SIZE + der_len;
 
     // Append success bytes
-    memcpy(buf + auth_packet_len, "\x90\x00", 2);
+    uint8_t success_bytes[] = {0x90, 0x00};
+    memcpy(buf + auth_packet_len, success_bytes, sizeof(success_bytes));
 
     _fill_message(buf, auth_packet_len + 2, out_packet);
 }

Original file line number	Diff line number	Diff line change
`@@ -696,7 +696,8 @@ static void _authenticate_continue(const USB_APDU* apdu, Packet* out_packet)`
`696`	`696`	`size_t auth_packet_len = sizeof(U2F_AUTHENTICATE_RESP) - U2F_MAX_EC_SIG_SIZE + der_len;`
`697`	`697`
`698`	`698`	`// Append success bytes`
`699`		`- memcpy(buf + auth_packet_len, "\x90\x00", 2);`
	`699`	`+ uint8_t success_bytes[] = {0x90, 0x00};`
	`700`	`+ memcpy(buf + auth_packet_len, success_bytes, sizeof(success_bytes));`
`700`	`701`
`701`	`702`	`_fill_message(buf, auth_packet_len + 2, out_packet);`
`702`	`703`	`}`