eth: move erc20_params into new crate

The plan is to auto-generate the Rust list of tokens from a txt/json
file in build.rs, so it's cleaner to have that separated out into its
own crate.

Author: benma

src/rust/Cargo.lock

@@ -21,6 +21,7 @@ members = [
     "bitbox02-noise",
     "bitbox02",
     "bitbox02-sys",
+    "erc20_params",
 ]
 
 resolver = "2"

src/rust/Cargo.toml

@@ -28,7 +28,8 @@ doctest = false
 
 [dependencies]
 bitbox02 = {path = "../bitbox02"}
-util = {path = "../util"}
+util = { path = "../util" }
+erc20_params = { path = "../erc20_params", optional = true }
 binascii = { version = "0.1.4", default-features = false, features = ["encode"] }
 bitbox02-noise = {path = "../bitbox02-noise"}
 hex = { workspace = true }
@@ -70,6 +71,7 @@ ed25519 = [
 
 app-ethereum = [
   # enable these dependencies
+  "erc20_params",
   "sha3",
   "num-bigint",
   "num-traits",

src/rust/bitbox02-rust/Cargo.toml

@@ -19,7 +19,6 @@ compile_error!(
 
 mod address;
 mod amount;
-mod erc20_params;
 mod keypath;
 mod params;
 mod pubrequest;

src/rust/bitbox02-rust/src/hww/api/ethereum.rs

@@ -27,15 +27,15 @@ async fn process_address(request: &pb::EthPubRequest) -> Result<Response, Error>
 
     let params = super::params::get_and_warn_unknown(Some(coin), request.chain_id).await?;
     // If a contract_address is provided, it has to be a supported ERC20-token.
-    let erc20_params: Option<super::erc20_params::Params> = if request.contract_address.is_empty() {
+    let erc20_params: Option<erc20_params::Params> = if request.contract_address.is_empty() {
         None
     } else {
         let address: [u8; 20] = request
             .contract_address
             .as_slice()
             .try_into()
             .or(Err(Error::InvalidInput))?;
-        Some(super::erc20_params::get(params.chain_id, address).ok_or(Error::InvalidInput)?)
+        Some(erc20_params::get(params.chain_id, address).ok_or(Error::InvalidInput)?)
     };
 
     if !super::keypath::is_valid_keypath_address(&request.keypath) {

src/rust/bitbox02-rust/src/hww/api/ethereum/pubrequest.rs

@@ -201,8 +201,7 @@ async fn verify_erc20_transaction(
     erc20_recipient: [u8; 20],
     erc20_value: BigUint,
 ) -> Result<(), Error> {
-    let erc20_params =
-        super::erc20_params::get(params.chain_id, parse_recipient(request.recipient())?);
+    let erc20_params = erc20_params::get(params.chain_id, parse_recipient(request.recipient())?);
     let formatted_fee = parse_fee(request, params).format();
     let recipient_address = super::address::from_pubkey_hash(&erc20_recipient);
     let (formatted_value, formatted_total) = match erc20_params {

src/rust/bitbox02-rust/src/hww/api/ethereum/sign.rs

@@ -0,0 +1 @@
+target

src/rust/erc20_params/.gitignore

@@ -0,0 +1,20 @@
+# Copyright 2024 Shift Cryptos AG
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+[package]
+name = "erc20_params"
+version = "0.1.0"
+authors = ["Shift Crypto AG <[email protected]>"]
+edition = "2021"
+license = "Apache-2.0"

src/rust/erc20_params/Cargo.toml

@@ -12,6 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+#![no_std]
+
 #[repr(packed)]
 struct P {
     pub unit: *const u8,