util/format_datetime: don't mock for tests

No reason not to test the real thing.

Author: benma

src/rust/bitbox02-rust/src/hww.rs

@@ -373,7 +373,7 @@ mod tests {
                     UI_COUNTER += 1;
                     UI_COUNTER
                 } {
-                    1 => assert_eq!(params.body, "<date>"),
+                    1 => assert_eq!(params.body, "Mon 2020-09-28"),
                     2 => assert_eq!(params.body, "Proceed to upgrade?"),
                     _ => panic!("too many dialogs"),
                 }
@@ -467,7 +467,7 @@ mod tests {
                         UI_COUNTER += 1;
                         UI_COUNTER
                     } {
-                        1 => assert_eq!(params.body, "<date>"),
+                        1 => assert_eq!(params.body, "Mon 2020-09-28"),
                         2 => assert_eq!(params.title, "RESET"),
                         3 => assert_eq!(params.body, "Restore backup?"),
                         4 => assert!(params.body.starts_with("Name: test device name.")),

src/rust/bitbox02-rust/src/hww/api/backup.rs

@@ -174,7 +174,7 @@ mod tests {
         mock(Data {
             sdcard_inserted: Some(true),
             ui_confirm_create: Some(Box::new(|params| {
-                assert_eq!(params.body, "<date>");
+                assert_eq!(params.body, "Mon 2020-09-28");
                 true
             })),
             ..Default::default()

src/rust/bitbox02/src/lib.rs

@@ -131,7 +131,6 @@ pub fn strftime(timestamp: u32, format: &str) -> String {
         .into()
 }
 
-#[cfg(not(feature = "testing"))]
 pub fn format_datetime(timestamp: u32, timezone_offset: i32, date_only: bool) -> String {
     let mut out = [0u8; 100];
     unsafe {
@@ -148,15 +147,6 @@ pub fn format_datetime(timestamp: u32, timezone_offset: i32, date_only: bool) ->
         .into()
 }
 
-#[cfg(feature = "testing")]
-pub fn format_datetime(_timestamp: u32, _timezone_offset: i32, date_only: bool) -> String {
-    if date_only {
-        "<date>".into()
-    } else {
-        "<datetime>".into()
-    }
-}
-
 #[cfg(not(feature = "testing"))]
 pub fn reboot() -> ! {
     unsafe { bitbox02_sys::reboot() }