Merge branch 'unused'

Author: benma

.ci/check-tidy

@@ -57,5 +57,5 @@ for dir in build build-build; do
 	echo "Checking $(echo ${SOURCES} | wc -w) files with clang-tidy"
 
 	# The list of tidy checks must stay in sync with scripts/tidy
-	${CLANGTIDY} -quiet -p ${dir} -checks=-*,clang-analyzer-*,-clang-analyzer-cplusplus*,bugprone-*,performance-*,portability-*,readability-*,-readability-braces-around-statements,-readability-magic-numbers,-readability-isolate-declaration,-readability-identifier-length,-readability-function-cognitive-complexity,-bugprone-reserved-identifier,-performance-no-int-to-ptr -warnings-as-errors=* -header-filter '.*' ${SOURCES}
+	${CLANGTIDY} -quiet -p ${dir} -checks=-*,clang-analyzer-*,-clang-analyzer-cplusplus*,bugprone-*,performance-*,portability-*,readability-*,-readability-braces-around-statements,-readability-magic-numbers,-readability-isolate-declaration,-readability-identifier-length,-readability-function-cognitive-complexity,-bugprone-reserved-identifier,-bugprone-easily-swappable-parameters,-performance-no-int-to-ptr -warnings-as-errors=* -header-filter '.*' ${SOURCES}
 done

src/CMakeLists.txt

@@ -37,9 +37,6 @@ set(DBB-FIRMWARE-SOURCES
   ${CMAKE_SOURCE_DIR}/src/workflow/blocking.c
   ${CMAKE_SOURCE_DIR}/src/workflow/idle_workflow.c
   ${CMAKE_SOURCE_DIR}/src/workflow/orientation_screen.c
-  ${CMAKE_SOURCE_DIR}/src/workflow/status.c
-  ${CMAKE_SOURCE_DIR}/src/workflow/verify_recipient.c
-  ${CMAKE_SOURCE_DIR}/src/workflow/verify_total.c
   ${CMAKE_SOURCE_DIR}/src/apps/btc/btc_common.c
   ${CMAKE_SOURCE_DIR}/src/queue.c
   ${CMAKE_SOURCE_DIR}/src/usb/usb_processing.c

src/firmware_main_loop.c

@@ -22,7 +22,6 @@
 #include "ui/screen_stack.h"
 #include "usb/usb.h"
 #include "usb/usb_processing.h"
-#include "workflow/workflow.h"
 #include <rust/rust.h>
 
 void firmware_main_loop(void)

src/memory/smarteeprom.c

@@ -22,7 +22,6 @@
 #include <screen.h>
 #include <stdint.h>
 #include <string.h>
-#include <workflow/status.h>
 
 #define SMARTEEPROM_WRITE_MODE_UNBUFFERED (0)
 #define SMARTEEPROM_WRITE_MODE_BUFFERED (1)
@@ -69,8 +68,8 @@ void smarteeprom_setup(void)
          * however, we want to inform the user that there's a big issue.
          */
         for (int i = 0; i < 3; ++i) {
-            workflow_status_blocking("Failed to erase SmartEEPROM memory area.", false);
-            workflow_status_blocking("We suggest you reset the device and contact support.", false);
+            screen_print_debug("Failed to erase SmartEEPROM memory area.", 3000);
+            screen_print_debug("We suggest you reset the device and contact support.", 3000);
         }
     }
     /*
@@ -110,9 +109,8 @@ void smarteeprom_bb02_config(void)
     NVMCTRL->SEECFG.bit.WMODE = SMARTEEPROM_WRITE_MODE_BUFFERED;
     if (NVMCTRL->SEESTAT.bit.LOAD != 0) {
         for (int i = 0; i < 3; ++i) {
-            workflow_status_blocking(
-                "SmartEEPROM just initialized, but data found in cache!", false);
-            workflow_status_blocking("We suggest you reset the device and contact support.", false);
+            screen_print_debug("SmartEEPROM just initialized, but data found in cache!", 3000);
+            screen_print_debug("We suggest you reset the device and contact support.", 3000);
         }
     }
 }

src/reset.c

@@ -18,7 +18,6 @@
 #include "keystore.h"
 #include "memory/memory.h"
 #include "memory/smarteeprom.h"
-#include "workflow/status.h"
 
 #ifndef TESTING
 #include "securechip/securechip.h"

src/rust/bitbox02-rust-c/src/workflow.rs

@@ -20,8 +20,8 @@ extern crate alloc;
 
 use alloc::boxed::Box;
 use alloc::string::String;
-use bitbox02_rust::bb02_async::{block_on, spin, Task};
-use bitbox02_rust::workflow::{confirm, status};
+use bitbox02_rust::bb02_async::{spin, Task};
+use bitbox02_rust::workflow::confirm;
 use core::task::Poll;
 
 enum TaskState<'a, O> {
@@ -123,11 +123,3 @@ pub unsafe extern "C" fn rust_workflow_abort_current() {
     CONFIRM_PARAMS = None;
     CONFIRM_STATE = TaskState::Nothing;
 }
-
-#[no_mangle]
-pub unsafe extern "C" fn rust_workflow_status_blocking(
-    msg: crate::util::CStr,
-    status_success: bool,
-) {
-    block_on(status::status(msg.as_ref(), status_success))
-}

src/u2f/u2f_app.h

@@ -21,7 +21,6 @@
 #include <stdint.h>
 
 #include <util.h>
-#include <workflow/workflow.h>
 
 /** Size of application IDs */
 #define U2F_APPID_SIZE 32