Merge pull request #6218 from BitGo/vechain-ob

feat(sdk-coin-vet): address and wallet creation

Author: at31416

modules/sdk-coin-vet/package.json

@@ -41,7 +41,9 @@
   },
   "dependencies": {
     "@bitgo/sdk-core": "^35.1.0",
-    "@bitgo/statics": "^54.1.0"
+    "@bitgo/statics": "^54.1.0",
+    "@bitgo/abstract-eth": "^24.4.0",
+    "@bitgo/secp256k1": "^1.3.3"
   },
   "devDependencies": {
     "@bitgo/sdk-api": "^1.63.3",

modules/sdk-coin-vet/src/lib/utils.ts

@@ -2,7 +2,7 @@ import { BaseUtils } from '@bitgo/sdk-core';
 
 export class Utils implements BaseUtils {
   isValidAddress(address: string): boolean {
-    throw new Error('Method not implemented');
+    return /^0x[0-9a-fA-F]{40}$/.test(address);
   }
 
   isValidBlockId(hash: string): boolean {

modules/sdk-coin-vet/src/vet.ts

@@ -3,6 +3,7 @@ import {
   BaseCoin,
   BaseTransaction,
   BitGoBase,
+  InvalidAddressError,
   KeyPair,
   MPCAlgorithm,
   MultisigType,
@@ -15,6 +16,9 @@ import {
 } from '@bitgo/sdk-core';
 import { BaseCoin as StaticsBaseCoin } from '@bitgo/statics';
 import utils from './lib/utils';
+import { bip32 } from '@bitgo/secp256k1';
+import { randomBytes } from 'crypto';
+import { KeyPair as EthKeyPair } from '@bitgo/abstract-eth';
 
 /**
  * Full Name: Vechain
@@ -79,7 +83,12 @@ export class Vet extends BaseCoin {
   }
 
   async isWalletAddress(params: VerifyAddressOptions): Promise<boolean> {
-    throw new Error('Method not implemented');
+    const { address: newAddress } = params;
+
+    if (!this.isValidAddress(newAddress)) {
+      throw new InvalidAddressError(`invalid address: ${newAddress}`);
+    }
+    return true;
   }
 
   async parseTransaction(): Promise<ParsedTransaction> {
@@ -95,11 +104,28 @@ export class Vet extends BaseCoin {
   }
 
   generateKeyPair(seed?: Buffer): KeyPair {
-    throw new Error('Method not implemented');
+    if (!seed) {
+      // An extended private key has both a normal 256 bit private key and a 256
+      // bit chain code, both of which must be random. 512 bits is therefore the
+      // maximum entropy and gives us maximum security against cracking.
+      seed = randomBytes(512 / 8);
+    }
+    const extendedKey = bip32.fromSeed(seed);
+    const xpub = extendedKey.neutered().toBase58();
+    return {
+      pub: xpub,
+      prv: extendedKey.toBase58(),
+    };
   }
 
   isValidPub(pub: string): boolean {
-    throw new Error('Method not implemented.');
+    let valid = true;
+    try {
+      new EthKeyPair({ pub });
+    } catch (e) {
+      valid = false;
+    }
+    return valid;
   }
 
   isValidAddress(address: string): boolean {

modules/sdk-coin-vet/test/unit/vet.ts

@@ -25,4 +25,13 @@ describe('Vechain', function () {
     tvet.getFullName().should.equal('Testnet VeChain');
     tvet.getBaseFactor().should.equal(1e18);
   });
+
+  it('should validate address', function () {
+    const vet = bitgo.coin('vet');
+    vet.isValidAddress('wrongaddress').should.false();
+    vet.isValidAddress('25bcb8855effa9f12a23c2f7f34f2d92b5841f19').should.false();
+    vet.isValidAddress('0x7Ca00e3bC8a836026C2917C6c7c6D049E52099dd').should.true();
+    vet.isValidAddress('0x690fFcefa92876C772E85d4B5963807C2152e08d').should.true();
+    vet.isValidAddress('0xe59F1cea4e0FEf511e3d0f4EEc44ADf19C4cbeEC').should.true();
+  });
 });