Revert "feat(sdk-coin-apt): send many: addition of recipients (single recipient)"

baltiyal · web-flow · commit 0c3ebc6db5c5 · 2025-03-24T19:23:01.000+05:30
diff --git a/modules/sdk-coin-apt/src/lib/iface.ts b/modules/sdk-coin-apt/src/lib/iface.ts
@@ -16,7 +16,6 @@ export interface TxData {
   id: string;
   sender: string;
   recipient: TransactionRecipient;
-  recipients: TransactionRecipient[];
   sequenceNumber: number;
   maxGasAmount: number;
   gasUnitPrice: number;
diff --git a/modules/sdk-coin-apt/src/lib/transaction/digitalAssetTransfer.ts b/modules/sdk-coin-apt/src/lib/transaction/digitalAssetTransfer.ts
@@ -37,20 +37,19 @@ export class DigitalAssetTransfer extends Transaction {
       throw new InvalidTransactionError('Invalid transaction payload');
     }
     const entryFunction = payload.entryFunction;
+    if (!this._recipient) {
+      this._recipient = {} as TransactionRecipient;
+    }
     this._assetId = entryFunction.args[0].toString();
-    this.recipients = [
-      {
-        address: entryFunction.args[1].toString(),
-        amount: DIGITAL_ASSET_TRANSFER_AMOUNT,
-      },
-    ] as TransactionRecipient[];
+    this._recipient.address = entryFunction.args[1].toString();
+    this._recipient.amount = DIGITAL_ASSET_TRANSFER_AMOUNT;
   }
 
   protected async buildRawTransaction(): Promise<void> {
     const network: Network = this._coinConfig.network.type === NetworkType.MAINNET ? Network.MAINNET : Network.TESTNET;
     const aptos = new Aptos(new AptosConfig({ network }));
     const senderAddress = AccountAddress.fromString(this._sender);
-    const recipientAddress = AccountAddress.fromString(this.recipients[0].address);
+    const recipientAddress = AccountAddress.fromString(this._recipient.address);
     const digitalAssetAddress = AccountAddress.fromString(this._assetId);
 
     const transferDigitalAssetAbi: EntryFunctionABI = {
diff --git a/modules/sdk-coin-apt/src/lib/transaction/fungibleAssetTransfer.ts b/modules/sdk-coin-apt/src/lib/transaction/fungibleAssetTransfer.ts
@@ -32,21 +32,21 @@ export class FungibleAssetTransfer extends Transaction {
       throw new InvalidTransactionError('Invalid transaction payload');
     }
     const entryFunction = payload.entryFunction;
+    if (!this._recipient) {
+      this._recipient = {} as TransactionRecipient;
+    }
     this._assetId = entryFunction.args[0].toString();
-    this.recipients = [
-      {
-        address: entryFunction.args[1].toString(),
-        amount: utils.getAmountFromPayloadArgs(entryFunction.args[2].bcsToBytes()),
-      },
-    ] as TransactionRecipient[];
+    this._recipient.address = entryFunction.args[1].toString();
+    this._recipient.amount = utils.getAmountFromPayloadArgs(entryFunction.args[2].bcsToBytes());
   }
 
   protected async buildRawTransaction(): Promise<void> {
     const network: Network = this._coinConfig.network.type === NetworkType.MAINNET ? Network.MAINNET : Network.TESTNET;
     const aptos = new Aptos(new AptosConfig({ network }));
     const senderAddress = AccountAddress.fromString(this._sender);
-    const recipientAddress = AccountAddress.fromString(this.recipients[0].address);
+    const recipientAddress = AccountAddress.fromString(this._recipient.address);
     const fungibleTokenAddress = this._assetId;
+
     const faTransferAbi: EntryFunctionABI = {
       typeParameters: [{ constraints: [] }],
       parameters: [parseTypeTag('0x1::object::Object'), new TypeTagAddress(), new TypeTagU64()],
@@ -57,7 +57,7 @@ export class FungibleAssetTransfer extends Transaction {
       data: {
         function: FUNGIBLE_ASSET_TRANSFER_FUNCTION,
         typeArguments: [FUNGIBLE_ASSET_TYPE_ARGUMENT],
-        functionArguments: [fungibleTokenAddress, recipientAddress, this.recipients[0].amount],
+        functionArguments: [fungibleTokenAddress, recipientAddress, this.recipient.amount],
         abi: faTransferAbi,
       },
       options: {
diff --git a/modules/sdk-coin-apt/src/lib/transaction/transaction.ts b/modules/sdk-coin-apt/src/lib/transaction/transaction.ts
@@ -32,14 +32,13 @@ import { DEFAULT_GAS_UNIT_PRICE, UNAVAILABLE_TEXT } from '../constants';
 import utils from '../utils';
 import BigNumber from 'bignumber.js';
 import { AptTransactionExplanation, TxData } from '../iface';
-import assert from 'assert';
 
 export abstract class Transaction extends BaseTransaction {
   protected _rawTransaction: RawTransaction;
   protected _senderSignature: Signature;
   protected _feePayerSignature: Signature;
   protected _sender: string;
-  protected _recipients: TransactionRecipient[];
+  protected _recipient: TransactionRecipient;
   protected _sequenceNumber: number;
   protected _maxGasAmount: number;
   protected _gasUnitPrice: number;
@@ -60,7 +59,6 @@ export abstract class Transaction extends BaseTransaction {
     this._expirationTime = utils.getTxnExpirationTimestamp();
     this._sequenceNumber = 0;
     this._sender = AccountAddress.ZERO.toString();
-    this._recipients = [];
     this._assetId = AccountAddress.ZERO.toString();
     this._isSimulateTxn = false;
     this._senderSignature = {
@@ -92,27 +90,12 @@ export abstract class Transaction extends BaseTransaction {
     this._sender = value;
   }
 
-  /**
-   * @deprecated - use `recipients()`.
-   */
   get recipient(): TransactionRecipient {
-    assert(this._recipients.length > 0, 'No recipients available');
-    return this._recipients[0];
+    return this._recipient;
   }
 
-  /**
-   * @deprecated - use `recipients()`.
-   */
   set recipient(value: TransactionRecipient) {
-    this.recipients = [value];
-  }
-
-  get recipients(): TransactionRecipient[] {
-    return this._recipients;
-  }
-
-  set recipients(value: TransactionRecipient[]) {
-    this._recipients = value;
+    this._recipient = value;
   }
 
   get sequenceNumber(): number {
@@ -275,24 +258,20 @@ export abstract class Transaction extends BaseTransaction {
   }
 
   loadInputsAndOutputs(): void {
-    const totalAmount = this._recipients.reduce(
-      (accumulator, current) => accumulator.plus(current.amount),
-      new BigNumber('0')
-    );
     this._inputs = [
       {
         address: this.sender,
-        value: totalAmount.toString(),
+        value: this.recipient.amount as string,
         coin: this._coinConfig.name,
       },
     ];
-    this._outputs = this._recipients.map((recipient) => {
-      return {
-        address: recipient.address,
-        value: recipient.amount as string,
+    this._outputs = [
+      {
+        address: this.recipient.address,
+        value: this.recipient.amount as string,
         coin: this._coinConfig.name,
-      };
-    });
+      },
+    ];
   }
 
   fromRawTransaction(rawTransaction: string): void {
@@ -324,7 +303,6 @@ export abstract class Transaction extends BaseTransaction {
       id: this.id,
       sender: this.sender,
       recipient: this.recipient,
-      recipients: this.recipients,
       sequenceNumber: this.sequenceNumber,
       maxGasAmount: this.maxGasAmount,
       gasUnitPrice: this.gasUnitPrice,
@@ -357,10 +335,8 @@ export abstract class Transaction extends BaseTransaction {
       'type',
     ];
 
-    const outputs: TransactionRecipient[] = this._recipients;
-    const outputAmount = outputs
-      .reduce((accumulator, current) => accumulator.plus(current.amount), new BigNumber('0'))
-      .toString();
+    const outputs: TransactionRecipient[] = [this.recipient];
+    const outputAmount = outputs[0].amount;
     return {
       displayOrder,
       id: this.id,
diff --git a/modules/sdk-coin-apt/src/lib/transaction/transferTransaction.ts b/modules/sdk-coin-apt/src/lib/transaction/transferTransaction.ts
@@ -30,26 +30,25 @@ export class TransferTransaction extends Transaction {
       throw new InvalidTransactionError('Invalid transaction payload');
     }
     const entryFunction = payload.entryFunction;
+    if (!this._recipient) {
+      this._recipient = {} as TransactionRecipient;
+    }
     this._assetId = entryFunction.type_args[0].toString();
-    this.recipients = [
-      {
-        address: entryFunction.args[0].toString(),
-        amount: utils.getAmountFromPayloadArgs(entryFunction.args[1].bcsToBytes()),
-      },
-    ] as TransactionRecipient[];
+    this._recipient.address = entryFunction.args[0].toString();
+    this._recipient.amount = utils.getAmountFromPayloadArgs(entryFunction.args[1].bcsToBytes());
   }
 
   protected async buildRawTransaction(): Promise<void> {
     const network: Network = this._coinConfig.network.type === NetworkType.MAINNET ? Network.MAINNET : Network.TESTNET;
     const aptos = new Aptos(new AptosConfig({ network }));
     const senderAddress = AccountAddress.fromString(this._sender);
-    const recipientAddress = AccountAddress.fromString(this.recipients[0].address);
+    const recipientAddress = AccountAddress.fromString(this._recipient.address);
     const simpleTxn = await aptos.transaction.build.simple({
       sender: senderAddress,
       data: {
         function: COIN_TRANSFER_FUNCTION,
         typeArguments: [this.assetId],
-        functionArguments: [recipientAddress, this.recipients[0].amount],
+        functionArguments: [recipientAddress, this.recipient.amount],
       },
       options: {
         maxGasAmount: this.maxGasAmount,
diff --git a/modules/sdk-coin-apt/src/lib/transactionBuilder/transactionBuilder.ts b/modules/sdk-coin-apt/src/lib/transactionBuilder/transactionBuilder.ts
@@ -63,22 +63,10 @@ export abstract class TransactionBuilder extends BaseTransactionBuilder {
     return this;
   }
 
-  /**
-   * @deprecated - use `recipients()`.
-   */
   recipient(recipient: Recipient): this {
     this.validateAddress({ address: recipient.address });
     this.validateValue(new BigNumber(recipient.amount));
-    this.transaction.recipients = [recipient];
-    return this;
-  }
-
-  recipients(recipients: Recipient[]): this {
-    for (const recipient of recipients) {
-      this.validateAddress({ address: recipient.address });
-      this.validateValue(new BigNumber(recipient.amount));
-    }
-    this.transaction.recipients = recipients;
+    this.transaction.recipient = recipient;
     return this;
   }
 
@@ -155,10 +143,8 @@ export abstract class TransactionBuilder extends BaseTransactionBuilder {
       throw new Error('transaction not defined');
     }
     this.validateAddress({ address: transaction.sender });
-    for (const recipient of transaction.recipients) {
-      this.validateAddress({ address: recipient.address });
-      this.validateValue(new BigNumber(recipient.amount));
-    }
+    this.validateAddress({ address: transaction.recipient.address });
+    this.validateValue(new BigNumber(transaction.recipient.amount));
   }
 
   isValidRawTransaction(rawTransaction: string): boolean {
diff --git a/modules/sdk-coin-apt/test/unit/transactionBuilder/digitalAssetTransferBuilder.ts b/modules/sdk-coin-apt/test/unit/transactionBuilder/digitalAssetTransferBuilder.ts
diff --git a/modules/sdk-coin-apt/test/unit/transactionBuilder/fungibleAssetTransferBuilder.ts b/modules/sdk-coin-apt/test/unit/transactionBuilder/fungibleAssetTransferBuilder.ts
diff --git a/modules/sdk-coin-apt/test/unit/transactionBuilder/transferBuilder.ts b/modules/sdk-coin-apt/test/unit/transactionBuilder/transferBuilder.ts
