fix(bitgo): update imports and assertions for Node 22 compatibility

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

TICKET: WP-5599

Author: zahin-mohammad

modules/bitgo/test/ecdh.ts

@@ -21,7 +21,7 @@ describe('ECDH utils', () => {
       const eckey1 = getKey(`${i}.a`);
       const eckey2 = getKey(`${i}.b`);
 
-      assert(eckey1.privateKey);
+      assert.ok(eckey1.privateKey);
       [eckey1, utxolib.bitgo.keyutil.privateKeyBufferToECPair(eckey1.privateKey)].forEach((privateKey) => {
         const sharingKey1 = getSharedSecret(privateKey, eckey2).toString('hex');
         const sharingKey2 = getSharedSecret(eckey2, eckey1).toString('hex');

modules/bitgo/test/encrypt.ts

@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import * as should from 'should';
+import should = require('should');
 
 import { randomBytes } from 'crypto';
 import { decrypt, encrypt, bytesToWord } from '@bitgo/sdk-api';

modules/bitgo/test/integration/accesstoken.ts

@@ -7,7 +7,7 @@
 /* eslint-disable @typescript-eslint/no-empty-function */
 
 import { strict as assert } from 'assert';
-import * as should from 'should';
+import should = require('should');
 import * as _ from 'lodash';
 
 const TestBitGo = require('../lib/test_bitgo');

modules/bitgo/test/integration/blockchain.ts

@@ -86,9 +86,9 @@ describe('Address', function () {
         assert.equal(result.start, 0);
         result.should.have.property('total');
         result.should.have.property('count');
-        assert(result.transactions.length > 20);
+        assert.ok(result.transactions.length > 20);
         assert.equal(result.transactions.length, result.count);
-        assert(result.total > 75);
+        assert.ok(result.total > 75);
         done();
       });
     });

modules/bitgo/test/integration/testutil.ts

@@ -3,7 +3,7 @@
  */
 
 const TestUtil = module.exports;
-import * as should from 'should';
+import should = require('should');
 import * as _ from 'lodash';
 const Q = require('q');
 

modules/bitgo/test/integration/travelRule.ts

@@ -213,7 +213,7 @@ describe('Travel Rule API', function () {
       return travel
         .sendMany({ txid: txid, travelInfos: travelInfos })
         .then(function () {
-          assert(false); // should not get here
+          assert.ok(false); // should not get here
         })
         .catch(function (err) {
           err.message.should.equal('amount did not match for output index 0');

modules/bitgo/test/integration/wallet.ts

@@ -7,7 +7,7 @@
 /* eslint-disable @typescript-eslint/no-empty-function */
 
 import { strict as assert } from 'assert';
-import * as should from 'should';
+import should = require('should');
 import { VirtualSizes } from '@bitgo/unspents';
 import * as utxolib from '@bitgo/utxo-lib';
 
@@ -1044,7 +1044,7 @@ describe('Wallet API', function () {
           progressDetails.should.have.property('index');
           progressDetails.should.have.property('inputCount');
           progressDetails.index.should.equal(progressCallbackCount);
-          assert(progressDetails.inputCount <= maxInputCountPerConsolidation);
+          assert.ok(progressDetails.inputCount <= maxInputCountPerConsolidation);
           progressCallbackCount++;
         };
 
@@ -2445,7 +2445,7 @@ describe('Wallet API', function () {
             walletPassphrase: TestBitGo.TEST_WALLET1_PASSCODE,
           })
           .then(function (res) {
-            assert(false); // should not reach
+            assert.ok(false); // should not reach
           })
           .catch(function (err) {
             err.message.should.eql('Insufficient funds');
@@ -2466,7 +2466,7 @@ describe('Wallet API', function () {
             instant: true,
           })
           .then(function (res) {
-            assert(false); // should not reach
+            assert.ok(false); // should not reach
           })
           .catch(function (err) {
             err.message.should.eql('wallet does not support instant transactions');
@@ -2486,7 +2486,7 @@ describe('Wallet API', function () {
             });
           })
           .then(function (result) {
-            assert(false); // should not reach
+            assert.ok(false); // should not reach
           })
           .catch(function (err) {
             err.needsOTP.should.equal(true);
@@ -3037,7 +3037,7 @@ describe('Wallet API', function () {
           .createTransaction({ recipients: recipients })
           .then(function (result) {
             // should not reach
-            assert(false);
+            assert.ok(false);
           })
           .catch(function (err) {
             err.message.should.containEql('incorrect type for field fromUserName in travel info');

modules/bitgo/test/integration/wallets.ts

@@ -14,7 +14,7 @@ const TestBitGo = require('../lib/test_bitgo');
 import * as utxolib from '@bitgo/utxo-lib';
 import { getAddressP2PKH, getNetwork } from '../../src/bitcoin';
 import { common } from '@bitgo/sdk-core';
-import * as nock from 'nock';
+import nock = require('nock');
 
 const TEST_WALLET_LABEL = 'wallet management test';
 
@@ -171,7 +171,7 @@ describe('Wallets', function () {
           assert.equal(keychain.xpub, keychains[1].xpub);
 
           bitgo.keychains().createBitGo({}, function (err, keychain) {
-            assert(keychain.xpub);
+            assert.ok(keychain.xpub);
             keychains.push(keychain);
 
             const options = {
@@ -362,7 +362,7 @@ describe('Wallets', function () {
         id: newKey.address.toString(),
       };
       wallets.get(options, function (err, wallet) {
-        assert(!wallet);
+        assert.ok(!wallet);
         done();
       });
     });

modules/bitgo/test/unit/bitgo.ts

@@ -3,8 +3,8 @@
 //
 
 import * as crypto from 'crypto';
-import * as nock from 'nock';
-import * as should from 'should';
+import nock = require('nock');
+import should = require('should');
 import assert = require('assert');
 
 import { common, generateGPGKeyPair } from '@bitgo/sdk-core';
@@ -707,7 +707,7 @@ describe('BitGo Prototype Methods', function () {
       nock('https://bitgo.fakeurl')
         .post('/api/auth/v1/session')
         .reply(200, async (uri, requestBody) => {
-          assert(typeof requestBody === 'object');
+          assert.ok(typeof requestBody === 'object');
           should.exist(requestBody.userId);
           should.exist(requestBody.passkey);
           requestBody.userId.should.equal(userId);
@@ -752,7 +752,7 @@ describe('BitGo Prototype Methods', function () {
         assert.fail('Expected error not thrown');
       } catch (e) {
         console.log(e);
-        assert(e.message.includes('JSON'));
+        assert.ok(e.message.includes('JSON'));
       }
     });
     it('should throw - missing access token', async () => {

modules/bitgo/test/unit/keychains.ts

@@ -3,8 +3,8 @@
 //
 
 import * as _ from 'lodash';
-import * as nock from 'nock';
 import 'should';
+import nock = require('nock');
 
 import { common } from '@bitgo/sdk-core';