fix(express): construct pending approval type codec

Ticket: WP-6717

Author: lokesh-bitgo

modules/express/src/typedRoutes/api/v1/constructPendingApprovalTx.ts

@@ -35,19 +35,19 @@ export const ConstructPendingApprovalTxResponse = t.type({
   /** The signed transaction hex */
   tx: t.string,
   /** The fee amount in satoshis */
-  fee: optional(t.number),
+  fee: t.number,
   /** The fee rate in satoshis per kilobyte */
-  feeRate: optional(t.number),
+  feeRate: t.number,
   /** Whether the transaction is instant */
   instant: optional(t.boolean),
   /** The BitGo fee amount */
   bitgoFee: optional(t.unknown),
   /** Travel information */
   travelInfos: optional(t.unknown),
   /** Estimated transaction size in bytes */
-  estimatedSize: optional(t.number),
+  estimatedSize: t.number,
   /** Unspent transaction outputs used */
-  unspents: optional(t.array(t.unknown)),
+  unspents: t.array(t.unknown),
 });
 
 /**

modules/express/test/unit/typedRoutes/constructPendingApprovalTx.ts

@@ -192,13 +192,21 @@ describe('ConstructPendingApprovalTx codec tests', function () {
   });
 
   describe('ConstructPendingApprovalTxResponse', function () {
-    it('should validate response with required tx field', function () {
+    it('should validate response with all required fields', function () {
       const validResponse = {
         tx: '0100000001c7dad3d9607a23c45a6c1c5ad7bce02acff71a0f21eb4a72a59d0c0e19402d0f0000000000ffffffff0180a21900000000001976a914c918e1b36f2c72b1aaef94dbb7f578a4b68b542788ac00000000',
+        fee: 10000,
+        feeRate: 20000,
+        estimatedSize: 256,
+        unspents: [],
       };
 
       const decoded = assertDecode(ConstructPendingApprovalTxResponse, validResponse);
       assert.strictEqual(decoded.tx, validResponse.tx);
+      assert.strictEqual(decoded.fee, validResponse.fee);
+      assert.strictEqual(decoded.feeRate, validResponse.feeRate);
+      assert.strictEqual(decoded.estimatedSize, validResponse.estimatedSize);
+      assert.deepStrictEqual(decoded.unspents, validResponse.unspents);
     });
 
     it('should validate response with all fields', function () {
@@ -234,6 +242,62 @@ describe('ConstructPendingApprovalTx codec tests', function () {
       });
     });
 
+    it('should reject response with missing fee', function () {
+      const invalidResponse = {
+        tx: '0100000001c7dad3d9607a23c45a6c1c5ad7bce02acff71a0f21eb4a72a59d0c0e19402d0f0000000000ffffffff0180a21900000000001976a914c918e1b36f2c72b1aaef94dbb7f578a4b68b542788ac00000000',
+        // Missing fee (required)
+        feeRate: 20000,
+        estimatedSize: 256,
+        unspents: [],
+      };
+
+      assert.throws(() => {
+        assertDecode(ConstructPendingApprovalTxResponse, invalidResponse);
+      });
+    });
+
+    it('should reject response with missing feeRate', function () {
+      const invalidResponse = {
+        tx: '0100000001c7dad3d9607a23c45a6c1c5ad7bce02acff71a0f21eb4a72a59d0c0e19402d0f0000000000ffffffff0180a21900000000001976a914c918e1b36f2c72b1aaef94dbb7f578a4b68b542788ac00000000',
+        fee: 10000,
+        // Missing feeRate (required)
+        estimatedSize: 256,
+        unspents: [],
+      };
+
+      assert.throws(() => {
+        assertDecode(ConstructPendingApprovalTxResponse, invalidResponse);
+      });
+    });
+
+    it('should reject response with missing estimatedSize', function () {
+      const invalidResponse = {
+        tx: '0100000001c7dad3d9607a23c45a6c1c5ad7bce02acff71a0f21eb4a72a59d0c0e19402d0f0000000000ffffffff0180a21900000000001976a914c918e1b36f2c72b1aaef94dbb7f578a4b68b542788ac00000000',
+        fee: 10000,
+        feeRate: 20000,
+        // Missing estimatedSize (required)
+        unspents: [],
+      };
+
+      assert.throws(() => {
+        assertDecode(ConstructPendingApprovalTxResponse, invalidResponse);
+      });
+    });
+
+    it('should reject response with missing unspents', function () {
+      const invalidResponse = {
+        tx: '0100000001c7dad3d9607a23c45a6c1c5ad7bce02acff71a0f21eb4a72a59d0c0e19402d0f0000000000ffffffff0180a21900000000001976a914c918e1b36f2c72b1aaef94dbb7f578a4b68b542788ac00000000',
+        fee: 10000,
+        feeRate: 20000,
+        estimatedSize: 256,
+        // Missing unspents (required)
+      };
+
+      assert.throws(() => {
+        assertDecode(ConstructPendingApprovalTxResponse, invalidResponse);
+      });
+    });
+
     it('should reject response with non-string tx', function () {
       const invalidResponse = {
         tx: 123, // number instead of string
@@ -248,6 +312,9 @@ describe('ConstructPendingApprovalTx codec tests', function () {
       const invalidResponse = {
         tx: '0100000001c7dad3d9607a23c45a6c1c5ad7bce02acff71a0f21eb4a72a59d0c0e19402d0f0000000000ffffffff0180a21900000000001976a914c918e1b36f2c72b1aaef94dbb7f578a4b68b542788ac00000000',
         fee: '10000', // string instead of number
+        feeRate: 20000,
+        estimatedSize: 256,
+        unspents: [],
       };
 
       assert.throws(() => {
@@ -258,7 +325,10 @@ describe('ConstructPendingApprovalTx codec tests', function () {
     it('should reject response with non-number feeRate', function () {
       const invalidResponse = {
         tx: '0100000001c7dad3d9607a23c45a6c1c5ad7bce02acff71a0f21eb4a72a59d0c0e19402d0f0000000000ffffffff0180a21900000000001976a914c918e1b36f2c72b1aaef94dbb7f578a4b68b542788ac00000000',
+        fee: 10000,
         feeRate: '20000', // string instead of number
+        estimatedSize: 256,
+        unspents: [],
       };
 
       assert.throws(() => {
@@ -279,7 +349,10 @@ describe('ConstructPendingApprovalTx codec tests', function () {
     it('should reject response with non-number estimatedSize', function () {
       const invalidResponse = {
         tx: '0100000001c7dad3d9607a23c45a6c1c5ad7bce02acff71a0f21eb4a72a59d0c0e19402d0f0000000000ffffffff0180a21900000000001976a914c918e1b36f2c72b1aaef94dbb7f578a4b68b542788ac00000000',
+        fee: 10000,
+        feeRate: 20000,
         estimatedSize: '256', // string instead of number
+        unspents: [],
       };
 
       assert.throws(() => {
@@ -386,6 +459,8 @@ describe('ConstructPendingApprovalTx codec tests', function () {
       fee: 10000,
       feeRate: 20000,
       instant: false,
+      estimatedSize: 256,
+      unspents: [{ id: 'unspent1', value: 1000000 }],
     };
 
     afterEach(function () {