feat(utxo-staking): move assertion utils to fixtures.utils.ts

Move assertion utility functions from transactions.ts to fixtures.utils.ts
for better code organization and reusability.

Issue: BTC-2143

Co-authored-by: llm-git <[email protected]>

Author: OttoAllmendinger

modules/utxo-staking/test/unit/babylon/transactions.ts

@@ -13,7 +13,7 @@ import {
   toUtxoPsbt,
   toWrappedPsbt,
 } from '@bitgo/utxo-core/descriptor';
-import { getFixture, toPlainObject } from '@bitgo/utxo-core/testutil';
+import { toPlainObject } from '@bitgo/utxo-core/testutil';
 import { getBabylonParamByVersion } from '@bitgo/babylonlabs-io-btc-staking-ts';
 
 import {
@@ -25,7 +25,12 @@ import {
   forceFinalizePsbt,
 } from '../../../src/babylon';
 import { parseStakingDescriptor } from '../../../src/babylon/parseDescriptor';
-import { normalize } from '../fixtures.utils';
+import {
+  normalize,
+  assertEqualsFixture,
+  assertEqualsMiniscript,
+  assertTransactionEqualsFixture,
+} from '../fixtures.utils';
 
 import { fromXOnlyPublicKey, getECKey, getECKeys, getXOnlyPubkey } from './key.utils';
 import { getBitGoUtxoStakingMsgCreateBtcDelegation, getVendorMsgCreateBtcDelegation } from './vendor.utils';
@@ -203,18 +208,6 @@ function parseScripts(scripts: unknown) {
   return Object.fromEntries(Object.entries(scripts).map(([key, value]) => [key, parseScript(key, value)]));
 }
 
-type EqualsAssertion = typeof assert.deepStrictEqual;
-
-async function assertEqualsFixture(
-  fixtureName: string,
-  value: unknown,
-  n = normalize,
-  eq: EqualsAssertion = assert.deepStrictEqual
-): Promise<void> {
-  value = n(value);
-  eq(await getFixture(fixtureName, value), value);
-}
-
 async function assertScriptsEqualFixture(
   fixtureName: string,
   builder: vendor.StakingScriptData,
@@ -226,19 +219,6 @@ async function assertScriptsEqualFixture(
   });
 }
 
-async function assertTransactionEqualsFixture(fixtureName: string, tx: unknown): Promise<void> {
-  await assertEqualsFixture(fixtureName, normalize(tx));
-}
-
-function assertEqualsMiniscript(script: Buffer, miniscript: ast.MiniscriptNode): void {
-  const ms = Miniscript.fromBitcoinScript(script, 'tap');
-  assert.deepStrictEqual(ast.fromMiniscript(ms), miniscript);
-  assert.deepStrictEqual(
-    script.toString('hex'),
-    Buffer.from(Miniscript.fromString(ast.formatNode(miniscript), 'tap').encode()).toString('hex')
-  );
-}
-
 function assertEqualScripts(descriptorBuilder: BabylonDescriptorBuilder, builder: vendor.StakingScripts) {
   for (const [key, script] of Object.entries(builder) as [keyof vendor.StakingScripts, Buffer][]) {
     switch (key) {

modules/utxo-staking/test/unit/fixtures.utils.ts

@@ -1,6 +1,9 @@
-import { Descriptor } from '@bitgo/wasm-miniscript';
+import assert from 'assert';
+
+import { ast, Descriptor, Miniscript } from '@bitgo/wasm-miniscript';
 import * as utxolib from '@bitgo/utxo-lib';
 import * as bitcoinjslib from 'bitcoinjs-lib';
+import { getFixture } from '@bitgo/utxo-core/testutil';
 import { toPlainObjectFromTx, toPlainObjectFromPsbt } from '@bitgo/utxo-core/testutil/descriptor';
 
 export function normalize(v: unknown): unknown {
@@ -33,3 +36,28 @@ export function normalize(v: unknown): unknown {
   }
   return v;
 }
+
+type EqualsAssertion = typeof assert.deepStrictEqual;
+
+export async function assertEqualsFixture(
+  fixtureName: string,
+  value: unknown,
+  n = normalize,
+  eq: EqualsAssertion = assert.deepStrictEqual
+): Promise<void> {
+  value = n(value);
+  eq(await getFixture(fixtureName, value), value);
+}
+
+export async function assertTransactionEqualsFixture(fixtureName: string, tx: unknown): Promise<void> {
+  await assertEqualsFixture(fixtureName, normalize(tx));
+}
+
+export function assertEqualsMiniscript(script: Buffer, miniscript: ast.MiniscriptNode): void {
+  const ms = Miniscript.fromBitcoinScript(script, 'tap');
+  assert.deepStrictEqual(ast.fromMiniscript(ms), miniscript);
+  assert.deepStrictEqual(
+    script.toString('hex'),
+    Buffer.from(Miniscript.fromString(ast.formatNode(miniscript), 'tap').encode()).toString('hex')
+  );
+}