Merge pull request #6626 from BitGo/WIN-6494

refactor: refactoring BaseETH evm onboarding configs

Author: DinshawKothari

modules/bitgo/test/v2/unit/keychains.ts

@@ -96,6 +96,7 @@ describe('V2 Keychains', function () {
         n.asset !== UnderlyingAsset.IRYS &&
         n.asset !== UnderlyingAsset.LINEAETH &&
         n.asset !== UnderlyingAsset.IP && // Story Chain
+        n.asset !== UnderlyingAsset.BASEETH &&
         coinFamilyValues.includes(n.name)
     );
 

modules/sdk-core/src/bitgo/environments.ts

@@ -167,7 +167,7 @@ const mainnetBase: EnvironmentTemplate = {
   optimisticEtherscanApiToken: process.env.OPTIMISTIC_ETHERSCAN_API_TOKEN,
   zksyncExplorerBaseUrl: 'https://block-explorer-api.mainnet.zksync.io',
   zksyncExplorerApiToken: process.env.ZKSYNC_EXPLORER_API_TOKEN,
-  baseethExplorerUrl: 'https://api.basescan.org',
+  baseethExplorerUrl: 'https://api.basescan.org', //BaseETH explorer api url
   baseethApiToken: process.env.BASESCAN_API_TOKEN,
   eosNodeUrls: ['https://bp.cryptolions.io', 'https://api.eosnewyork.io', 'https://api.eosdetroit.io'],
   nearNodeUrls: ['https://api.fastnear.com'],

modules/statics/src/base.ts

@@ -29,7 +29,7 @@ export enum CoinFamily {
   ATOM = 'atom',
   AVAXC = 'avaxc',
   AVAXP = 'avaxp',
-  BASEETH = 'baseeth',
+  BASEETH = 'baseeth', // Base Ethereum
   BABY = 'baby',
   BCH = 'bch',
   BCHA = 'bcha',
@@ -456,7 +456,7 @@ export enum UnderlyingAsset {
   APECHAIN = 'apechain',
   API3 = 'api3',
   ARBETH = 'arbeth',
-  BASEETH = 'baseeth',
+  BASEETH = 'baseeth', // Base Ethereum
   ASI = 'asi',
   ATOM = 'atom',
   AVAXC = 'avaxc',

modules/statics/src/coins.ts

@@ -371,7 +371,17 @@ export const coins = CoinMap.fromCoins([
     18,
     UnderlyingAsset.BASEETH,
     BaseUnit.ETH,
-    [...ETH_FEATURES, CoinFeature.USES_NON_PACKED_ENCODING_FOR_TXDATA, CoinFeature.EIP1559]
+    [
+      ...EVM_FEATURES,
+      CoinFeature.USES_NON_PACKED_ENCODING_FOR_TXDATA,
+      CoinFeature.SHARED_EVM_SDK,
+      CoinFeature.SHARED_EVM_SIGNING,
+      CoinFeature.EVM_COMPATIBLE_IMS,
+      CoinFeature.EVM_COMPATIBLE_UI,
+    ],
+    KeyCurve.Secp256k1,
+    '',
+    'tBaseETH'
   ),
   account(
     'd51fe324-1e01-4630-9b04-c724fe495a1c',
@@ -381,7 +391,17 @@ export const coins = CoinMap.fromCoins([
     18,
     UnderlyingAsset.BASEETH,
     BaseUnit.ETH,
-    [...ETH_FEATURES, CoinFeature.USES_NON_PACKED_ENCODING_FOR_TXDATA, CoinFeature.EIP1559]
+    [
+      ...EVM_FEATURES,
+      CoinFeature.USES_NON_PACKED_ENCODING_FOR_TXDATA,
+      CoinFeature.SHARED_EVM_SDK,
+      CoinFeature.SHARED_EVM_SIGNING,
+      CoinFeature.EVM_COMPATIBLE_IMS,
+      CoinFeature.EVM_COMPATIBLE_UI,
+    ],
+    KeyCurve.Secp256k1,
+    '',
+    'BaseETH'
   ),
   account(
     'ffc472f5-27c6-49f8-ad9a-f57659258fb9',

modules/statics/src/networks.ts

@@ -1668,6 +1668,7 @@ class SongbirdTestnet extends Testnet implements EthereumNetwork {
   forwarderImplementationAddress = '0xd5fe1c1f216b775dfd30638fa7164d41321ef79b';
 }
 class BaseChainTestnet extends Testnet implements EthereumNetwork {
+  //BaseETH testnet
   name = 'BaseChainTestnet';
   family = CoinFamily.BASEETH;
   explorerUrl = 'https://sepolia.basescan.org/tx/';
@@ -1682,6 +1683,7 @@ class BaseChainTestnet extends Testnet implements EthereumNetwork {
 }
 
 class BaseChain extends Mainnet implements EthereumNetwork {
+  //BaseETH
   name = 'BaseChain';
   family = CoinFamily.BASEETH;
   explorerUrl = 'https://basescan.org/tx/';

modules/statics/test/unit/fixtures/expectedColdFeatures.ts

@@ -60,6 +60,7 @@ export const expectedColdFeatures = {
     'atom',
     'baby',
     'bera',
+    'baseeth',
     'bld',
     'bsc',
     'coredao',
@@ -108,6 +109,7 @@ export const expectedColdFeatures = {
     'tapt',
     'tbaby',
     'tbera',
+    'tbaseeth',
     'tbld',
     'tbsc',
     'tcoredao',
@@ -157,7 +159,6 @@ export const expectedColdFeatures = {
     'tsonic',
   ],
   neither: [
-    'baseeth',
     'ethw',
     'fiataed',
     'fiateur',
@@ -166,7 +167,6 @@ export const expectedColdFeatures = {
     'fiatusd',
     'lnbtc',
     'susd',
-    'tbaseeth',
     'tbtg',
     'teth',
     'tfiataed',