Merge pull request #7305 from BitGo/WP-6403/add-address-typing

feat(sdk-core): add AddressQueryResult typing for addresses

Author: mohammadalfaiyazbitgo

modules/abstract-lightning/package.json

@@ -39,7 +39,7 @@
     ]
   },
   "dependencies": {
-    "@bitgo/public-types": "5.31.0",
+    "@bitgo/public-types": "5.34.0",
     "@bitgo/sdk-core": "^36.15.0",
     "@bitgo/statics": "^58.7.0",
     "@bitgo/utxo-lib": "^11.13.0",

modules/bitgo/package.json

@@ -138,7 +138,7 @@
     "superagent": "^9.0.1"
   },
   "devDependencies": {
-    "@bitgo/public-types": "5.31.0",
+    "@bitgo/public-types": "5.34.0",
     "@bitgo/sdk-opensslbytes": "^2.1.0",
     "@bitgo/sdk-test": "^9.1.7",
     "@openpgp/web-stream-tools": "0.0.14",

modules/express/package.json

@@ -58,7 +58,7 @@
     "superagent": "^9.0.1"
   },
   "devDependencies": {
-    "@bitgo/public-types": "5.31.0",
+    "@bitgo/public-types": "5.34.0",
     "@bitgo/sdk-lib-mpc": "^10.8.1",
     "@bitgo/sdk-test": "^9.1.7",
     "@types/argparse": "^1.0.36",

modules/sdk-coin-sol/package.json

@@ -40,7 +40,7 @@
     ]
   },
   "dependencies": {
-    "@bitgo/public-types": "5.31.0",
+    "@bitgo/public-types": "5.34.0",
     "@bitgo/sdk-core": "^36.15.0",
     "@bitgo/sdk-lib-mpc": "^10.8.1",
     "@bitgo/statics": "^58.7.0",

modules/sdk-core/package.json

@@ -40,7 +40,7 @@
     ]
   },
   "dependencies": {
-    "@bitgo/public-types": "5.31.0",
+    "@bitgo/public-types": "5.34.0",
     "@bitgo/sdk-lib-mpc": "^10.8.1",
     "@bitgo/secp256k1": "^1.6.0",
     "@bitgo/sjcl": "^1.0.1",

modules/sdk-core/src/bitgo/wallet/iWallet.ts

@@ -31,7 +31,7 @@ import {
 } from '../utils';
 import { SerializedNtilde } from '../../account-lib/mpc/tss/ecdsa/types';
 import { IAddressBook } from '../address-book';
-import { WalletUser } from '@bitgo/public-types';
+import { WalletUser, AddressQueryResult } from '@bitgo/public-types';
 import { SubmitTransactionResponse } from '../inscriptionBuilder';
 
 export interface MaximumSpendableOptions {
@@ -944,7 +944,7 @@ export interface IWallet {
   sweep(params?: SweepOptions): Promise<any>;
   freeze(params?: FreezeOptions): Promise<any>;
   transferComment(params?: TransferCommentOptions): Promise<any>;
-  addresses(params?: AddressesOptions): Promise<any>;
+  addresses(params?: AddressesOptions): Promise<AddressQueryResult>;
   getAddress(params?: GetAddressOptions): Promise<any>;
   createAddress(params?: CreateAddressOptions): Promise<any>;
   updateAddress(params?: UpdateAddressOptions): Promise<any>;

modules/sdk-core/src/bitgo/wallet/wallet.ts

@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import { TxSendBody } from '@bitgo/public-types';
+import { TxSendBody, type AddressQueryResult } from '@bitgo/public-types';
 import { CoinFamily } from '@bitgo/statics';
 import assert from 'assert';
 import BigNumber from 'bignumber.js';
@@ -1078,7 +1078,7 @@ export class Wallet implements IWallet {
    * @param params
    * @returns {*}
    */
-  async addresses(params: AddressesOptions = {}): Promise<any> {
+  async addresses(params: AddressesOptions = {}): Promise<AddressQueryResult> {
     common.validateParams(params, [], []);
 
     const query: AddressesOptions = {};

yarn.lock

@@ -944,10 +944,10 @@
     "@scure/base" "1.1.5"
     micro-eth-signer "0.7.2"
 
-"@bitgo/public-types@5.31.0":
-  version "5.31.0"
-  resolved "https://registry.npmjs.org/@bitgo/public-types/-/public-types-5.31.0.tgz#1af37545bdaaf6bb65de6a9c47cb38817d16472c"
-  integrity sha512-4uiFZHcwVPwfDKLG/lNPy8zIfp8esVxAjXLWrx5LUHZBKguphWWgmx6RzP2LwFr6H4GZ7pxDO3xr7AF0RRL3Ug==
+"@bitgo/public-types@5.34.0":
+  version "5.34.0"
+  resolved "https://registry.npmjs.org/@bitgo/public-types/-/public-types-5.34.0.tgz#ffd7b8ac438ca70901ce904583c9a504dc5c5b4b"
+  integrity sha512-HnCf9Mpoy3BoIDsaZvRQACBYbmLyt3tyWFIuR10T1Q3/LZnUeJYuYLIdprVp8vRAztqKwr9NRn3/V4Gg3gLccw==
   dependencies:
     fp-ts "^2.0.0"
     io-ts "npm:@bitgo-forks/[email protected]"