feat(sdk-coin-icp): enhance address validation and add memo ID support

TICKET: WIN-4759

Author: mohd-kashif

modules/sdk-coin-icp/src/icp.ts

@@ -78,7 +78,7 @@ export class Icp extends BaseCoin {
   }
 
   isValidAddress(address: string): boolean {
-    throw new Error('Method not implemented.');
+    return utils.isValidAddress(address);
   }
 
   signTransaction(_: SignTransactionOptions): Promise<SignedTransaction> {

modules/sdk-coin-icp/src/lib/utils.ts

@@ -37,13 +37,31 @@ export class Utils implements BaseUtils {
   }
 
   /**
-   * Checks if the provided address is a valid hexadecimal string.
+   * Checks if the provided address is a valid ICP address.
    *
    * @param {string} address - The address to validate.
-   * @returns {boolean} - Returns `true` if the address is a valid 64-character hexadecimal string, otherwise `false`.
+   * @returns {boolean} - Returns `true` if the address is valid, otherwise `false`.
    */
   isValidAddress(address: string): boolean {
-    return this.isValidHash(address);
+    const rootAddress = this.validateMemoAndReturnRootAddress(address);
+    return rootAddress !== undefined && this.isValidHash(rootAddress);
+  }
+
+  /**
+   * Validates the memo ID in the address and returns the root address.
+   *
+   * @param {string} address - The address to validate and extract the root address from.
+   * @returns {string | undefined} - The root address if valid, otherwise `undefined`.
+   */
+  validateMemoAndReturnRootAddress(address: string): string | undefined {
+    if (!address) {
+      return undefined;
+    }
+    const [rootAddress, memoId] = address.split('?memoId=');
+    if (memoId && this.validateMemo(BigInt(memoId))) {
+      return rootAddress;
+    }
+    return address;
   }
 
   /**
@@ -268,32 +286,48 @@ export class Utils implements BaseUtils {
     return { pub, prv };
   }
 
-  validateFee(fee: string): void {
-    if (new BigNumber(fee).isEqualTo(0)) {
-      throw new BuildTransactionError('Fee equal to zero');
-    }
-    if (fee !== this.gasData()) {
-      throw new BuildTransactionError('Invalid fee value');
+  /**
+   * Validates the provided fee.
+   *
+   * @param {string} fee - The fee to validate.
+   * @throws {BuildTransactionError} - If the fee is zero or invalid.
+   */
+  validateFee(fee: string): boolean {
+    const feeValue = new BigNumber(fee);
+    if (feeValue.isZero()) {
+      throw new BuildTransactionError('Fee cannot be zero');
     }
+    return true;
   }
 
   /** @inheritdoc */
-  validateValue(value: BigNumber): void {
+  validateValue(value: BigNumber): boolean {
     if (value.isLessThanOrEqualTo(0)) {
       throw new BuildTransactionError('amount cannot be less than or equal to zero');
     }
+    return true;
   }
 
-  validateMemo(memo: number | BigInt): void {
-    if (Number(memo) < 0 || Number(memo) === null || Number(memo) === undefined || Number.isNaN(Number(memo))) {
+  /**
+   * Validates the provided memo.
+   *
+   * @param {number | BigInt} memo - The memo to validate.
+   * @returns {boolean} - Returns `true` if the memo is valid.
+   * @throws {BuildTransactionError} - If the memo is invalid.
+   */
+  validateMemo(memo: number | BigInt): boolean {
+    const memoNumber = Number(memo);
+    if (memoNumber < 0 || Number.isNaN(memoNumber)) {
       throw new BuildTransactionError('Invalid memo');
     }
+    return true;
   }
 
-  validateExpireTime(expireTime: number | BigInt): void {
+  validateExpireTime(expireTime: number | BigInt): boolean {
     if (Number(expireTime) < Date.now() * 1000_000) {
       throw new BuildTransactionError('Invalid expiry time');
     }
+    return true;
   }
 
   /**

modules/sdk-coin-icp/test/resources/icp.ts

@@ -34,7 +34,7 @@ export const accounts = {
   account6: {
     secretKey: '8d08c0393b707cd90c37213025fe7ed13c05b267d946ca1b6e0fd3b0e47ec188',
     publicKey: '02ad010ce68b75266c723bf25fbe3a0c48eb29f14b25925b06b7f5026a0f12702e',
-    address: '2b9b89604362e185544c8bba76cadff1a3af26e1467e8530d13743a08a52dd7b',
+    address: '2b9b89604362e185544c8bba76cadff1a3af26e1467e8530d13743a08a52dd7b?memoId=0',
   },
   errorsAccounts: {
     account1: {