Merge pull request #6894 from BitGo/SC-2858

fix: failing vechain tests

Author: Gautam2305

modules/sdk-coin-vet/src/lib/constants.ts

@@ -4,7 +4,7 @@ export const VET_BLOCK_ID_LENGTH = 64;
 
 export const TRANSFER_TOKEN_METHOD_ID = '0xa9059cbb';
 export const STAKING_METHOD_ID = '0xa694fc3a';
-export const EXIT_DELEGATION_METHOD_ID = '0x32b7006d';
+export const EXIT_DELEGATION_METHOD_ID = '0x3fb7a871';
 export const BURN_NFT_METHOD_ID = '0x42966c68';
 export const TRANSFER_NFT_METHOD_ID = '0x23b872dd';
 

modules/sdk-coin-vet/src/lib/transaction/burnNftTransaction.ts

@@ -116,7 +116,7 @@ export class BurnNftTransaction extends Transaction {
       }
 
       // Set sender address
-      if (signedTx.origin) {
+      if (signedTx.signature && signedTx.origin) {
         this.sender = signedTx.origin.toString().toLowerCase();
       }
 

modules/sdk-coin-vet/src/lib/transaction/exitDelegation.ts

@@ -116,7 +116,7 @@ export class ExitDelegationTransaction extends Transaction {
       }
 
       // Set sender address
-      if (signedTx.origin) {
+      if (signedTx.signature && signedTx.origin) {
         this.sender = signedTx.origin.toString().toLowerCase();
       }
 

modules/sdk-coin-vet/src/lib/transactionBuilder/exitDelegationBuilder.ts

@@ -120,6 +120,8 @@ export class ExitDelegationBuilder extends TransactionBuilder {
   /** @inheritdoc */
   protected async buildImplementation(): Promise<Transaction> {
     this.transaction.type = this.transactionType;
+    // Set the transaction data before building
+    this.exitDelegationTransaction.transactionData = this.getExitDelegationData();
     await this.exitDelegationTransaction.build();
     return this.transaction;
   }

modules/sdk-coin-vet/test/transactionBuilder/burnNftBuilder.ts

@@ -92,11 +92,9 @@ describe('Vet Burn NFT Transaction', () => {
       const txBuilder = factory.getBurnNftBuilder();
 
       // Should throw error when building without required fields
-      await should(txBuilder.build()).be.rejectedWith('transaction not defined');
-
-      txBuilder.sender(testData.addresses.validAddresses[0]);
       await should(txBuilder.build()).be.rejectedWith('NFT contract address is required');
 
+      txBuilder.sender(testData.addresses.validAddresses[0]);
       txBuilder.nftContract();
       await should(txBuilder.build()).be.rejectedWith('Token ID is required');
 

modules/sdk-coin-vet/test/transactionBuilder/exitDelegationBuilder.ts

@@ -97,11 +97,9 @@ describe('Vet Exit Delegation Transaction', () => {
       const txBuilder = factory.getExitDelegationBuilder();
 
       // Should throw error when building without required fields
-      await should(txBuilder.build()).be.rejectedWith('transaction not defined');
-
-      txBuilder.sender(testData.addresses.validAddresses[0]);
       await should(txBuilder.build()).be.rejectedWith('Delegation contract address is required');
 
+      txBuilder.sender(testData.addresses.validAddresses[0]);
       txBuilder.delegationContract();
       await should(txBuilder.build()).be.rejectedWith('Token ID is required');