Skip to content

Commit 3b4f53c

Browse files
committed
fix(sdk-coin-trx): isValidAddress allows only base58 address format
BREAKING CHANGE: isValidAddress for Tron used to allow hex addresses and base58 format addresses. But Tron build API expect addresses to be passed in Base58check format. Hence removing the support of hex addresses TICKET: COIN-3940
1 parent 71163f2 commit 3b4f53c

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

modules/sdk-coin-trx/src/trx.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,15 +190,15 @@ export class Trx extends BaseCoin {
190190
}
191191

192192
/**
193-
* Checks if this is a valid base58 or hex address
193+
* Checks if this is a valid base58
194194
* @param address
195195
*/
196196
isValidAddress(address: string): boolean {
197197
if (!address) {
198198
return false;
199199
}
200200

201-
return this.isValidHexAddress(address) || Utils.isBase58Address(address);
201+
return Utils.isBase58Address(address);
202202
}
203203

204204
/**

modules/sdk-coin-trx/test/unit/trx.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,17 +62,14 @@ describe('TRON:', function () {
6262
'TBChwKYNaTo4a4N68Me1qEiiKsRDspXqLLZ',
6363
'0x96be113992bdc3be24c11f6017085b605d253649',
6464
'0x341qg3922b1',
65-
];
66-
const goodAddresses = [
67-
'TBChwKYNaTo4a4N68Me1qEiiKsRDspXqLp',
68-
'TPcf5jtYUhCN1X14tN577zF4NepbDZbxT7',
6965
'41E0C0F581D7D02D40826C1C6CBEE71F625D6344D0',
7066
'412C2BA4A9FF6C53207DC5B686BFECF75EA7B80577',
7167
'418840E6C55B9ADA326D211D818C34A994AECED808',
7268
'412A2B9F7641D0750C1E822D0E49EF765C8106524B',
7369
'41A614F803B6FD780986A42C78EC9C7F77E6DED13C',
7470
'418840E6C55B9ADA326D211D818C34A994AECED808',
7571
];
72+
const goodAddresses = ['TBChwKYNaTo4a4N68Me1qEiiKsRDspXqLp', 'TPcf5jtYUhCN1X14tN577zF4NepbDZbxT7'];
7673

7774
badAddresses.map((addr) => {
7875
assert.equal(basecoin.isValidAddress(addr), false);

0 commit comments

Comments
 (0)