Merge pull request #5571 from BitGo/manas/WIN-4658-remove-deadalus-support-from-ada

feat: remove Daedalus address support from ADA wallets

Author: manas-at-bitgo

modules/sdk-coin-ada/src/lib/utils.ts

@@ -180,6 +180,12 @@ export class Utils implements BaseUtils {
 
     //Check for Byron-era address
     try {
+      // Reject Daedalus wallet addresses (Byron-era addresses starting with "DdzFF")
+      if (address.startsWith('DdzFF')) {
+        console.log(`Rejecting Daedalus wallet address: ${address}`);
+        return false;
+      }
+
       const decoded = bs58.decode(address);
       const cborData = cbor.decodeFirstSync(decoded);
       return Array.isArray(cborData) && cborData.length >= 2;
@@ -270,6 +276,11 @@ export class Utils implements BaseUtils {
 
     // Try decoding as a Byron (base58) address later
     try {
+      // Reject Daedalus wallet addresses (Byron-era addresses starting with "DdzFF")
+      if (address.startsWith('DdzFF')) {
+        throw new InvalidAddressError('Provided string is a Daedalus address');
+      }
+
       return ByronAddress.from_base58(address).to_address();
     } catch (e) {
       console.error(`Could not decode byron address from string '${address}'`);
@@ -295,9 +306,12 @@ export class Utils implements BaseUtils {
       return address.to_bech32();
     }
 
-    // If not Shelley, try Byron
     const byronAddress = ByronAddress.from_address(address);
+    // Reject Daedalus wallet addresses (Byron-era addresses starting with "DdzFF")
     if (byronAddress) {
+      if (byronAddress.to_base58().startsWith('DdzFF')) {
+        throw new InvalidAddressError('Provided address is a Daedalus address');
+      }
       return byronAddress.to_base58();
     }
 

modules/sdk-coin-ada/test/resources/index.ts

@@ -23,7 +23,7 @@ export const address = {
   byron3:
     '37btjrVyb4KEB2STADSsj3MYSAdj52X5FrFWpw2r7Wmj2GDzXjFRsHWuZqrw7zSkwopv8Ci3VWeg6bisU9dgJxW5hb2MZYeduNKbQJrqz3zVBsu9nT', // Valid Byron testnet
   byron4: 'Ae2tdPwUPE_invalid_address', // Invalid Byron (malformed Base58)
-  byron5: 'DdzFFzCqr_invalid_base58', // Invalid Byron (malformed Base58)
+  byron5: 'DdzFFzCqrhsfZHjaBunVySZBU8i9Zom7Gujham6Jz8scCcAdkDmEbD9XSdXKdBiPoa1fjgL4ksGjQXD8ZkSNHGJfT25ieA9rWNCSA5qc', // Invalid Daedalus type)
   byron6: '37btjrVyb4KDX_invalid_CBOR', // Invalid CBOR structure
 };