chore: pass EthLikeCommon in explainTransaction

TICKET: COIN-2736

Author: kamleshmugdiya

modules/abstract-eth/src/abstractEthLikeCoin.ts

@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import EthereumCommon from '@ethereumjs/common';
+import type * as EthLikeCommon from '@ethereumjs/common';
 import { CoinFamily, BaseCoin as StaticsBaseCoin } from '@bitgo/statics';
 import { bip32 } from '@bitgo/utxo-lib';
 import { randomBytes } from 'crypto';
@@ -58,6 +58,7 @@ export interface ExplainTransactionOptions {
     txHex: string;
   };
   feeInfo: TransactionFee;
+  common?: EthLikeCommon.default;
 }
 
 export interface HalfSignedEthLikeTransaction extends HalfSignedAccountTransaction {
@@ -195,7 +196,7 @@ export abstract class AbstractEthLikeCoin extends BaseCoin {
     if (!txHex || !params.feeInfo) {
       throw new Error('missing explain tx parameters');
     }
-    const txBuilder = this.getTransactionBuilder();
+    const txBuilder = this.getTransactionBuilder(params.common);
     txBuilder.from(txHex);
     const tx = await txBuilder.build();
     const outputs = tx.outputs.map((output) => {
@@ -224,5 +225,5 @@ export abstract class AbstractEthLikeCoin extends BaseCoin {
    * Create a new transaction builder for the current chain
    * @return a new transaction builder
    */
-  protected abstract getTransactionBuilder(common?: EthereumCommon): TransactionBuilder;
+  protected abstract getTransactionBuilder(common?: EthLikeCommon.default): TransactionBuilder;
 }

modules/sdk-coin-ethlike/test/fixtures/ethlikeCoin.ts

@@ -61,6 +61,11 @@ export const ccr = {
       '0xf9012e018541314cf000836acfc0948ce59c2d1702844f8eded451aa103961bc37b4e880b9010439125215000000000000000000000000eeaf0f05f37891ab4a21208b105a0687d12c5af7000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000000002710000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000e000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000830cddff8080',
     txid: '0xc6cff6f06e0452f85886c1e4f212a3fe444fe981939f80d8aad98e9a8507e526',
   },
+  tbaseeth: {
+    txHex:
+      '0x02f9019683014a3402850ba43b740085746a5288008307a1209412fdf58540285273f9ddee9eac6f566418d6e7ac80b9016439125215000000000000000000000000b9f62c71d5f6949cfb211a67fb13ccf079cc760b00000000000000000000000000000000000000000000000000005af3107a400000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000066cc72e2000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000e0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000410eddb08026d2d5ba942ed77d4caef5bf3c3d7b4282bd4d2defcbc9c113c5f9af10d803b211fc0ea8b16263a614444abfc5d20dea24db28b833c0e15063400c411c00000000000000000000000000000000000000000000000000000000000000c0808080',
+    txid: '0x663729bbb68b7638a7a58194e69546d64bb5536422f30557ef0118028317f3a8',
+  },
 };
 export const encryptedUserKey =
   '{"iv":"VFZ3jvXhxo1Z+Yaf2MtZnA==","v":1,"iter":10000,"ks":256,"ts":64,"mode"\n' +

modules/sdk-coin-ethlike/test/unit/ethlikeCoin.ts

@@ -213,6 +213,40 @@ describe('EthLikeCoin', function () {
     assert(fullSignedTxn.txHex);
   });
 
+  describe('explainTransaction', function () {
+    const txHex = mockData.ccr[coinName].txHex;
+    const feeInfo = {
+      fee: '1000000000',
+      gasLimit: '100000',
+    };
+
+    it('should explain transaction when common is provided', async function () {
+      const explanation = await basecoin.explainTransaction({
+        txHex,
+        feeInfo,
+        common: baseChainCommon,
+      });
+
+      explanation.should.have.property('id');
+      explanation.should.have.property('outputs');
+      explanation.should.have.property('outputAmount');
+      explanation.should.have.property('changeOutputs');
+      explanation.should.have.property('changeAmount');
+      explanation.should.have.property('fee');
+      explanation.fee.should.equal(feeInfo);
+      explanation.outputs.should.be.an.Array();
+    });
+
+    it('should fail to explain transaction when common is not provided', async function () {
+      await basecoin
+        .explainTransaction({
+          txHex,
+          feeInfo,
+        })
+        .should.be.rejectedWith('Common must be provided for EthLikeTransactionBuilder');
+    });
+  });
+
   describe('Recovery', function () {
     const baseUrl = 'https://api-sepolia.basescan.org/';
     const userXpub =