fix(sdk-coin-stx): fix issue in verifyTx for sip10 tokens

COIN-3616
TICKET: COIN-3616

Author: gianchandania

modules/sdk-coin-stx/src/sip10Token.ts

@@ -1,18 +1,14 @@
 import _ from 'lodash';
 import BigNumber from 'bignumber.js';
 
-import { BitGoBase, CoinConstructor, Memo, NamedCoinConstructor, VerifyTransactionOptions } from '@bitgo/sdk-core';
+import { BitGoBase, CoinConstructor, NamedCoinConstructor, VerifyTransactionOptions } from '@bitgo/sdk-core';
 import { BaseCoin as StaticsBaseCoin, coins, NetworkType, Sip10TokenConfig, tokens } from '@bitgo/statics';
 
 import { Stx } from './stx';
 import { TransactionBuilderFactory } from './lib';
 import { TransactionBuilder } from './lib/transactionBuilder';
 import { getMemoIdAndBaseAddressFromAddress } from './lib/utils';
 
-export interface Sip10VerifyTransactionOptions extends VerifyTransactionOptions {
-  memo?: Memo;
-}
-
 export class Sip10Token extends Stx {
   public readonly tokenConfig: Sip10TokenConfig;
 
@@ -77,8 +73,9 @@ export class Sip10Token extends Stx {
     return new TransactionBuilderFactory(coinConfig).getFungibleTokenTransferBuilder();
   }
 
-  async verifyTransaction(params: Sip10VerifyTransactionOptions): Promise<boolean> {
-    const { txPrebuild: txPrebuild, txParams: txParams, memo: memo } = params;
+  async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> {
+    const { txPrebuild: txPrebuild, txParams: txParams } = params;
+    const { memo } = txParams;
     if (Array.isArray(txParams.recipients) && txParams.recipients.length > 1) {
       throw new Error(
         `${this.getChain()} doesn't support sending to more than 1 destination address within a single transaction. Try again, using only a single recipient.`

modules/sdk-coin-stx/test/unit/sip10Token.ts

@@ -1,7 +1,7 @@
 import _ from 'lodash';
 import { BitGoAPI } from '@bitgo/sdk-api';
 import { TestBitGo, TestBitGoAPI } from '@bitgo/sdk-test';
-import { ITransactionRecipient, Wallet } from '@bitgo/sdk-core';
+import { ITransactionRecipient, Wallet, Memo } from '@bitgo/sdk-core';
 
 import { Sip10Token } from '../../src';
 import * as testData from '../fixtures';
@@ -11,7 +11,7 @@ describe('Sip10Token:', function () {
   let bitgo: TestBitGoAPI;
   let basecoin: Sip10Token;
   let newTxPrebuild: () => { txHex: string; txInfo: Record<string, unknown> };
-  let newTxParams: () => { recipients: ITransactionRecipient[] };
+  let newTxParams: () => { recipients: ITransactionRecipient[]; memo?: Memo };
   let wallet: Wallet;
 
   const txPreBuild = {
@@ -50,13 +50,13 @@ describe('Sip10Token:', function () {
     it('should succeed to verify transaction', async function () {
       const txPrebuild = newTxPrebuild();
       const txParams = newTxParams();
+      txParams.memo = memo;
       const verification = {};
       const isTransactionVerified = await basecoin.verifyTransaction({
         txParams,
         txPrebuild,
         verification,
         wallet,
-        memo,
       });
       isTransactionVerified.should.equal(true);
     });
@@ -69,13 +69,14 @@ describe('Sip10Token:', function () {
           return { address, amount: Number(amount), memo, tokenName };
         }
       );
+      txParamsWithNumberAmounts.memo = memo;
+
       const verification = {};
       const isTransactionVerified = await basecoin.verifyTransaction({
         txParams: txParamsWithNumberAmounts,
         txPrebuild,
         verification,
         wallet,
-        memo,
       });
       isTransactionVerified.should.equal(true);
     });
@@ -85,7 +86,7 @@ describe('Sip10Token:', function () {
       txPrebuild.txHex = testData.txForExplainFungibleTokenTransferWithMemoId10;
       const txParams = newTxParams();
       const verification = {};
-      const memo = {
+      txParams.memo = {
         type: '',
         value: '10',
       };
@@ -94,7 +95,6 @@ describe('Sip10Token:', function () {
         txPrebuild,
         verification,
         wallet,
-        memo,
       });
       isTransactionVerified.should.equal(true);
     });
@@ -103,7 +103,7 @@ describe('Sip10Token:', function () {
       const txPrebuild = newTxPrebuild();
       const txParams = newTxParams();
       txPrebuild.txHex = testData.txForExplainFungibleTokenTransferWithMemoZero;
-      const memo = {
+      txParams.memo = {
         type: '',
         value: '0',
       };
@@ -113,7 +113,6 @@ describe('Sip10Token:', function () {
         txPrebuild,
         verification,
         wallet,
-        memo,
       });
       isTransactionVerified.should.equal(true);
     });

modules/sdk-core/src/bitgo/baseCoin/iBaseCoin.ts

@@ -8,7 +8,7 @@ import { IPendingApprovals } from '../pendingApproval';
 import { InitiateRecoveryOptions } from '../recovery';
 import { EcdsaMPCv2Utils, EcdsaUtils } from '../utils/tss/ecdsa';
 import EddsaUtils, { PrebuildTransactionWithIntentOptions, TxRequest } from '../utils/tss/eddsa';
-import { CreateAddressFormat, CustomSigningFunction, IWallet, IWallets, Wallet, WalletData } from '../wallet';
+import { CreateAddressFormat, CustomSigningFunction, IWallet, IWallets, Wallet, WalletData, Memo } from '../wallet';
 
 import { IWebhooks } from '../webhook/iWebhooks';
 import { TransactionType } from '../../account-lib';
@@ -136,6 +136,7 @@ export interface TransactionParams {
   recipients?: ITransactionRecipient[];
   walletPassphrase?: string;
   type?: string;
+  memo?: Memo;
 }
 
 export interface AddressVerificationData {