refactor: reverting walletId back to id

TICKET: WP-5418

Author: danielzhao122

modules/express/src/clientRoutes.ts

@@ -663,7 +663,7 @@ export async function handleV2GenerateWallet(req: express.Request) {
 export async function handleV2CreateAddress(req: ExpressApiRouteRequest<'express.v2.wallet.createAddress', 'post'>) {
   const bitgo = req.bitgo;
   const coin = bitgo.coin(req.decoded.coin);
-  const wallet = await coin.wallets().get({ id: req.decoded.walletId });
+  const wallet = await coin.wallets().get({ id: req.decoded.id });
   return wallet.createAddress(req.decoded);
 }
 

modules/express/src/typedRoutes/api/v2/createAddress.ts

@@ -10,7 +10,7 @@ export const CreateAddressParams = {
   /** Coin ticker / chain identifier */
   coin: t.string,
   /** The ID of the wallet. */
-  walletId: t.string,
+  id: t.string,
 } as const;
 
 /**
@@ -62,6 +62,7 @@ export const CreateAddressResponse = {
 /**
  * Create address for a wallet
  *
+ * @tag express
  * @operationId express.v2.wallet.createAddress
  */
 export const PostCreateAddress = httpRoute({

modules/express/test/unit/clientRoutes/createAddress.ts

@@ -31,15 +31,15 @@ describe('Create Address', () => {
       bitgo: bitgoStub,
       params: {
         coin: 'tbtc',
-        walletId: '23423423423423',
+        id: '23423423423423',
       },
       query: {},
       body: {
         chain: 0,
       },
       decoded: {
         coin: 'tbtc',
-        walletId: '23423423423423',
+        id: '23423423423423',
         chain: 0,
       },
     } as unknown as ExpressApiRouteRequest<'express.v2.wallet.createAddress', 'post'>;

modules/express/test/unit/typedRoutes/decode.ts

@@ -193,16 +193,16 @@ describe('io-ts decode tests', function () {
   });
 
   it('express.v2.wallet.createAddress params', function () {
-    // missing walletId
+    // missing id
     assert.throws(() => assertDecode(t.type(CreateAddressParams), { coin: 'btc' }));
     // coin must be string
     assert.throws(() =>
-      assertDecode(t.type(CreateAddressParams), { coin: 123, walletId: '59cd72485007a239fb00282ed480da1f' })
+      assertDecode(t.type(CreateAddressParams), { coin: 123, id: '59cd72485007a239fb00282ed480da1f' })
     );
-    // walletId must be string
-    assert.throws(() => assertDecode(t.type(CreateAddressParams), { coin: 'btc', walletId: 123 }));
+    // id must be string
+    assert.throws(() => assertDecode(t.type(CreateAddressParams), { coin: 'btc', id: 123 }));
     // valid params
-    assertDecode(t.type(CreateAddressParams), { coin: 'btc', walletId: '59cd72485007a239fb00282ed480da1f' });
+    assertDecode(t.type(CreateAddressParams), { coin: 'btc', id: '59cd72485007a239fb00282ed480da1f' });
     // invalid body
     assert.throws(() => assertDecode(t.type(CreateAddressBody), { chain: '1' }));
     assert.throws(() => assertDecode(t.type(CreateAddressBody), { format: 'invalid' }));