Merge pull request #6208 from BitGo/WIN-5535

fix(sdk-coin-polyx): fix toJson method in polyx transaction

Author: nvrakesh06

modules/abstract-substrate/src/lib/transaction.ts

@@ -128,7 +128,6 @@ export class Transaction extends BaseTransaction {
 
   /** @inheritdoc */
   toJson(): TxData {
-    console.log('Transaction toJson called in substrate Transaction class');
     if (!this._substrateTransaction) {
       throw new InvalidTransactionError('Empty transaction');
     }

modules/sdk-coin-polyx/src/lib/index.ts

@@ -11,5 +11,6 @@ export {
 export { TransactionBuilderFactory } from './transactionBuilderFactory';
 export { TransferBuilder } from './transferBuilder';
 export { RegisterDidWithCDDBuilder } from './registerDidWithCDDBuilder';
+export { Transaction as PolyxTransaction } from './transaction';
 export { Utils, default as utils } from './utils';
 export * from './iface';

modules/sdk-coin-polyx/src/lib/transaction.ts

@@ -7,7 +7,6 @@ import { DecodedTx, RegisterDidWithCDDArgs } from './iface';
 export class Transaction extends SubstrateTransaction {
   /** @inheritdoc */
   toJson(): Interface.TxData {
-    console.log('Transaction toJson called in polyx Transaction class');
     if (!this._substrateTransaction) {
       throw new InvalidTransactionError('Empty transaction');
     }
@@ -39,6 +38,7 @@ export class Transaction extends SubstrateTransaction {
         pub: Buffer.from(decodeAddress(targetAccount)).toString('hex'),
       });
       result.to = keypairDest.getAddress(this.getAddressFormat());
+      result.amount = '0'; // RegisterDidWithCDD does not transfer any value
     } else {
       super.toJson();
     }

modules/sdk-coin-polyx/src/lib/transferBuilder.ts

@@ -85,8 +85,6 @@ export class TransferBuilder extends TransactionBuilder {
       const to = txMethod.dest.id;
       const memo = txMethod.memo;
 
-      console.log(`Validating TransferWithMemo transaction: amount=${amount}, to=${to}, memo=${memo}`);
-
       const validationResult = Schema.TransferWithMemoTransactionSchema.validate({ amount, to, memo });
       if (validationResult.error) {
         throw new InvalidTransactionError(`Invalid transaction: ${validationResult.error.message}`);

modules/sdk-coin-polyx/test/unit/transactionBuilder/registerDidWithCDDBuilder.ts

@@ -43,6 +43,7 @@ describe('Polyx Register DID with CDD builder Builder', () => {
       builder.addSignature({ pub: sender.publicKey }, Buffer.from(mockTssSignature, 'hex'));
       const tx = await builder.build();
       const txJson = tx.toJson();
+      should.deepEqual(txJson.amount, '0');
       should.deepEqual(txJson.to, receiver.address);
       should.deepEqual(txJson.sender, sender.address);
       should.deepEqual(txJson.blockNumber, 3933);
@@ -75,6 +76,7 @@ describe('Polyx Register DID with CDD builder Builder', () => {
       builder.addSignature({ pub: sender.publicKey }, Buffer.from(mockTssSignature, 'hex'));
       const tx = await builder.build();
       const txJson = tx.toJson();
+      should.deepEqual(txJson.amount, '0');
       should.deepEqual(txJson.to, receiver.address);
       should.deepEqual(txJson.sender, sender.address);
       should.deepEqual(txJson.blockNumber, 3933);
@@ -106,6 +108,7 @@ describe('Polyx Register DID with CDD builder Builder', () => {
         .fee({ amount: 0, type: 'tip' });
       const tx = await builder.build();
       const txJson = tx.toJson();
+      should.deepEqual(txJson.amount, '0');
       should.deepEqual(txJson.to, receiver.address);
       should.deepEqual(txJson.sender, sender.address);
       should.deepEqual(txJson.blockNumber, 3933);
@@ -126,6 +129,7 @@ describe('Polyx Register DID with CDD builder Builder', () => {
         .referenceBlock('0x149799bc9602cb5cf201f3425fb8d253b2d4e61fc119dcab3249f307f594754d');
       const tx = await builder.build();
       const txJson = tx.toJson();
+      should.deepEqual(txJson.amount, '0');
       should.deepEqual(txJson.to, '5EFWg5wKTgkFE9XCxigBYPYKQg173djwSmRbkALCdL1jFVUU');
       should.deepEqual(txJson.sender, '5E7XWJRysj27EzibT4duRxrBQT9Qfa7Z5nAAvJmvd32nhkjH');
       should.deepEqual(txJson.blockNumber, 3933);
@@ -149,6 +153,7 @@ describe('Polyx Register DID with CDD builder Builder', () => {
 
       const tx = await builder.build();
       const txJson = tx.toJson();
+      should.deepEqual(txJson.amount, '0');
       should.deepEqual(txJson.to, '5EFWg5wKTgkFE9XCxigBYPYKQg173djwSmRbkALCdL1jFVUU');
       should.deepEqual(txJson.sender, sender.address);
       should.deepEqual(txJson.blockNumber, 3933);