Skip to content

Commit 4a92834

Browse files
committed
Revert "feat(sdk-coin-apt): recommend min gas tank balance for next 1000 txns."
1 parent 6eb3acf commit 4a92834

File tree

5 files changed

+0
-36
lines changed

5 files changed

+0
-36
lines changed

modules/sdk-coin-apt/src/apt.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -183,16 +183,6 @@ export class Apt extends BaseCoin {
183183
throw new Error('Method not implemented.');
184184
}
185185

186-
/** @inheritDoc */
187-
getGasTankLowBalanceAlertThresholdFactor(): number {
188-
return 200;
189-
}
190-
191-
/** @inheritDoc */
192-
getGasTankMinBalanceRecommendationFactor(): number {
193-
return 1000;
194-
}
195-
196186
private getBuilder(): TransactionBuilderFactory {
197187
return new TransactionBuilderFactory(coins.get(this.getChain()));
198188
}

modules/sdk-coin-apt/test/unit/apt.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,11 @@ describe('APT:', function () {
5757
apt.getFamily().should.equal('apt');
5858
apt.getFullName().should.equal('Aptos');
5959
apt.getBaseFactor().should.equal(1e8);
60-
apt.getGasTankLowBalanceAlertThresholdFactor().should.equal(200);
61-
apt.getGasTankMinBalanceRecommendationFactor().should.equal(1000);
6260

6361
tapt.getChain().should.equal('tapt');
6462
tapt.getFamily().should.equal('apt');
6563
tapt.getFullName().should.equal('Testnet Aptos');
6664
tapt.getBaseFactor().should.equal(1e8);
67-
tapt.getGasTankLowBalanceAlertThresholdFactor().should.equal(200);
68-
tapt.getGasTankMinBalanceRecommendationFactor().should.equal(1000);
6965
});
7066

7167
it('is valid pub', function () {

modules/sdk-coin-arbeth/test/unit/arbeth.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,6 @@ describe('Arbitrum', function () {
106106
arbeth.getFamily().should.equal('arbeth');
107107
arbeth.getFullName().should.equal('Arbitrum Ethereum (L2 Chain)');
108108
arbeth.getBaseFactor().should.equal(1e18);
109-
arbeth.getGasTankLowBalanceAlertThresholdFactor().should.equal(2);
110-
arbeth.getGasTankMinBalanceRecommendationFactor().should.equal(10);
111109
});
112110

113111
it('should return the right info for tarbeth', function () {
@@ -118,8 +116,6 @@ describe('Arbitrum', function () {
118116
tarbeth.getFamily().should.equal('arbeth');
119117
tarbeth.getFullName().should.equal('Testnet Arbitrum Ethereum (L2 Chain)');
120118
tarbeth.getBaseFactor().should.equal(1e18);
121-
tarbeth.getGasTankLowBalanceAlertThresholdFactor().should.equal(2);
122-
tarbeth.getGasTankMinBalanceRecommendationFactor().should.equal(10);
123119
});
124120
});
125121

modules/sdk-core/src/bitgo/baseCoin/baseCoin.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -599,20 +599,4 @@ export abstract class BaseCoin implements IBaseCoin {
599599
setCoinSpecificFieldsInIntent(intent: PopulatedIntent, params: PrebuildTransactionWithIntentOptions): void {
600600
return;
601601
}
602-
603-
/**
604-
* Gets the multiplying factor of fee estimate to alert for low fee address balance
605-
* i.e. alert threshold balance = factor * fee estimate
606-
*/
607-
getGasTankLowBalanceAlertThresholdFactor(): number {
608-
return 2;
609-
}
610-
611-
/**
612-
* Gets the multiplying factor of fee estimate for recommending the fee address min. balance
613-
* i.e. recommended min. balance = factor * fee estimate
614-
*/
615-
getGasTankMinBalanceRecommendationFactor(): number {
616-
return 10;
617-
}
618602
}

modules/sdk-core/src/bitgo/baseCoin/iBaseCoin.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -544,6 +544,4 @@ export interface IBaseCoin {
544544
getHashFunction(): Hash;
545545
broadcastTransaction(params: BaseBroadcastTransactionOptions): Promise<BaseBroadcastTransactionResult>;
546546
setCoinSpecificFieldsInIntent(intent: PopulatedIntent, params: PrebuildTransactionWithIntentOptions): void;
547-
getGasTankLowBalanceAlertThresholdFactor(): number;
548-
getGasTankMinBalanceRecommendationFactor(): number;
549547
}

0 commit comments

Comments
 (0)