feat: flrp validators and delegator

TICKET: WIN-7084

Author: yogeshwar-bitgo

modules/sdk-coin-flrp/src/lib/constants.ts

@@ -1,7 +1,7 @@
 // Shared constants for Flare P-Chain (flrp) utilities and key handling.
 // Centralizing avoids magic numbers scattered across utils and keyPair implementations.
 
-export const DECODED_BLOCK_ID_LENGTH = 36; // Expected decoded block identifier length
+export const DECODED_BLOCK_ID_LENGTH = 32; // Expected decoded block identifier length
 export const SHORT_PUB_KEY_LENGTH = 50; // Placeholder (potential CB58 encoded form length)
 export const COMPRESSED_PUBLIC_KEY_LENGTH = 66; // 33 bytes (compressed) hex encoded
 export const UNCOMPRESSED_PUBLIC_KEY_LENGTH = 130; // 65 bytes (uncompressed) hex encoded
@@ -176,6 +176,15 @@ export const AMOUNT_FIELD = 'amount'; // Amount field
 export const TXID_FIELD = 'txid'; // Transaction ID field
 export const OUTPUT_IDX_FIELD = 'outputidx'; // Output index field
 
+// Transaction explanation field names
+export const ID_FIELD = 'id'; // ID field name
+export const OUTPUT_AMOUNT_FIELD = 'outputAmount'; // Output amount field
+export const CHANGE_AMOUNT_FIELD = 'changeAmount'; // Change amount field
+export const OUTPUTS_FIELD = 'outputs'; // Outputs field
+export const CHANGE_OUTPUTS_FIELD = 'changeOutputs'; // Change outputs field
+export const FEE_FIELD = 'fee'; // Fee field
+export const TYPE_FIELD = 'type'; // Type field
+
 // Signature and hash methods
 export const SECP256K1_SIG_TYPE = 'secp256k1'; // SECP256K1 signature type
 export const DER_FORMAT = 'der'; // DER format
@@ -210,6 +219,25 @@ export const REWARD_ADDRESSES_FIELD = 'rewardAddresses'; // Reward addresses fie
 export const SOURCE_CHAIN_FIELD = 'sourceChain'; // Source chain field
 export const DESTINATION_CHAIN_FIELD = 'destinationChain'; // Destination chain field
 
+// Asset and network constants
+export const FLR_ASSET_ID = 'FLR'; // Default FLR asset ID
+
+// Placeholder constants for development
+export const FLARE_TX_HEX_PLACEHOLDER = 'flare-tx-hex-placeholder'; // Transaction hex placeholder
+export const FLARE_SIGNABLE_PAYLOAD = 'flare-signable-payload'; // Signable payload placeholder
+export const FLARE_TRANSACTION_ID_PLACEHOLDER = 'flare-transaction-id-placeholder'; // Transaction ID placeholder
+export const PLACEHOLDER_NODE_ID = 'placeholder-node-id'; // Node ID placeholder
+
+// Chain identifiers (short forms)
+export const P_CHAIN_SHORT = 'P'; // P-chain short name
+export const X_CHAIN_SHORT = 'X'; // X-chain short name
+
+// Valid source chains for imports
+export const VALID_IMPORT_SOURCE_CHAINS = [P_CHAIN_SHORT, P_CHAIN_FULL, X_CHAIN_SHORT, X_CHAIN_FULL]; // Valid source chains for C-chain imports
+
+// Valid P-chain import types
+export const VALID_P_CHAIN_IMPORT_TYPES = [PLATFORM_VM_IMPORT_TX, IMPORT_TX_TYPE, IMPORT_TYPE, P_CHAIN_IMPORT_TYPE]; // Valid P-chain import types
+
 // Error messages for transactionBuilder
 export const ERROR_NETWORK_ID_MISMATCH = 'Network ID mismatch'; // Network ID validation error
 export const ERROR_BLOCKCHAIN_ID_MISMATCH_BUILDER = 'Blockchain ID mismatch'; // Blockchain ID validation error

modules/sdk-coin-flrp/src/lib/importInCTxBuilder.ts

@@ -28,6 +28,12 @@ import {
   ERROR_FAILED_INITIALIZE_BUILDER,
   OBJECT_TYPE_STRING,
   HEX_ENCODING,
+  VALID_IMPORT_SOURCE_CHAINS,
+  P_CHAIN_SHORT,
+  UTF8_ENCODING,
+  IMPORT_C_TYPE,
+  TRANSFERABLE_INPUT_TYPE,
+  CREDENTIAL_TYPE,
 } from './constants';
 
 /**
@@ -237,7 +243,7 @@ export class ImportInCTxBuilder extends AtomicInCTransactionBuilder {
       }));
 
       // Get source chain ID (typically P-chain for C-chain imports)
-      const sourceChainId = this._externalChainId ? this._externalChainId.toString('hex') : 'P';
+      const sourceChainId = this._externalChainId ? this._externalChainId.toString(HEX_ENCODING) : P_CHAIN_SHORT;
 
       // Calculate fee
       const fee = BigInt(this.transaction._fee.fee || DEFAULT_EVM_GAS_FEE); // EVM-style gas fee
@@ -271,7 +277,7 @@ export class ImportInCTxBuilder extends AtomicInCTransactionBuilder {
           },
         ],
         fee,
-        type: 'import-c',
+        type: IMPORT_C_TYPE,
         fromAddresses: fromAddresses.map((addr) => addr.toString('hex')),
         toAddress: Buffer.from(toAddress).toString('hex'),
         // Add FlareJS-specific metadata for future integration
@@ -336,7 +342,7 @@ export class ImportInCTxBuilder extends AtomicInCTransactionBuilder {
 
         // FlareJS compatibility markers
         _flareJSReady: true,
-        _type: 'TransferableInput',
+        _type: TRANSFERABLE_INPUT_TYPE,
 
         // Methods for FlareJS compatibility
         getAmount: () => BigInt(amount.toString()),
@@ -355,7 +361,7 @@ export class ImportInCTxBuilder extends AtomicInCTransactionBuilder {
 
         // FlareJS compatibility markers
         _flareJSReady: true,
-        _type: 'Credential',
+        _type: CREDENTIAL_TYPE,
 
         // Methods for FlareJS compatibility
         addSignature: (signature: Buffer) => enhancedCredential.signatures.push(signature),
@@ -433,13 +439,13 @@ export class ImportInCTxBuilder extends AtomicInCTransactionBuilder {
     }
 
     // Valid source chains for C-chain imports in Flare network
-    const validSourceChains = ['P', 'P-chain', 'X', 'X-chain'];
+    const validSourceChains = VALID_IMPORT_SOURCE_CHAINS;
     const chainIdNormalized = chainId.replace('-chain', '').toUpperCase();
 
     // Check if it's a predefined chain identifier
     if (validSourceChains.some((chain) => chain.replace('-chain', '').toUpperCase() === chainIdNormalized)) {
       // Store normalized chain ID (e.g., 'P' for P-chain)
-      this._externalChainId = Buffer.from(chainIdNormalized, 'utf8');
+      this._externalChainId = Buffer.from(chainIdNormalized, UTF8_ENCODING);
       return this;
     }
 
@@ -459,7 +465,7 @@ export class ImportInCTxBuilder extends AtomicInCTransactionBuilder {
     try {
       this._externalChainId = Buffer.from(chainId, 'hex');
     } catch (error) {
-      this._externalChainId = Buffer.from(chainId, 'utf8');
+      this._externalChainId = Buffer.from(chainId, UTF8_ENCODING);
     }
 
     return this;

modules/sdk-coin-flrp/src/lib/importInPTxBuilder.ts

@@ -18,6 +18,13 @@ import {
   OBJECT_TYPE_STRING,
   STRING_TYPE,
   NUMBER_TYPE,
+  VALID_P_CHAIN_IMPORT_TYPES,
+  EXPORT_TYPE,
+  SEND_TYPE,
+  IMPORT_TYPE,
+  P_CHAIN_FULL,
+  C_CHAIN_FULL,
+  UTF8_ENCODING,
 } from './constants';
 
 /**
@@ -158,15 +165,15 @@ export class ImportInPTxBuilder extends AtomicTransactionBuilder {
       }
 
       // Check for P-chain import transaction type markers
-      const validTypes = ['PlatformVM.ImportTx', 'ImportTx', 'import', 'P-chain-import'];
+      const validTypes = VALID_P_CHAIN_IMPORT_TYPES;
 
       // Primary type verification
       if (tx.type && typeof tx.type === STRING_TYPE) {
         if (validTypes.includes(tx.type as string)) {
           return true;
         }
         // If type is specified but not valid, return false (like 'export')
-        if (tx.type === 'export' || tx.type === 'send') {
+        if (tx.type === EXPORT_TYPE || tx.type === SEND_TYPE) {
           return false;
         }
       }
@@ -185,8 +192,8 @@ export class ImportInPTxBuilder extends AtomicTransactionBuilder {
       // FlareJS-specific markers
       const hasFlareJSMarkers =
         tx._flareJSReady === true ||
-        tx._txType === 'import' ||
-        tx._chainType === 'P-chain' ||
+        tx._txType === IMPORT_TYPE ||
+        tx._chainType === P_CHAIN_FULL ||
         tx._pvmCompatible === true;
 
       // Enhanced validation for FlareJS compatibility
@@ -276,7 +283,7 @@ export class ImportInPTxBuilder extends AtomicTransactionBuilder {
             threshold: this.transaction._threshold,
             locktime: this.transaction._locktime,
             // FlareJS import output markers
-            _destinationChain: 'P-chain',
+            _destinationChain: P_CHAIN_FULL,
             _flareJSReady: true,
           },
         ],
@@ -358,8 +365,8 @@ export class ImportInPTxBuilder extends AtomicTransactionBuilder {
           _pvmCompatible: true,
         },
         // Enhanced metadata for FlareJS compatibility
-        _sourceChain: 'C-chain',
-        _destinationChain: 'P-chain',
+        _sourceChain: C_CHAIN_FULL,
+        _destinationChain: P_CHAIN_FULL,
       };
 
       // Store the input (type assertion for compatibility)
@@ -461,11 +468,11 @@ export class ImportInPTxBuilder extends AtomicTransactionBuilder {
         chainBuffer = Buffer.from(chainId, HEX_ENCODING);
       } else {
         // For all other formats, store as UTF-8
-        chainBuffer = Buffer.from(chainId, 'utf8');
+        chainBuffer = Buffer.from(chainId, UTF8_ENCODING);
       }
     } catch (error) {
       // Fallback to UTF-8 if hex parsing fails
-      chainBuffer = Buffer.from(chainId, 'utf8');
+      chainBuffer = Buffer.from(chainId, UTF8_ENCODING);
     }
 
     this._externalChainId = chainBuffer;

modules/sdk-coin-flrp/src/lib/permissionlessValidatorTxBuilder.ts

@@ -4,6 +4,7 @@ import { AtomicTransactionBuilder } from './atomicTransactionBuilder';
 import { Tx } from './iface';
 import { TransactionWithExtensions } from './types';
 import {
+  ADD_PERMISSIONLESS_VALIDATOR_TYPE,
   BLS_PUBLIC_KEY_COMPRESSED_LENGTH,
   BLS_PUBLIC_KEY_UNCOMPRESSED_LENGTH,
   BLS_SIGNATURE_LENGTH,
@@ -258,7 +259,7 @@ export class PermissionlessValidatorTxBuilder extends AtomicTransactionBuilder {
       // TODO: Implement actual FlareJS PVM API call when available
       // For now, create a placeholder transaction structure
       const validatorTx = {
-        type: 'addPermissionlessValidator',
+        type: ADD_PERMISSIONLESS_VALIDATOR_TYPE,
         nodeID: this._nodeID,
         blsPublicKey: this._blsPublicKey,
         blsSignature: this._blsSignature,

modules/sdk-coin-flrp/src/lib/transaction.ts

@@ -21,6 +21,19 @@ import {
 } from './iface';
 import { KeyPair } from './keyPair';
 import utils from './utils';
+import {
+  FLR_ASSET_ID,
+  FLARE_TX_HEX_PLACEHOLDER,
+  FLARE_SIGNABLE_PAYLOAD,
+  FLARE_TRANSACTION_ID_PLACEHOLDER,
+  PLACEHOLDER_NODE_ID,
+  HEX_ENCODING,
+  MEMO_FIELD,
+  DISPLAY_ORDER_BASE,
+  REWARD_ADDRESSES_FIELD,
+  SOURCE_CHAIN_FIELD,
+  DESTINATION_CHAIN_FIELD,
+} from './constants';
 
 /**
  * Flare P-chain transaction implementation using FlareJS
@@ -51,7 +64,7 @@ export class Transaction extends BaseTransaction {
   constructor(coinConfig: Readonly<CoinConfig>) {
     super(coinConfig);
     this._network = coinConfig.network as FlareNetwork;
-    this._assetId = 'FLR'; // Default FLR asset
+    this._assetId = FLR_ASSET_ID; // Default FLR asset
     this._blockchainID = this._network.blockchainID || '';
     this._networkID = this._network.networkID || 0;
   }
@@ -158,7 +171,7 @@ export class Transaction extends BaseTransaction {
   }
 
   toHexString(byteArray: Uint8Array): string {
-    return Buffer.from(byteArray).toString('hex');
+    return Buffer.from(byteArray).toString(HEX_ENCODING);
   }
 
   /** @inheritdoc */
@@ -169,7 +182,7 @@ export class Transaction extends BaseTransaction {
 
     // TODO: Implement FlareJS transaction serialization
     // For now, return placeholder
-    return 'flare-tx-hex-placeholder';
+    return FLARE_TX_HEX_PLACEHOLDER;
   }
 
   toJson(): TxData {
@@ -228,7 +241,7 @@ export class Transaction extends BaseTransaction {
 
     // TODO: Implement FlareJS signable payload extraction
     // For now, return placeholder
-    return Buffer.from('flare-signable-payload');
+    return Buffer.from(FLARE_SIGNABLE_PAYLOAD);
   }
 
   get id(): string {
@@ -238,7 +251,7 @@ export class Transaction extends BaseTransaction {
 
     // TODO: Implement FlareJS transaction ID generation
     // For now, return placeholder
-    return 'flare-transaction-id-placeholder';
+    return FLARE_TRANSACTION_ID_PLACEHOLDER;
   }
 
   get fromAddresses(): string[] {
@@ -271,7 +284,7 @@ export class Transaction extends BaseTransaction {
         // TODO: Extract validator outputs from FlareJS transaction
         return [
           {
-            address: this._nodeID || 'placeholder-node-id',
+            address: this._nodeID || PLACEHOLDER_NODE_ID,
             value: this._stakeAmount?.toString() || '0',
           },
         ];
@@ -280,7 +293,7 @@ export class Transaction extends BaseTransaction {
         // TODO: Extract delegator outputs from FlareJS transaction
         return [
           {
-            address: this._nodeID || 'placeholder-node-id',
+            address: this._nodeID || PLACEHOLDER_NODE_ID,
             value: this._stakeAmount?.toString() || '0',
           },
         ];
@@ -318,7 +331,7 @@ export class Transaction extends BaseTransaction {
     // TODO: Implement FlareJS signature creation
     // This should use FlareJS signing utilities
     const signval = utils.createSignature(this._network, this.signablePayload, prv);
-    return signval.toString('hex');
+    return signval.toString(HEX_ENCODING);
   }
 
   /**
@@ -331,11 +344,11 @@ export class Transaction extends BaseTransaction {
   /** @inheritdoc */
   explainTransaction(): TransactionExplanation {
     const txJson = this.toJson();
-    const displayOrder = ['id', 'inputs', 'outputAmount', 'changeAmount', 'outputs', 'changeOutputs', 'fee', 'type'];
+    const displayOrder = [...DISPLAY_ORDER_BASE];
 
     // Add memo to display order if present
     if (this.hasMemo()) {
-      displayOrder.push('memo');
+      displayOrder.push(MEMO_FIELD);
     }
 
     // Calculate total output amount
@@ -362,12 +375,12 @@ export class Transaction extends BaseTransaction {
 
     if (stakingTypes.includes(txJson.type)) {
       rewardAddresses = this.rewardAddresses;
-      displayOrder.splice(6, 0, 'rewardAddresses');
+      displayOrder.splice(6, 0, REWARD_ADDRESSES_FIELD);
     }
 
     // Add cross-chain information for export/import
     if (this.isTransactionForCChain) {
-      displayOrder.push('sourceChain', 'destinationChain');
+      displayOrder.push(SOURCE_CHAIN_FIELD, DESTINATION_CHAIN_FIELD);
     }
 
     const explanation: TransactionExplanation & { memo?: string } = {