Merge pull request #5189 from BitGo/BTC-1450.bump-typescript

feat: bump typescript to 5.7

Author: OttoAllmendinger

modules/abstract-eth/package.json

@@ -58,6 +58,7 @@
     "superagent": "^9.0.1"
   },
   "devDependencies": {
+    "@types/keccak": "^3.0.5",
     "@bitgo/sdk-api": "^1.56.7",
     "@bitgo/sdk-test": "^8.0.54"
   }

modules/abstract-eth/src/lib/transferBuilder.ts

@@ -155,8 +155,8 @@ export class TransferBuilder {
 
     if (this._coinUsesNonPackedEncodingForTxData) {
       const types: string[] = operationData[0] as string[];
-      const values: string[] = operationData[1].map((item) =>
-        item instanceof Buffer ? '0x' + item.toString('hex') : item
+      const values: (string | number)[] = operationData[1].map((item) =>
+        typeof item === 'string' || typeof item === 'number' ? item : '0x' + item.toString('hex')
       );
       operationHash = keccak256(defaultAbiCoder.encode(types, values));
     } else {
@@ -166,7 +166,7 @@ export class TransferBuilder {
     return operationHash;
   }
 
-  protected getOperationData(): (string | Buffer)[][] {
+  protected getOperationData(): (string | number | Buffer)[][] {
     let operationData;
     const prefix = this.getOperationHashPrefix();
     if (this._tokenContractAddress !== undefined) {

modules/account-lib/package.json

@@ -75,6 +75,7 @@
   "devDependencies": {
     "@solana/web3.js": "1.92.1",
     "@types/bs58": "^4.0.1",
+    "@types/keccak": "^3.0.5",
     "keccak": "3.0.3",
     "paillier-bigint": "3.3.0",
     "shx": "^0.3.4"

modules/account-lib/test/unit/mpc/tss/ecdsa/ecdsa.ts

@@ -340,7 +340,7 @@ describe('TSS ECDSA TESTS', function () {
         // and delta share received from the other signer
 
         const hashGenerator = (hashType?: string): Hash | undefined => {
-          return hashType === 'keccak256' ? createKeccakHash('keccak256') : undefined;
+          return hashType === 'keccak256' ? (createKeccakHash('keccak256') as Hash) : undefined;
         };
         const [signA, signB] = [
           MPC.sign(

modules/account-lib/tsconfig.json

@@ -7,7 +7,7 @@
     "esModuleInterop": true,
     "typeRoots": ["../../types", "./node_modules/@types", "../../node_modules/@types"]
   },
-  "include": ["src/**/*", "resources/**/*"],
+  "include": ["src/**/*", "test/**/*", "resources/**/*"],
   "exclude": ["node_modules"],
   "references": [
     {

modules/sdk-api/src/v1/wallet.ts

@@ -2173,7 +2173,7 @@ Wallet.prototype.consolidateUnspents = function (params, callback) {
     return consolidationTransactions;
   });
 
-  return runNextConsolidation(this, target)
+  return runNextConsolidation()
     .catch(function (err) {
       if (err.message === 'Done') {
         return;

modules/sdk-api/test/unit/v1/wallet.ts

@@ -23,8 +23,7 @@ const TestBitGo = {
   TEST_WALLET1_PASSCODE: 'iVWeATjqLS1jJShrPpETti0b',
 };
 const originalFetchConstants = BitGoAPI.prototype.fetchConstants;
-BitGoAPI.prototype.fetchConstants = function () {
-  // @ts-expect-error - no implicit this
+BitGoAPI.prototype.fetchConstants = function (this: any) {
   nock(this._baseUrl).get('/api/v1/client/constants').reply(200, { ttl: 3600, constants: {} });
 
   // force client constants reload

modules/sdk-coin-ada/src/ada.ts

@@ -161,7 +161,7 @@ export class Ada extends BaseCoin {
   /** @inheritDoc */
   async signMessage(key: KeyPair, message: string | Buffer): Promise<Buffer> {
     const adaKeypair = new AdaKeyPair({ prv: key.prv });
-    const messageHex = message instanceof Buffer ? message.toString('hex') : message;
+    const messageHex = typeof message === 'string' ? message : message.toString('hex');
 
     return Buffer.from(adaKeypair.signMessage(messageHex));
   }

modules/sdk-coin-avaxc/package.json

@@ -58,6 +58,7 @@
   "devDependencies": {
     "@bitgo/sdk-api": "^1.56.7",
     "@bitgo/sdk-test": "^8.0.54",
+    "@types/keccak": "^3.0.5",
     "ethers": "^5.1.3"
   }
 }

modules/sdk-coin-cspr/src/cspr.ts

@@ -247,7 +247,7 @@ export class Cspr extends BaseCoin {
    */
   async signMessage(key: KeyPair, message: string | Buffer): Promise<Buffer> {
     const keyPair = new CsprLib.KeyPair({ prv: key.prv });
-    const messageHex = message instanceof Buffer ? message.toString('hex') : message;
+    const messageHex = typeof message === 'string' ? message : message.toString('hex');
     const signatureData = CsprLib.Utils.signMessage(keyPair, messageHex);
     return Buffer.from(signatureData.signature);
   }