Merge pull request #5236 from BitGo/WP-3257

fix(sdk-core): fix MPCv2 SMC wallet generation

Author: zahin-mohammad

modules/bitgo/test/v2/unit/wallets.ts

@@ -976,6 +976,7 @@ describe('V2 Wallets:', function () {
             keyType: 'tss',
             commonKeychain,
             derivedFromParentWithSeed: '37',
+            isMPCv2: true,
           })
           .times(1)
           .reply(200, {
@@ -991,6 +992,7 @@ describe('V2 Wallets:', function () {
             keyType: 'tss',
             commonKeychain,
             derivedFromParentWithSeed: '37',
+            isMPCv2: true,
           })
           .times(1)
           .reply(200, {

modules/sdk-core/src/bitgo/wallet/wallets.ts

@@ -1038,11 +1038,12 @@ export class Wallets implements IWallets {
     const reqId = new RequestTracer();
     this.bitgo.setRequestTracer(reqId);
 
+    let multisigTypeVersion: 'MPCv2' | undefined;
     if (multisigType === 'tss' && this.baseCoin.getMPCAlgorithm() === 'ecdsa') {
       const tssSettings: TssSettings = await this.bitgo
         .get(this.bitgo.microservicesUrl('/api/v2/tss/settings'))
         .result();
-      const multisigTypeVersion =
+      multisigTypeVersion =
         tssSettings.coinSettings[this.baseCoin.getFamily()]?.walletCreationSettings?.coldMultiSigTypeVersion;
       walletVersion = this.determineEcdsaMpcWalletVersion(walletVersion, multisigTypeVersion);
     }
@@ -1071,6 +1072,7 @@ export class Wallets implements IWallets {
       keyType: 'tss',
       commonKeychain: commonKeychain,
       derivedFromParentWithSeed: coldDerivationSeed,
+      isMPCv2: multisigTypeVersion === 'MPCv2' ? true : undefined,
     };
     const userKeychain = await this.baseCoin.keychains().add(userKeychainParams);
 
@@ -1079,6 +1081,7 @@ export class Wallets implements IWallets {
       keyType: 'tss',
       commonKeychain: commonKeychain,
       derivedFromParentWithSeed: coldDerivationSeed,
+      isMPCv2: multisigTypeVersion === 'MPCv2' ? true : undefined,
     };
 
     const backupKeychain = await this.baseCoin.keychains().add(backupKeyChainParams);